Commit graph

498 commits

Author SHA1 Message Date
Rushabh Mehta
ddee23f5ad fix(ui): sortable sidebar, fixes to breadcrumbs etc 2024-09-06 14:12:36 +05:30
Akhil Narang
182ba2396f
fix: don't let getattr() raise an AttributeError, provide a default
Re-doing https://github.com/frappe/frappe/pull/27669 overwritten by https://github.com/frappe/frappe/pull/27563
2024-09-05 16:54:06 +02:00
Gavin D'souza
37316627c4
Merge branch 'develop' into set_link_titles 2024-09-05 13:41:24 +02:00
gavin
6704295415
Merge pull request #27276 from Mutantpenguin/patch-1
fix: 🐛 show link titles for virtual link fields too
2024-09-04 16:07:19 +02:00
Akhil Narang
d35dbf0d5b
fix(assign_to): escape HTML
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-30 17:30:15 +05:30
Gavin D'souza
7f7c97d499
fix: Set doc title name as fallback
When the title field is unset for a document, it's value gets unset in a
link field on click. Added this fallback on the endpoint so that
clicking on field doesn't add an additional API call to fetch the title
via Desk.

Co-authored-by: Marica Dsouza <maricadsouza221197@gmail.com>
2024-08-29 20:07:31 +02:00
Raffael Meyer
6c5a099c1e
fix: translatable strings (#27443) 2024-08-19 14:43:19 +00:00
Rushabh Mehta
b5caddeb6f fix(minor): test 2024-08-14 16:13:57 +05:30
Rushabh Mehta
398657c7fa fix(minor): test 2024-08-14 16:13:57 +05:30
Rushabh Mehta
17bb9d535b fix(minor): test 2024-08-14 16:13:57 +05:30
Rushabh Mehta
1d678146a9 fix(styles): cleaner sidebars for list and form 2024-08-14 16:13:57 +05:30
Markus Lobedann
b170be419c fix: 🐛 show link titles for virtual link fields too 2024-08-07 12:16:50 +02:00
Akhil Narang
01de5ad796
Merge pull request #26978 from blaggacao/fix/email-record-linking
fix: email record linking via rfc5233 & rfc5322
2024-07-18 15:14:55 +05:30
Sumit Bhanushali
bdb180da2a
Merge pull request #26901 from mahsem/fix-translation-in-load.py
fix: translation in load.py
2024-07-13 11:45:07 +05:30
Sumit Bhanushali
de4c275e66 fix: doc name cannot be translated 2024-07-13 11:30:34 +05:30
mahsem
ac894ae560 fix: translation in load.py
fix: translation in load.py
2024-07-11 12:03:38 +00:00
David
b0c57843c4
fix: plus quoting for better mta compatibility 2024-07-05 11:03:21 +02:00
Gavin D'souza
cdacca91a6
refactor: get_linked_docs
- Cleaner logic flows
 - Better variables naming & use of standard/cleaner APIs
 - Use get_list to show only permitted docs
2024-06-27 13:39:00 +02:00
Akhil Narang
5050376c55
fix(document_follow): following was treated as a string not a boolean
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-09 14:02:19 +05:30
Rutwik Hiwalkar
c195b3b649 fix: typo 2024-04-17 22:05:46 +05:30
Rutwik Hiwalkar
82d61b32e4 fix: misc fixes for discard action
* use write perms instead of cancel
* update docstring
* remove discard from global namespace
2024-04-17 12:32:34 +05:30
Rutwik Hiwalkar
b274c45992 feat: discard draft transactions 2024-04-16 19:46:34 +05:30
Ankush Menat
b7bc5d3236
fix(round 3): switch to creation sorting (#25669) 2024-03-27 08:59:04 +00:00
Ankush Menat
dbcf7ad30c refactor: update usage of modified everywhere 2024-03-27 11:23:13 +05:30
Ankush Menat
8e3175f3e8
fix: show attachments on notifications too (#25443) 2024-03-14 13:01:10 +00:00
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
barredterra
10bd9a7efd fix: use communication date in timeline
Before, we used the database creation date, which coincidentally corresponds to the real communication date in many cases.
2024-02-13 15:36:53 +01:00
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
8a71054c0c
Merge pull request #24765 from ankush/black_to_ruff
ci: switch to ruff-format
2024-02-05 19:20:51 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Ankush Menat
b6eef6ebc2
fix: Skip virtual doctypes in link field checks (#24759) 2024-02-05 18:04:31 +05:30
David Arnold
c57bc94ead
chore: cleanup frappe.connect invocations 2024-01-24 11:56:24 +01:00
mergify[bot]
4655c6c1e3
Merge pull request #23678 from niraj2477/gh-20969
feat(List View): Add button to remove multiple assignments
2024-01-13 07:57:17 +00:00
Akhil Narang
55088ce7bd
chore: translate subject as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-10 16:21:36 +05:30
Akhil Narang
e29b39f7df
refactor: use receiver's language for some notifications
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-10 16:21:36 +05:30
Ankush Menat
a16db1be32
fix: show relative path in loaded JS (#23964)
[skip ci]
2023-12-27 10:46:30 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
14987
ab915e3a81
feat: Add button to removing multiple assignments 2023-12-08 13:22:39 +05:30
barredterra
c35476256f refactor: simplify conditional logic
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Raffael Meyer
f0155674a5
refactor!: remove redundant sending of translations (#22962)
* chore!: remove redundant translation

* refactor!: remove "get_translated_dict" hook

Instead, include the results from
`frappe.geo.country_info.get_translated_dict` in `get_all_translations`.

* test: money_in_words uses translated currency

... and now we have translations.

* Revert "test: money_in_words uses translated currency"

This reverts commit e07d594ac1ce4b120c0fceb5d23377cb981fe820.

* refactor!: stop translating timezone and currency

* refactor: rename `get_translated_dict`

... to `get_translated_countries`
2023-11-02 20:04:14 +05:30
Ankush Menat
6926669577 perf: Ignore amended_from link fields in link field checks
Small perf benefit at not much cost. `amended_from` are *always*
refererring to cancelled documents so there's no need to check these
fields.
2023-10-31 15:03:08 +05:30
Ankush Menat
08b92858a3
fix: ignore duplicate perm check on assign hooks (#22832)
* fix: Ignore permissions while assigning if flag set

* fix: Avoid double permission checks on assignment rule

When it's triggered via doc events either:
- Permission check is done or
- Permission checks are not applicable
2023-10-20 06:18:19 +00:00
Maharshi Patel
409a3a8105 Merge branch 'develop' into fix-attach-before-doc-save 2023-10-19 11:40:20 +05:30
Ankush Menat
440612f3b9
fix: Check perms before sharing linked docs (#22783) 2023-10-17 18:53:09 +05:30
Ankush Menat
691eae8e84
fix: check read before assigning/removing (#22779) 2023-10-17 18:51:44 +05:30
Maharshi Patel
fd1fe44850 fix: cypress and add check for __islocal
changed check for __islocal as well in savedocs

As new route ends with random hash instead of numbers,
updated cypress test to just check start of data-route instead of entire path
2023-10-17 17:19:53 +05:30
Ankush Menat
018ed845bd refactor: defer unnecessary json-dumping of messages
Also avoid accessing locals where interface is present like for popping last message.
2023-10-16 18:13:50 +05:30
Maharshi Patel
d9a8b7ee78 chore: rename __temporary_name & check temp_doc_name
* renamed file_relink_temp_docname to __temporary_name
* added check for temp_doc_name in relink_files in case someone
    calls the function it directly
2023-10-13 10:20:03 +05:30
Maharshi Patel
53cdd6d1bf fix: relink attachments before saving doc
Certain people add attachment, before filling mandatory fields
which will raise Missing Fields error.

Or any other kind of errors raised by different validators due to which
file is uploaded but doc is not saved.

This will lead to orphaned/mislinked files. ex. new-purchase-receipt-1

This fix changes name of new docs to new-<doctype>-<no>-<10digithash>
after saving the document we can use this new name to find any mislinked
files created in past hour and relink them to the new doc on save.
2023-10-10 23:49:16 +05:30
Ankush Menat
d20e436e0f perf: fetch user info in one query 2023-09-18 11:16:20 +05:30