Commit graph

287 commits

Author SHA1 Message Date
Rushabh Mehta
0c8b9be47b fix(style): print format 2024-09-10 15:15:15 +05:30
Maharshi Patel
96745b8f46 fix: on load of beta print format set iframe height
there was a edge case where when print format beta was set to default which never ran code which sets the size for container that holds format.
fixed that by make iframe height to 100vh minus navbar and heading on load of beta print format
2024-09-02 11:51:39 +05:30
Nabin Hait
e54274f290
chore: Deleted all the form tours (#27403) 2024-08-20 10:39:40 +05:30
Maharshi Patel
6a6ded156f
chore: warn if wkhtmltopdf is invalid (#26174)
* chore: warn if wkhtmltopdf is invalid

wkhtmltopdf ( with patched qt ) is required to generate pdfs properly.
when user clicks on PDF, pdf will be generated and downloaded.
however, on print preview page warning will be shown.

* chore: refactor based on review comments

* chore: return False incase of exception

* chore: refactor and better naming

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-04-30 10:36:56 +00:00
Ankush Menat
535bc10340
fix: make letterhead attachments public by default (#25925)
Also does it for web page.

Note: This is just default config, users can change while uploading.
2024-04-12 05:14:18 +00:00
Maharshi Patel
9739023c59 fix: add in_install flag to print_format validate
don't validate "Standard Print Format cannot be updated" during installation
2024-04-01 11:59:02 +05:30
Ankush Menat
3896296c6f fix: update sort order in doctypes 2024-03-27 11:18:28 +05:30
barredterra
da1e8750c8 refactor: replace in_list(array, member) with array.includes(member) 2024-03-10 16:09:09 +01:00
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options (#25211)
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Maharshi Patel
0e12cf4281
chore: replace PFB Beta link with Print Designer (#25032)
Replaced Print Format Builder Beta link in print-view to Print Designer.
if App is installed it opens Print Designer, if not it opens Frappe Cloud Marketplace Link.
2024-02-23 20:19:08 +05:30
Raffael Meyer
fc64e8a0fb
feat: pass doctype as context when translating label (#24903) 2024-02-18 19:42:15 +05:30
Ankush Menat
72c2207e0f refactor: useless use of dict in frappe.get_doc 2024-02-10 12:52:38 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Maharshi Patel
3fb418f28f
Merge pull request #23907 from marination/dynamic-header-footer-develop
feat: Letterhead Scripts & fix disappearing header in pdf
2024-02-01 17:43:12 +05:30
Corentin Flr
b474e17f89
fix(print-preview): Fix stale ref to iframe's document 2024-01-24 17:18:07 +01:00
marination
62fa5bc8af fix: Translate Letterhead information string 2024-01-22 16:15:38 +01:00
Ankush Menat
c7e5afee6a refactor: Use arr.includes(item) instead of in_list(arr, item) 2023-12-27 19:33:13 +05:30
marination
29e761671d feat: Letterhead scripts
- feat: Allow script injection into header/footer.html to allow manipulation of styles using page numbers/args received by wkhtmltopdf
- misc: also validate letterhead scripts
- Include scripts in printview as well as pdf
- Add helper instructions & re-arrange fields
2023-12-21 17:25:19 +01:00
barredterra
70c7315ed8 Merge branch 'develop' into jinja-syntax 2023-12-17 19:54:16 +01:00
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified (#23697)
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
barredterra
a83b5b324b feat(Print Format): switch from pure HTML to Jinja highlighting 2023-12-12 20:06:25 +01:00
barredterra
c35476256f refactor: simplify conditional logic
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Ankush Menat
72ca95dec0
fix: Only allow standard print format modification in migrate (#23112)
* fix: Only allow standard print format modification in migrate

AFAIK only valid use case is fixtures and there too it should avoid
"standard".

* chore: typo

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-06 19:28:10 +05:30
Maharshi Patel
d23b543dc9 Merge branch 'develop' into feat-desk-refresh 2023-09-15 12:12:25 +05:30
Maharshi Patel
6590d24151 fix: dark mode, timeline, logo colors
* changed variables from gray-* to dark mode compatible ones.
* timeline style fixes
* change logo with new black colors.
2023-09-15 12:04:17 +05:30
0xsaif
aa7ee1c6b9
refactor: force ipv4 localhost (#22394)
* reafctor: force ipv4 localhost

Replacing "localhost" with "127.0.0.1" in the codebase; sometimes the name localhost force-resolves to ipv6

* revert: leave localhost usage in oauth tests

Change not required.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-13 16:23:23 +05:30
Maharshi Patel
9d0f72d98d
Merge branch 'develop' into feat-desk-refresh 2023-09-05 16:19:54 +05:30
Maharshi Patel
399ce7eb3b fix: typography added letter-spacing
* added function to calculate letterspacing based on espresso
* added mixin to add font-size, font-weight and letter-spacing
* letter spacing is based on size and weight
* changed letter spacing on major places
* misc: minor kanban style fixes and changed border radius for .page-card
2023-09-04 16:03:40 +05:30
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
Maharshi Patel
0307dd4cca
Merge branch 'develop' into feat-desk-refresh 2023-08-24 23:55:42 +05:30
Maharshi Patel
f6ebdc24f4 fix: update icons to espresso for different pages
updated icons on various parts of the page to espresso
2023-08-24 10:21:37 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
David Arnold
fddd3b24f7
test: skip tests on RO app paths which require write access (#21878) 2023-07-31 12:46:23 +05:30
Ankush Menat
927cd647e4 chore: generate type annotations 2023-07-24 15:32:48 +05:30
Ankush Menat
58cf770760 fix: All ESLint errors 2023-07-14 15:25:48 +05:30
Suraj Shetty
eda8be74ca fix: Hide font-size from print format
- Since it is only used in new print format builder
and it can be set via new print format builder's interface
2023-05-31 15:44:05 +05:30
Suraj Shetty
1fd84f6b09 fix: Remove field_id from URL
- scroll to field is not yet supported
2023-05-31 15:42:50 +05:30
Suraj Shetty
55455cef4e fix: Update label
"in PDF" is not required as it is already under PDF settings.
2023-05-31 09:03:07 +05:30
Suraj Shetty
a13592a66a fix: Warn users if "Repeat Header and Footer" is disabled
- and if the user still sets Letterhead

Also, add label to the print options
2023-05-31 08:55:59 +05:30
Suraj Shetty
e429101370 fix(print): Language set in document should have higher precedence 2023-03-14 15:13:35 +05:30
Devin Slauenwhite
2223f97f88
fix: print preview when no letterhead is selected (#20286) 2023-03-10 12:10:22 +05:30
Ankush Menat
8446875257
refactor!: Remove "Set user permission" permtype (#20090)
This has never worked and setting user permission requires system
manager role always (because of permissions on list view)
2023-02-20 16:07:49 +05:30
Shariq Ansari
efd82c464e fix: checkbox is getting squeezed if label is long 2023-02-14 15:57:11 +05:30
Ankush Menat
c69c040186 chore: typo 2023-02-13 18:26:09 +05:30
Ankush Menat
b8ba7dcdb3
fix: Setting default print format (#19862)
- Remove check for developer mode, it's not even valid as we dont allow
  setting default print format like this
- Set in custom doctype if custom doctype else prop setter.
- query meta instead of doctype.

[skip ci]
2023-01-31 17:52:35 +05:30
Samuel Danieli
4d08f50a03
fix: PermissionError (#19856)
* fix: PermissionError

* fix: check perm on customize form

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-31 16:04:40 +05:30
barredterra
0d87870ca3 refactor: better, consistent names 2022-12-08 17:01:35 +01:00
barredterra
6069cde624 fix: remove seemingly useless code 2022-12-08 17:00:46 +01:00
barredterra
c8a196f768 fix: use standard format if none is selected 2022-12-08 16:59:29 +01:00