Ankush Menat
445e1dbd6b
perf: num2words, babel, gettext, sentry imports ( #26475 )
...
num2words - 260KB - Used frequently on ERPNext sites.
babel - 1.1MB Gets imported because of dates, localization
sentry - 2.8MB should be loaded only if envvar is set
gettext - required for reading translations
2024-05-18 07:20:41 +00:00
Akhil Narang
e3e6834b5d
fix: add errors=replace to decode() call
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-17 15:03:32 +05:30
Ankush Menat
513957ee40
Merge pull request #26457 from ankush/ci_skip
...
fix(DX): Don't run CI if there are no tests
2024-05-17 13:17:16 +05:30
Ankush Menat
1b0ad4137a
fix(DX): Don't run CI if there are no tests
...
New apps keep burning CI just to install the app and run nothing.
This adds a small check before install to avoid unnecessary CI runs.
2024-05-17 13:05:06 +05:30
Ankush Menat
afed21e29f
fix: dont translate syntax error messages
...
closes https://github.com/frappe/frappe/issues/26443
2024-05-17 13:05:06 +05:30
Akhil Narang
803b45b9fa
feat: ignore tar: file changed as we read it during backups
...
This seems to occur when new files are being created as we're archiving
the files on a site. Doesn't make sense to fail the entire backup
because of that.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-17 11:39:41 +05:30
Akhil Narang
3a4dd9a671
Merge pull request #26183 from vmatt/data_import_delimiter
...
feat(Data Import): custom csv delimiters, UTF-8 BOM handling
2024-05-15 16:45:31 +05:30
Ankush Menat
6fb6c4035c
Merge pull request #26433 from ankush/query_optimzier
...
feat(recorder): Suggest index for optimizing query
2024-05-14 19:08:41 +05:30
Ankush Menat
bbf18d39cc
Merge pull request #26369 from gavindsouza/refactor-scheduled-server_script
...
refactor!: Server Script (Scheduler Event) & misc APIs
2024-05-13 20:25:29 +05:30
gavin
665a18b063
fix: Implement Truthy.__eq __
...
Implement equality check, compare with True rather than self for a Truthy instance
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-05-13 14:17:40 +02:00
Ankush Menat
16c8a30861
fix: Avoid erasing recorder during clear_cache
...
This reverts commit eadfe86fd834f43925956fa6d759127aaf363441.
2024-05-13 17:41:34 +05:30
Nikhil Kothari
fb2753fcaf
fix: pass user and shared params when checking for cache keys ( #26402 )
...
* fix: pass user and shared params when checking for cache keys
* chore(test): added test for user cache in redis_cache
2024-05-10 12:48:43 +00:00
Ankush Menat
c2d5ef175c
fix: cache github release data per bench ( #26382 )
...
Reduce API calls to github as public calls are limited.
2024-05-09 06:52:39 +00:00
Akhil Narang
123844b10d
chore(csvutils): update messages
...
Avoid semgrep issue with translated string
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-08 16:18:53 +05:30
Akhil Narang
af5af9b7a1
chore(openpyxl): don't set read_only=True while reading an excel file
...
The way openpyxl parses files is very different, and read only seems to break with certain files
It tries to head information about the max rows/columns from the header in the case of read only
which can be wrong sometimes.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-08 11:42:07 +05:30
Mate Laszlo Valko
e69093c82b
feat: CSV import introduce FILE_ENCODING_OPTIONS constant in file.py, cleanup
2024-05-08 07:40:17 +02:00
Gavin D'souza
36c80b77a4
fix: Set value default True for Truthy cls
2024-05-07 17:43:19 +02:00
Gavin D'souza
ffbf7fb9d1
fix!: Document.has_value_changed returns Truthy or False
...
- Return changed value to avoid re-accessing previous object & it's
attribute
- Wrap returned value as Truthy to avoid breaking change in API
2024-05-07 17:29:48 +02:00
Ankush Menat
f8abd09ab9
perf: avoid two layer cache of timezone ( #26340 )
...
It's same thing, system settings are always fetched, no idea what's point of additional layer of caching on top of it.
2024-05-06 13:12:41 +00:00
Ankush Menat
724d886f88
perf: Reduce 1 redis call while dumping monitor logs ( #26337 )
2024-05-06 12:53:36 +00:00
Ankush Menat
45026aed37
feat: give higher priority to minor versions
...
Major versions will be shown when minor updates are exhausted only.
2024-05-04 15:08:35 +05:30
Ankush Menat
a234e79790
refactor: misc changes
...
- Move sys setting check to server side
- tomli import handling
2024-05-04 15:08:34 +05:30
Ankush Menat
e0c171b23b
feat: show security issues count
...
chore: conflicts
2024-05-04 15:08:34 +05:30
Ankush Menat
5ca14bb171
feat: FC specific update notifications
2024-05-04 15:08:34 +05:30
Ankush Menat
330a1b2044
fix: update notifier never running
2024-05-04 12:28:19 +05:30
Rohan
4bfcccfd11
fix: ignore unittest.mock objects during typing validations ( #26301 )
...
* fix: ignore unittest.mock objects during typing validations
* fix: check against base mock class
---------
Co-authored-by: Rohan Bansal <rohan@agritheory.dev>
2024-05-02 11:00:02 +00:00
Ankush Menat
b2ef2cd506
feat: show oldest unscheduled job in health report
2024-05-02 13:39:51 +05:30
Ankush Menat
b0aaeb5096
fix: Dont let one invalid cron fail scheduler
...
Scenario:
- One bad cron job exists
- When it fails nothing after that job is enqueued.
After this fix, that failure is skipped and rest of the jobs are enqueued.
2024-05-02 13:36:14 +05:30
Ankush Menat
ee64b2cb6c
fix!: Only use webserver_port in developer mode ( #26268 )
2024-05-01 12:11:01 +05:30
Mate Valko
c662379a56
Merge branch 'develop' into data_import_delimiter
2024-05-01 01:01:13 +02:00
Maharshi Patel
72b1db0ae5
revert: fix: pointless conditions about systemd/supervisor ( #26267 )
...
commit added port numbers in urls which broke links on fc.
2024-04-30 20:31:48 +00:00
Mate Laszlo Valko
45eabd32cd
feat(Data Import): custom delimiters
2024-04-30 13:40:38 +02:00
Maharshi Patel
6a6ded156f
chore: warn if wkhtmltopdf is invalid ( #26174 )
...
* chore: warn if wkhtmltopdf is invalid
wkhtmltopdf ( with patched qt ) is required to generate pdfs properly.
when user clicks on PDF, pdf will be generated and downloaded.
however, on print preview page warning will be shown.
* chore: refactor based on review comments
* chore: return False incase of exception
* chore: refactor and better naming
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-04-30 10:36:56 +00:00
Ankush Menat
7b0074e059
refactor!: override_doctype -> Must extend base class ( #26152 )
...
* fix: pointless conditions about systemd/supervisor
What does this have to do with hostname?
* fix!: Overriden doctypes must inherit same base class
There is almost never a real need to completely override a class. After
this change we'll only allow extending and not overriding completely.
2024-04-29 10:21:53 +00:00
Akhil Narang
ad55f5909c
fix(backup): delete failed backup even if something fails during the backup process
...
Not just rollback _after_ a step
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-24 16:23:38 +05:30
Raffael Meyer
2ec9ef5bf3
fix: handle case where mimetype is None ( #26131 )
2024-04-23 14:24:49 +00:00
Akhil Narang
edad15ef9c
chore(sentry): exclude PermissionError as well
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-22 18:21:43 +05:30
Ankush Menat
d40b2a2517
fix(UX): help links and relative URLs
...
also closes https://github.com/frappe/frappe/issues/23020
2024-04-22 12:10:28 +05:30
Rutwik Hiwalkar
7b39a9bbd3
feat: add vim and emacs mode for ace-editor ( #25936 )
2024-04-16 11:35:58 +05:30
Raffael Meyer
37cef2ec86
feat!: simplify admin password prompt for new site ( #25937 )
2024-04-13 13:10:37 +05:30
Ankush Menat
822679246c
fix: use workspace title instead of name
...
this is how workspaces work 🤷
2024-04-11 19:42:48 +05:30
Ankush Menat
b47d9d57fb
fix: handle empty style tag ( #25910 )
2024-04-11 10:06:36 +00:00
Ankush Menat
0692496fd3
fix: log unhandled exceptions in monitor log ( #25897 )
2024-04-10 08:04:32 +00:00
Akhil Narang
ea1c8910e6
feat: delete failed backups
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-10 12:57:16 +05:30
Akhil Narang
5da663d5c2
chore: cleanup get_recent_backup()
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-10 12:57:16 +05:30
Akhil Narang
38af00f0db
fix(sentry): correctly skip frappe.ValidationError and its children
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-08 16:03:13 +05:30
Akhil Narang
bf931598a2
Revert "Merge pull request #25755 from akhilnarang/optional-skip-msgprint"
...
This reverts commit f8121b99df , reversing
changes made to 14e2d95947 .
2024-04-01 21:42:12 +05:30
Akhil Narang
ca83ad580c
feat: allow skipping msgprint
...
If we're handling the exception on our own, we don't need to show the user anything
Example: https://github.com/frappe/frappe/blob/version-15/frappe/desk/doctype/event/event.py#L398
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-01 14:21:47 +05:30
Ankush Menat
ea5e1b61ad
fix: cint -> avoid precision loss if already integer ( #25735 )
2024-03-29 22:31:53 +05:30
David
39d4318a27
feat: enable db socket connection
2024-03-29 10:29:50 +01:00