Gursheen Kaur Anand
149467a71b
fix: fetch portal sidebar items ( #21703 )
2023-07-18 09:34:52 +05:30
Ankush Menat
b5409f6f07
chore: remove eslint-disable*
2023-07-14 15:41:20 +05:30
Ankush Menat
58cf770760
fix: All ESLint errors
2023-07-14 15:25:48 +05:30
Ankush Menat
be8d2b9de0
perf: lazy websocket connection on website
...
Establishing 1 connection for every website visit is too much.
Only after calling frappe.realtime.on(...) for ANY event, we will
establish a websocket connection.
This is used for handful of things:
- Discussion component
- File upload
Socketio was initially added here: https://github.com/frappe/frappe/pull/6866 this use case no longer exists.
Rarely anywhere website uses realtime.
2023-07-01 12:43:53 +05:30
Ankush Menat
e4ec6e65ee
fix: socketio namespace on website
2023-07-01 12:43:53 +05:30
Corentin Flr
4ccfd1e8fa
Merge branch 'frappe:develop' into fix-test_never_render
2023-06-30 11:52:33 +02:00
Corentin Flr
69d0060bdf
chore: format code
2023-06-30 11:52:29 +02:00
Ankush Menat
f3c876e43e
chore: ignore pyo files too
2023-06-28 11:43:23 +05:30
Ankush Menat
38f08bb695
Merge branch 'develop' into fix-test_never_render
2023-06-28 11:41:51 +05:30
Hussain Nagaria
b9bd055813
fix(WebForm): auto-increment link field
2023-06-27 17:10:46 +05:30
Ankush Menat
8a83226c60
perf: defer GoogleOAuth import
2023-06-24 15:22:01 +05:30
Corentin Flr
23846434ee
fix(path_resolver): Avoid 200 OK for NotFoundPage renderer
2023-06-16 14:39:03 +02:00
Corentin Flr
bcdc483a13
fix(test): Fix test_never_render to get path as string, exclude PYC files from static downloads
...
This test code never actually tested the behaviour for two reasons:
- first, the page had an error which meant that a 500 Error page was returned (because `path` is not a string)
- second, every page contains the string "400" because it's contained in some of the icons.svg icons!
I also found a minor related bug in static_page.py, allowing people to download PYC files (pycache)
2023-06-15 18:36:30 +02:00
Ankush Menat
3005e66e45
refactor!: Drop previously deprecated code
2023-06-13 16:00:43 +05:30
Ankush Menat
8485ac5d62
build(deps): bump many dependencies
...
test: change code to adapt to new werkzeug client
fix: avoid setting charset
utf8 is default and assumed now by werkzeug, setting this manually is
deprecated.
fix: use string instead of bytes for setting headers
DeprecationWarning: Passing bytes as a header value is deprecated and will not be supported in Werkzeug 3.0.
12:23:34 web.1 | response.headers["X-Page-Name"] = path.encode("ascii", errors="xmlcharrefreplace")
2023-06-10 20:47:27 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache ( #21282 )
2023-06-08 11:47:17 +05:30
Daizy Modi
984963d75e
chore: remove unused get_docname ( #21270 )
2023-06-07 13:56:50 +05:30
Shariq Ansari
2358bd8fc1
fix: changed for section with features and testimonial web temlates
2023-06-05 15:18:06 +05:30
Shariq Ansari
64613fec48
fix: changed section with card url field to small text
2023-06-05 15:11:46 +05:30
Ankush Menat
392a506a76
perf: Cache published web forms
2023-06-04 15:13:39 +05:30
Ankush Menat
c94c0591c3
perf: cache dynamic web pages
2023-06-04 15:13:39 +05:30
Ankush Menat
7c7c11b454
perf: Cache web view routes
...
Each call to evaluate if route is web view makes N queries where N = #
of web view doctypes. This entire computation can be definitely cached
for short duration.
- Added cache bursting in WebsiteGenerator doctype updates.
- Added 60 minutes TTL in case cache invalidation wasn't done reliably.
2023-06-04 15:13:39 +05:30
Shariq Ansari
042595ca92
fix: handle multiple webform for same doctype
2023-06-03 16:52:51 +05:30
Ankush Menat
83e3a20901
feat: allow clearing web page views
2023-05-31 17:50:10 +05:30
Nabin Hait
af7502bba7
refactor: Workspace cleanup ( #21100 )
...
* refactor: Workspace cleanup
* fix: Resolved conflict
2023-05-26 14:42:31 +05:30
Suraj Shetty
eb560fd8b4
fix: Pass URL for login cmd
...
Fixes this problematic commit
f0eef73cf7
2023-05-15 10:35:03 +05:30
Suraj Shetty
f0eef73cf7
fix: Request on "/login" instead of "/"
...
Just a semantic fix, helps in identifying the request in network tab and easier add proxy while working with custom app
2023-05-14 22:20:36 +05:30
Ankush Menat
eb8da5fd59
fix!: Correct resolution order for template page ( #20927 )
...
Current resolution is confusing mess:
1. Evaluation is done in order of installed app, first install wins
2. Except frappe, frappe is treated as lowest priority.
Following same principle of "last write wins" everywhere similar to
previous PRs:
- https://github.com/frappe/frappe/pull/17869
- https://github.com/frappe/frappe/pull/20648
- https://github.com/frappe/frappe/pull/19653
Closes https://github.com/frappe/frappe/issues/20377
2023-05-07 13:19:23 +05:30
Shariq Ansari
87cf164cac
feat: get anonymous response from webform
2023-04-20 17:31:28 +05:30
Ernesto Ruiz
a27fb46212
chore: translate Not Saved message message in web_form
2023-04-19 07:52:07 -06:00
Ritwik Puri
a1396349fe
chore: translate successful redirection message in web_form
2023-04-12 00:00:53 +05:30
phot0n
0e4909b28b
refactor: remove frappe.send_message js util
2023-04-04 12:32:03 +05:30
Suraj Shetty
ed7d6931ca
fix: Update code to update links with campaign and medium
2023-03-20 23:42:50 +05:30
Suraj Shetty
c9e12edb42
feat: Add campaign and medium to web page view
2023-03-20 23:41:18 +05:30
Ritwik Puri
640a543dae
chore: translate new button in web form
...
Co-authored-by: Steffen <steffen@brennscheidt.net>
2023-03-08 00:17:28 +05:30
Ritwik Puri
8368b73270
Merge pull request #20253 from barredterra/rename-timezone-utils
...
refactor: rename timezone utils
2023-03-06 19:43:11 +05:30
gavin
cd524135c0
fix: TemplatePage.can_render ( #20257 )
...
Don't render python executable/loadable files from TemplatePage
renderer. This restricts access to reading/downloading possibly
private Python source code from Frappe applications
2023-03-06 12:40:15 +05:30
barredterra
b2e36634d6
refactor: rename get_time_zone to get_system_timezone
2023-03-04 19:30:03 +01:00
Suraj Shetty
7abdad3282
Merge branch 'develop' of https://github.com/frappe/frappe into newsletter-analytics
2023-02-28 14:31:03 +05:30
Suraj Shetty
c4e31f435b
feat: Add grouping based on source
...
And a formatter for source column
2023-02-28 14:17:19 +05:30
Suraj Shetty
6c8f88b8cd
refactor: Remove UTM references just set source in web page view to simplify things
2023-02-28 14:17:16 +05:30
Suraj Shetty
ad2d651e45
feat: Add Group By option to Website Analytics report
...
- Also fixed order_by of main query
2023-02-28 14:15:41 +05:30
Suraj Shetty
dc58680176
fix: Unique visit logic
2023-02-28 14:15:41 +05:30
Suraj Shetty
afd55a97fb
fix: Web page view creation
...
- Set path from backend via "Referer" to avoid bad data
- Add visitor_id to improve unique visit detection
2023-02-28 14:15:41 +05:30
Suraj Shetty
7d5c98c206
feat: Add UTM tracking parameters to internal links in newsletters
...
- Also, extend web page view to store UTM tracking data.
2023-02-23 16:19:07 +05:30
mergify[bot]
3a130abfc5
fix: extension extracted if at least one dot, because if not dot ( #19946 ) ( #20142 )
...
(cherry picked from commit 53c41e0ce6bf9985786a570c43fd32c79332c44c)
Co-authored-by: Jaime <developmentforpeople@gmail.com>
2023-02-23 15:03:11 +05:30
Ankush Menat
8446875257
refactor!: Remove "Set user permission" permtype ( #20090 )
...
This has never worked and setting user permission requires system
manager role always (because of permissions on list view)
2023-02-20 16:07:49 +05:30
Hussain Nagaria
24d7637538
fix: hide published checkbox
2023-02-17 11:31:53 +05:30
Hussain Nagaria
110204e2df
feat: publish button in blog post form
2023-02-16 20:05:36 +05:30
Ankush Menat
b3b846472e
test: clear defaults after test
2023-01-31 12:35:43 +05:30