Commit graph

2430 commits

Author SHA1 Message Date
Ankush Menat
45280d4801
fix: website theme caching (#19848) 2023-01-31 11:25:14 +05:30
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
Ankush Menat
6bae5a2974 fix: Dont create __init__.py in prod
closes https://github.com/frappe/frappe/issues/16618
2023-01-06 13:31:32 +05:30
Shariq Ansari
abc5b51e57 fix: after login if redirect is used getting blank screen 2023-01-05 20:39:35 +05:30
Ritwik Puri
b78452dc00
Merge pull request #19472 from ankush/set_value_bad
refactor: deprecate usage of set_value with None as docname
2023-01-04 11:44:57 +05:30
Ankush Menat
e00023deb1 refactor: replace bad usage of db.set_value 2023-01-04 11:13:53 +05:30
Shariq Ansari
324c3e24c4 fix: replace all spaces with _ to generate fieldname 2023-01-02 10:20:16 +05:30
aliX40
1ddbb9d7a4
chore: make min read string translatable in blog post (#19410)
* Make min read translatable

min read doesn't get translated, which can be a little bit annoying when writing blog posts in other languages other than english


Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2022-12-30 17:50:24 +05:30
Ankush Menat
f52869482d chore: dont log 404 as errors 2022-12-20 11:20:50 +05:30
Devin Slauenwhite
64ec4276fc
fix: restore missing helpful and not_helpful fields to help article doctype. (#19309)
* fix: restore fields 'helpful' and 'not_helpfull' when removed via 02ddaa5ee7\#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46

* test: help article is helpful or not helpful

* chore: linter
2022-12-16 12:34:52 +05:30
Ankush Menat
8140908f99 style: format
[skip ci]
2022-12-15 21:57:52 +05:30
Mohammad Hussain Nagaria
8f8f506b10
feat: fields for attaching (html) meta tags in web form (#19306) 2022-12-15 21:07:10 +05:30
Shariq Ansari
55d3bea05b
Merge branch 'develop' into web-form-print-format-fix 2022-12-13 18:06:03 +05:30
Shariq Ansari
2767580732 fix: in web form if print format is empty getting error 2022-12-13 17:41:10 +05:30
Ankush Menat
2ba85af8a3 chore!: remove activity feed logs 2022-12-12 14:28:30 +05:30
Mohammad Hussain Nagaria
02601dafd4
perf: remove redundant render template (#19123) 2022-12-07 15:11:46 +05:30
Sagar Vora
9a3819e608
fix: disable signups by default (#19114)
* fix: disable signups by default

* fix: set `disable_signup` to `0` for tests
2022-12-05 16:40:51 +05:30
phot0n
d7f4540132 chore: consider docname via data 2022-12-05 12:19:29 +05:30
phot0n
8e0c4ce702 fix: use webform doctype rather than allowing user to pass any doctype 2022-12-05 11:56:12 +05:30
phot0n
856d7a9f65 fix: use permtype from passed arguments in has_web_form_permission when applying document permissions 2022-12-02 20:52:00 +05:30
Shariq Ansari
941949e0a1
Merge branch 'develop' into phone-field-in-web-form 2022-11-21 18:26:57 +05:30
mergify[bot]
d1d30e6451
Merge pull request #18877 from marination/get_role_permissions-js-consistency
fix: Correctness in `get_role_permissions` and `has_perm` JS APIs
2022-11-21 12:56:30 +00:00
Shariq Ansari
58a35d12bf
Merge branch 'develop' into phone-field-in-web-form 2022-11-21 18:26:11 +05:30
Shariq Ansari
cf4d55855d fix: added phone field in webform 2022-11-21 18:16:44 +05:30
Shariq Ansari
962d96c1a6 fix: only get fields which is not already in webform fields table 2022-11-21 17:33:39 +05:30
marination
0937c962a7 chore: web_form.py format via pre-commit 2022-11-21 16:18:58 +05:30
Shariq Ansari
c56c71b1e0
Merge pull request #18945 from theopen-institute/oi-webform-error 2022-11-21 15:25:58 +05:30
PeterG
4ec7d2dbba
feat(minor): redirect after login from NotPermittedPage (#18946)
* redirect after login from NotPermittedPage
2022-11-21 14:56:18 +05:30
PeterG
cfa9ed4fa0
Update frappe/website/doctype/web_form/web_form.py
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-21 15:06:17 +05:45
PeterG
264c9dfad0
Update frappe/website/doctype/web_form/web_form.py
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-21 15:06:06 +05:45
PeterG
4ffd454c04
[fix] clearer webform error 2022-11-20 16:07:07 +05:45
PeterG
7bde45ae60 [fix] clearer webform error 2022-11-20 10:13:34 +00:00
Gavin D'souza
40df601a73 fix: Auto-add all users to website room
Keep website room open for all - currently only used for discussions
2022-11-17 17:04:07 +05:30
gavin
dbed3e4788
Merge branch 'develop' into socket_io-refactor 2022-11-17 15:21:20 +05:30
Jannat Patel
6428930857
fix: security issue in discussions component (#18903)
[skip ci]
2022-11-17 11:39:43 +05:30
Gavin D'souza
96fee8c293 feat: {site}:website room open to all users
- Subscribe to room and pass messages without auth
- Pass `room='website'` to publish_realtime to use
- Pass discussions' comms through particular site's website room
2022-11-16 21:53:49 +05:30
Ankush Menat
f34f7030a3 refactor: remove txt param from generate_hash use 2022-11-10 11:56:48 +05:30
Ankush Menat
8cca50bf26
refactor: remove naming case feature (#18672)
This has never worked since 2016... which can mean two things:
- No one really uses this.
- If I fix this now suddenly people will find different behaviour in
  naming because `name_case` is selected in some doctypes (but never
  tested)
2022-10-31 11:23:49 +05:30
Faris Ansari
5c2b917f52
refactor(minor): Tab layout in Website Theme form (#18570) 2022-10-26 00:15:47 +05:30
Ankush Menat
3491d0dcb0
refactor: dynamically load web form module (#18486) 2022-10-23 11:20:17 +05:30
Rushabh Mehta
83c310b779
Merge pull request #18452 from rmehta/blog-category-fix
fix(ux): add better home for blog category, cleanup forms
2022-10-18 21:50:22 +05:30
Rushabh Mehta
2a50d6c593 fix(ux): add better home for blog category, cleanup forms 2022-10-18 17:28:47 +05:30
Ankush Menat
c2f43c4b26
fix: validate website settings (#18446) 2022-10-18 12:41:36 +05:30
Ankush Menat
cc72dc47ab
fix: Show error page even when routing fails (#18437) 2022-10-17 19:52:37 +05:30
Rushabh Mehta
ac263d02ae fix(minor): skip broken redirect 2022-10-17 18:54:41 +05:30
Shariq Ansari
0736f8a01b fix: load all boot data on website 2022-10-07 23:28:36 +05:30
Shariq Ansari
799cc62515 fix: get assets_json from boot 2022-10-05 16:34:02 +05:30
Shariq Ansari
2a8b837127 fix: removed unused script 2022-10-04 11:07:55 +05:30
Shariq Ansari
2b549619a8 fix: handle loading of bundle css & js in website 2022-10-03 13:54:48 +05:30
Shariq Ansari
ede9188aa6 fix: removed Vue.prototype implementation 2022-09-29 19:20:32 +05:30