Akhil Narang
af7636e362
Merge pull request #27760 from akhilnarang/fix-validate-doc-rename-permission-check
...
fix(rename_doc): check permissions for the specific document
2024-09-13 11:37:12 +05:30
Akhil Narang
a87de09e79
fix(rename_doc): check permissions for the specific document
...
A user can have access to write to a document without having access to the whole doctype
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-13 11:16:53 +05:30
David
7d5b63a267
fix: improve serializer
2024-09-12 21:06:10 +02:00
Raffael Meyer
3d103eab94
fix: form should pass df to formatter ( #27756 )
2024-09-12 20:57:46 +02:00
David Arnold
59421b1452
Merge pull request #27755 from Ponnusamy1-V/time_field_fix
...
fix: Time field not updating the manual edit to the time picker (editing the values directly in the input field)
2024-09-12 17:09:57 +02:00
Ponnusamy1-V
e2b1bc4dcb
style: pre-commit
2024-09-12 20:16:24 +05:30
Ponnusamy1-V
be7e81db59
fix: time picker doesn't show correct value
2024-09-12 20:05:46 +05:30
David Arnold
672bd73b02
Merge pull request #27738 from frappe/chore/make-config-namespace-available
...
refactor!: make room in the frappe.config namespace
2024-09-12 12:32:25 +02:00
David
091df9fe2b
refactor!: make room in the frappe.config namespace
...
BRAKING: fappe.config namespace moved to
frappe.utils.modules namespace
2024-09-12 12:18:58 +02:00
Lyes7
9b89eba337
fix: workflow typos
2024-09-12 10:18:49 +01:00
Akhil Narang
6a38638c4c
Merge pull request #27747 from akhilnarang/printview-doc-title-str
...
fix(printview): ensure document title is a string
2024-09-12 13:47:51 +05:30
Akhil Narang
182dc7213d
fix(printview): ensure document title is a string
...
Nothing is stopping people from setting non-string types as their title
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-12 13:34:59 +05:30
David Arnold
cca88f3a47
Merge pull request #27742 from frappe/chore/no-stale-on-draft
...
chore: exempt draft prs from stale bot
2024-09-12 08:00:10 +02:00
David Arnold
e606c23823
Merge pull request #27697 from blaggacao/feat/notification-with-minutes-offset
...
feat/notification with minutes offset
2024-09-12 07:12:01 +02:00
Akhil Narang
2e28dc8735
chore: reword description
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-12 10:28:54 +05:30
David Arnold
2d002cb5a4
Merge pull request #27743 from blaggacao/chore/improve-ci-log-responsiveness
...
ci: split up install
2024-09-12 02:20:53 +02:00
David
924ddd07bd
fix: semgrep complaints
2024-09-12 02:13:46 +02:00
David
9f6b97b214
ci: split up install
...
when init fails, this separates long log sections and keeps github responsive
2024-09-12 02:06:43 +02:00
David Arnold
1694994bd1
Merge pull request #27744 from frappe/chore/improve-ci-log-responsiveness-1
...
ci: split up install prepare
2024-09-12 01:45:23 +02:00
David
2e6004cc12
ci: split up install prepare
2024-09-12 01:31:27 +02:00
David
2a6161eea6
test: comment out due to uncontrollable side effects
2024-09-12 01:11:18 +02:00
David Arnold
7abd0b15b6
Merge pull request #26891 from blaggacao/feat/utm-analytics
...
feat(analytics): add basic utm nomenclature for analytics
2024-09-12 00:37:22 +02:00
David
326b6cdc8f
fix: assert equal on docs; compare dicts
2024-09-12 00:23:25 +02:00
David (aider)
7e66c2be50
feat: add unit tests for URL tracker functions
2024-09-12 00:08:11 +02:00
David
d50e579317
feat(utm): make data helper more useful
2024-09-12 00:08:11 +02:00
David
c29c23deec
feat(analytics): add to website workspace
2024-09-12 00:08:10 +02:00
David
43c5cbd8a6
feat(analytics): add basic utm nomenclature for analytics
2024-09-12 00:08:05 +02:00
David
d03aeb0a68
chore: exempt draft prs from stale bot
2024-09-11 23:58:47 +02:00
David Arnold
ddeb612dc3
Merge pull request #27740 from frappe/chore/simplify-config-calling
...
chore: simplify config calling
2024-09-11 23:37:18 +02:00
David Arnold
1214763b25
Merge pull request #26737 from blaggacao/feat/cache-control
...
feat: add cache control
2024-09-11 23:32:57 +02:00
David
e0fe0b8c88
chore: simplify config calling
2024-09-11 23:24:26 +02:00
David Arnold
ed965be2e6
Merge pull request #27735 from blaggacao/chore/make-stalebot-more-bearable
...
chore: add no-stale label
2024-09-11 17:16:59 +02:00
David
b5cac45616
chore: add no-stale label
2024-09-11 17:02:50 +02:00
Akhil Narang
4b99e911db
Merge pull request #27730 from akhilnarang/fix-country-selection-setup-wizard
...
fix(setup_wizard): don't crash if a country doesn't have a timezone specified
2024-09-11 18:02:08 +05:30
Akhil Narang
2e3f8ce5af
fix(setup_wizard): don't crash if a country doesn't have a timezone specified
...
Currently, this event is getting triggered by the country and its translated value
The translated value isn't present in the country info list, and so doesn't have any data
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-09-11 17:46:35 +05:30
Rushabh Mehta
4df43493fd
Merge pull request #27716 from rmehta/print-style-fixes
...
fix(style): print format
2024-09-11 12:11:33 +05:30
Rushabh Mehta
5a23bc52b6
fix(minor): default app title and logo
2024-09-11 11:38:12 +05:30
Akhil Narang
895df32fa9
Merge pull request #27698 from blaggacao/chore/reuse-safe-exec-autocomplete
...
feat: subject processing to global server script config
2024-09-11 11:37:30 +05:30
David
dd8cd9860c
test: add more notification offset tests for edge cases
2024-09-10 20:11:59 +02:00
David Arnold
3c18983f7b
Merge pull request #27722 from blaggacao/fix/notification-condition-context
...
fix: notification condition has no custom context (perf)
2024-09-10 20:08:53 +02:00
s-aga-r
d09ee52d13
fix: prevent sending emails to System Manager when email notifications are disabled
2024-09-10 22:05:41 +05:30
David (aider)
a8c53c8940
feat: Implement minutes_offset feature and add test cases
2024-09-10 16:45:53 +02:00
David
ac379f297c
fix: Add support for minutes-based notifications
2024-09-10 16:45:53 +02:00
David
5a5be420b9
feat: subject processing to global server script config
2024-09-10 16:39:08 +02:00
David
6aa27c7d7a
fix: notification condition has no custom context (perf)
2024-09-10 16:37:19 +02:00
Akhil Narang
6c304b93c0
Merge pull request #27124 from git-avc/fix-report-excel-translation
...
fix: let's translate data on standard report excel/csv exporting
2024-09-10 18:15:40 +05:30
Rushabh Mehta
4ecb14288f
fix(style): print format
2024-09-10 15:21:19 +05:30
Rushabh Mehta
0c8b9be47b
fix(style): print format
2024-09-10 15:15:15 +05:30
foolishdino
3fe34b2f18
fix(quick_list_widget):workflow-state-not-showing ( #27596 )
...
* fix(quick_list_widget):workflow-state-not-showing
when a document has workflow state, it should show workflow_status. Instead it doesn't.
existing code put a validation if status exist, but a document can have a workflow_state without a "status" field.
the correct approach is to separate the logic.
* fix(quick_list_widget):follow-suggestioin-to-remove-unnecessary-validation
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
---------
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2024-09-10 14:57:34 +05:30
Akhil Narang
425d409422
Merge pull request #27707 from frappe/dependabot/github_actions/actions/download-artifact-4.1.8
...
chore(deps): bump actions/download-artifact from 4.1.7 to 4.1.8
2024-09-10 11:16:51 +05:30
