Commit graph

43625 commits

Author SHA1 Message Date
Maharshi Patel
fd1fe44850 fix: cypress and add check for __islocal
changed check for __islocal as well in savedocs

As new route ends with random hash instead of numbers,
updated cypress test to just check start of data-route instead of entire path
2023-10-17 17:19:53 +05:30
Maharshi Patel
0c9efd3b5a fix: don't overwrite name for library files
name is used in many places and should not be overwritten,
so i have sent name in upload_via_file_browser as library_file_name
which can be used to get existing file.
2023-10-16 12:53:38 +05:30
Maharshi Patel
0439e01ee7 fix: attach file from library
Previously, the attach from library only shared file_url, problem is we
need more information such as is_private.

fix: send name instead of file_url on file uploader and use that in
upload_file handler to get more information about the file then attach
that info to newly created file.
2023-10-16 12:26:39 +05:30
Maharshi Patel
125a025235 fix(minor): remove count from url
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-10-13 18:22:46 +05:30
Maharshi Patel
1de07a8357 fix(minor): remove __temporary_name after relink
removed __temporary_name as after relink file there is no need to keep it
2023-10-13 10:35:49 +05:30
Maharshi Patel
d9a8b7ee78 chore: rename __temporary_name & check temp_doc_name
* renamed file_relink_temp_docname to __temporary_name
* added check for temp_doc_name in relink_files in case someone
    calls the function it directly
2023-10-13 10:20:03 +05:30
Maharshi Patel
e888e49cc2
fix: don't update unnecessary fields
removed attached_to_doctype and attached_to_field from set_value as those are not required.

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-10-12 08:42:42 +05:30
Maharshi Patel
d80e0a10df fix(minor): don't update docname
instead of updating docname use docname_title.

https://github.com/frappe/frappe/pull/22693#discussion_r1354297835
2023-10-11 13:06:01 +05:30
Maharshi Patel
53cdd6d1bf fix: relink attachments before saving doc
Certain people add attachment, before filling mandatory fields
which will raise Missing Fields error.

Or any other kind of errors raised by different validators due to which
file is uploaded but doc is not saved.

This will lead to orphaned/mislinked files. ex. new-purchase-receipt-1

This fix changes name of new docs to new-<doctype>-<no>-<10digithash>
after saving the document we can use this new name to find any mislinked
files created in past hour and relink them to the new doc on save.
2023-10-10 23:49:16 +05:30
Shariq Ansari
009d9e010b
Merge pull request #22679 from shariquerik/conditional-webform-list-view 2023-10-10 15:47:27 +05:30
Akhil Narang
b601131d8f
fix: don't allow setting an invalid rating (#22633)
* feat: don't allow setting an invalid rating

Convert anything <0 to 0, and anything >1 to 1

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* chore: add in tests for rating

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 15:38:58 +05:30
dependabot[bot]
d24d4f52c3
build(deps): bump postcss from 8.4.24 to 8.4.31 (#22615)
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.24 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.4.24...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-10 14:17:12 +05:30
Suraj Shetty
3d8461a7af
Merge pull request #22674 from surajshetty3416/fix-reportview-filter 2023-10-10 14:12:44 +05:30
Suraj Shetty
d6fc9be930
Merge pull request #22619 from GursheenK/audit-trail-write-permission 2023-10-10 13:35:30 +05:30
Suraj Shetty
c8f3389ba7
Merge pull request #22439 from dhiashalabi/fix-child-table-select-search-link-permission 2023-10-10 13:32:45 +05:30
Suraj Shetty
3a5f8ecaa5
Merge pull request #22555 from cogk/fix-notpermittedpage-redirect-if-startwith-app 2023-10-10 13:29:04 +05:30
Shariq Ansari
46f3b5b12d fix: changed table style to match grid style
updated description and some minor fixes
2023-10-10 12:53:21 +05:30
Akhil Narang
091ebdd8dc
refactor(treewide): use mariadb commands directly instead of mysql (#22620)
This has been done because the mysql command issues a deprecation warning now

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 12:49:16 +05:30
Maharshi Patel
7752136081
fix: strip html and show text (#22656)
* fix: strip html and show text

Quill editor adds html which is useless for user so strip html using  html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description).

* fix: remove placeholder text

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-10 12:29:36 +05:30
Suraj Shetty
fbaefddaa1 fix: Use same filter in report view and list view 2023-10-10 11:47:49 +05:30
Shariq Ansari
fb9c111ed2 fix: conditional webform with list view enabled 2023-10-10 11:47:03 +05:30
Sagar Vora
58fa1c93c5
Merge pull request #22667 from resilient-tech/black-compatible-export 2023-10-09 19:31:36 +05:30
Sagar Vora
eb8bc998e2
Merge pull request #22666 from resilient-tech/allow-larger-urls 2023-10-09 19:23:28 +05:30
Sagar Vora
b6b7fafe72 chore: export black-compatible types 2023-10-09 19:20:20 +05:30
Sagar Vora
6043909fe6 fix: allow larger URLs in Integration Request 2023-10-09 19:13:10 +05:30
Ankush Menat
9073874b50
Merge pull request #22636 from akhilnarang/awesomeplete-tab-autocomplete
feat: enable `tabSelect` for awesomplete
2023-10-09 18:42:25 +05:30
Ankush Menat
b24d91c52f
Merge pull request #22657 from ruthra-kumar/keyerror_on_reports_with_subtotal
fix: keyerror on reports with subtotal
2023-10-09 17:18:30 +05:30
rohitwaghchaure
34fe6661c0
fix: e-commerece test cases (#22663) 2023-10-09 11:49:41 +05:30
ruthra kumar
f6d9069fb1 fix: keyerror on reports with subtotal 2023-10-08 17:22:29 +05:30
Suraj Shetty
0c9db5060b
Merge pull request #22602 from resilient-tech/fix-long-title 2023-10-08 06:37:33 +05:30
Suraj Shetty
ecca2fcc7a
Merge pull request #22562 from FHenry/dev_translation_context_for_edit_grid_row_button 2023-10-08 06:27:35 +05:30
Florian HENRY
d05e0b8d4c Merge branch 'develop' of https://github.com/frappe/frappe into dev_translation_context_for_edit_grid_row_button 2023-10-07 16:30:52 +02:00
mergify[bot]
eee418a4c6
Merge pull request #22330 from blaggacao/feat/improve-openid-connect-devx
feat: improve openid connect devx
2023-10-07 13:43:36 +00:00
barredterra
ed2290d1d6 Merge branch 'develop' into feat/improve-openid-connect-devx 2023-10-07 15:22:59 +02:00
DaizyModi
1cd51644a2 fix: set css for max width 412px 2023-10-06 15:10:58 +05:30
Akhil Narang
5553a84e00
feat: enable tabSelect for awesomplete
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-05 16:34:58 +05:30
Maharshi Patel
d83b6758dd
Merge pull request #22626 from maharshivpatel/fix-workspace-style
fix: workspace style
2023-10-05 10:28:24 +05:30
Maharshi Patel
60b3f34691
Merge pull request #22628 from maharshivpatel/fix-kanban-memory-issue
fix: kanban remove unnecessary get_docfield
2023-10-05 00:45:14 +05:30
Maharshi Patel
6c5856f6fc
Merge pull request #22627 from maharshivpatel/hide-sidebar-on-new-doc
fix(minor): hide side section on new doc form.
2023-10-05 00:43:29 +05:30
Maharshi Patel
84adb3f68e
Merge pull request #22617 from maharshivpatel/fix-sidebar-and-multiselect
fix: sidebar, multi-select, body tag letter spacing
2023-10-05 00:24:38 +05:30
Maharshi Patel
68221f4d9e fix: kanban remove unnecessary get_docfield
*  Label will be same for all documents so there is no need to call get_docfield.
*  As it internally calls docfield_copy and makes "deep copy" for each document.
   which causes massive memory usage as number of document increases.
*  Instead get meta from docfield_map and use it.
2023-10-04 23:36:53 +05:30
Maharshi Patel
658f58d1e0 fix(minor): hide side section on new doc.
* on new doc, hide sidebar is hidden. however, layout-side-section is still visible.
* added hide-sidebar class to layout-side-section when doc is new.
2023-10-04 23:30:48 +05:30
Maharshi Patel
a46739688e fix: workspace style
* removed divider, changed arrow location for shortcut-widget-box

* removed indicator from quick_list_widget   also changed link items style to shortcut links with arrow

* added border for workspace and removed border for onboarding and quick_list_widget
2023-10-04 23:26:23 +05:30
Maharshi Patel
aaf40dc583 fix: sidebar redesign
* replaced all full width pill buttons with the labels and plus icons
* added a click listener to avatars for opening share dialog.
* made attachments label a link where user can click and open all of the files
  as there isn't enough space for explore buttons in new design
2023-10-04 23:05:24 +05:30
Ankush Menat
95882f5b69
Merge pull request #22624 from bosue/switch_add_multiple_button
fix(UX) Switch 'Add Multiple' and 'Add Row' button for consistency
2023-10-04 22:13:55 +05:30
Bernd Oliver Sünderhauf
3531686840 fix(UX) Switch 'Add Multiple' and 'Add Row' button for consistency 2023-10-04 17:37:20 +02:00
Gursheen Anand
c5321f12f2 fix: allow write perm by default 2023-10-04 12:51:41 +05:30
DaizyModi
ef7766af8a fix: set back get_textstyle for mobile devices 2023-10-04 12:29:45 +05:30
DaizyModi
2b3ff029ed fix: remove redundant rule 2023-10-04 12:13:51 +05:30
DaizyModi
a9de6ae05c fix: replace px with vw 2023-10-04 11:48:16 +05:30