Commit graph

39764 commits

Author SHA1 Message Date
Shariq Ansari
fdc1bbb23d fix: create directory recursively 2022-10-07 20:49:54 +05:30
Ankush Menat
7c0ad204b2
Merge pull request #18318 from netchampfaris/string-tuple-check
fix: convert string check to tuple check
2022-10-07 15:56:41 +05:30
Faris Ansari
c00d9f5267 fix: convert string check to tuple check
breaks as `'in <string>' requires string as left operand` when
df.fieldtype is None
2022-10-07 15:31:55 +05:30
Ankush Menat
64a0e19329 Revert "fix!: Dont update modified by default in db.set_value (#18301)"
This reverts commit 6aaefd6633.
2022-10-06 22:02:31 +05:30
Ankush Menat
bfa6a5fbdf fix: better cache validation
- Only delete a single doc if we know which doc changed
- Drop all docs other wise (kinda bad, but this isn't used frequently,
  will fix when visiting entire caching system again)
2022-10-06 19:46:58 +05:30
Ankush Menat
cee2b50461 perf: single query db.set_value 2022-10-06 19:46:58 +05:30
Shariq Ansari
ad94f82d13
Merge pull request #18247 from shariquerik/migrate-to-vue3 2022-10-06 19:22:45 +05:30
Shariq Ansari
a126e72b97
Merge branch 'develop' into migrate-to-vue3 2022-10-06 18:59:55 +05:30
Shariq Ansari
14f0b8a512
Merge pull request #18306 from shariquerik/ui-test-fix 2022-10-06 18:58:31 +05:30
Shariq Ansari
458757708f test: minor change 2022-10-06 18:05:24 +05:30
Shariq Ansari
a4ca0cea2a
Merge branch 'develop' into migrate-to-vue3 2022-10-06 17:29:02 +05:30
Shariq Ansari
8989bc49ae
Merge branch 'develop' into ui-test-fix 2022-10-06 17:12:29 +05:30
Shariq Ansari
930f8c34ed test: minor change 2022-10-06 16:52:39 +05:30
Ankush Menat
1d186db6a6
fix: disable autocommit before each patch (#18307) 2022-10-06 16:08:39 +05:30
Shariq Ansari
2e80f044c2
Merge branch 'develop' into ui-test-fix 2022-10-06 16:08:24 +05:30
Raffael Meyer
112c492f3e
feat: consistent, translatable timeline messages (#17526)
* feat: consistent, translatable timeline messages

* fix: save only filename for attachment comments

The rest of the comment will be added and translated ad-hoc by form_timeline.js

* patch: clean up Comments of type "Attachment"

* feat: further message types

* style: format with prettier

* test: cypress timeline

Timeline now correctly displays "You ..." instead of "{User} ..."

* feat: german transations for timeline comments

* fix: enable auto_commit_on_many_writes

* fix: don't update modified timestamp in patch
2022-10-06 16:05:34 +05:30
Ankush Menat
6aaefd6633
fix!: Dont update modified by default in db.set_value (#18301) 2022-10-06 16:01:20 +05:30
Shariq Ansari
36bc9d3142 test: flaky Cypress test 2022-10-06 15:57:49 +05:30
Ankush Menat
6ed3ce5875
Merge pull request #18262 from ankush/indexing_validation
fix: correct index syncing
2022-10-06 11:38:47 +05:30
Ankush Menat
da561c237d fix: index column should be first 2022-10-06 11:11:03 +05:30
Ankush Menat
cbe4b59100 fix: correct index re-syncing
The implementation of syncing unique and non-unique index depended on
index names which used to be different before because of that there's
tendency to incorrectly identify index.

This PR adds a separate util for checking if a column has index without
relying on naming convention. It just goes and checks if there's any
index with that column in it, hence far more reliable.
2022-10-06 11:11:03 +05:30
Ankush Menat
6de41a78e9 refactor: guard clause 2022-10-06 11:11:03 +05:30
Shariq Ansari
c7be3e125b
Merge branch 'develop' into migrate-to-vue3 2022-10-05 17:00:04 +05:30
Shariq Ansari
0b95de37fd chore: minor fix 2022-10-05 16:37:36 +05:30
Shariq Ansari
799cc62515 fix: get assets_json from boot 2022-10-05 16:34:02 +05:30
Shariq Ansari
45e7e92ffa refactor: Print Format Builder Beta code to vue 3 2022-10-05 15:41:14 +05:30
Ankush Menat
d597acb5e2
fix: let charts handle aggregation (#18293)
Currently we are doing aggregation of remaining slices manually BUT this
breaks basic principle of DRY:

- dashboard chart decides how many groups to consider
- frappe charts has different maxSlices config

This results in mess like frappe computing "Other" and Frappe charts
computing "rest" separately.

Fix: Just pass all data to charts and let it figure out the "Rest".
2022-10-05 12:48:32 +05:30
Ankush Menat
bd21398252
fix: ignore perm level validation if row deleted (#18290) 2022-10-05 11:16:28 +05:30
Ankush Menat
b8ed8d624c fix: ignore child tables when init-ing parent doc 2022-10-04 14:27:25 +05:30
Ritwik Puri
2b782610ca
chore: remove unnecessary translation files (#17557)
translation files with _ in them are not considered by load_lang
2022-10-04 13:03:02 +05:30
Deepesh Garg
c1c4ee8b04
fix(minor): More button in list view (#18283) 2022-10-04 11:10:12 +05:30
Shariq Ansari
bab42ffd80 refactor: File Uploader code to vue 3 2022-10-04 11:09:56 +05:30
Shariq Ansari
2a8b837127 fix: removed unused script 2022-10-04 11:07:55 +05:30
mergify[bot]
939d926b91
feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site (backport #18263) (#18281)
* feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site (#18263)

* feat: added Subscription Banner and Manage Subscription button

* feat[patch]: added a patch for adding `Manage Subscription` button in
navbar_settings

* chore: removed console ;)

* refactor: make the `Manage Subscription` navbar item optional

* keep it hidden by default, only show when the site configs are present

* style: prettier, isort and stuff

* chore: handling null responses, translation and refactored patch

* fix: correct index reset

* perf: reduce network/db calls

If not sys manager then why make a request?

* fix: removed network call and added subscription_expiry to boot process

* chore: added enable_manage_susbcriptions as daily background job and refactored patch

* chore: added hook to hooks.py

* this looks clean enough, also don't have insert for child tables ;)

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68f315d372cc8c6e41f2aabda61eba0d42dcf6e4)

# Conflicts:
#	frappe/patches.txt

* chore: conflicts

* style: format

[skip ci]

Co-authored-by: Rutwik Hiwalkar <50401596+rutwikhdev@users.noreply.github.com>
2022-10-03 16:41:12 +05:30
Abhinav Raut
fd81a290b2
fix: geolocation (#18250)
- set center and zoom for leaflet.

Co-authored-by: Abhinav Raut <abhinav.raut@zerodha.com>
2022-10-03 16:38:28 +05:30
Shariq Ansari
2197e9cacc
Merge branch 'develop' into migrate-to-vue3 2022-10-03 14:07:43 +05:30
Shariq Ansari
2b549619a8 fix: handle loading of bundle css & js in website 2022-10-03 13:54:48 +05:30
Ankush Menat
35ba00a54e
fix: handle isatty correctly (#18277)
sys.stdin can be `None`

[skip ci]
2022-10-03 12:05:55 +05:30
Raffael Meyer
513321810d
fix(Data Import): don't validate empty values (#17923)
* refactor: exclude header from column values earlier

* fix: don't validate empty columns

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-10-03 10:57:42 +05:30
aliX40
77be534e22
chore(translation): use Acceuil instead of Maison in fr translation (#18271)
In French ``Maison`` means house, but here the word ``Acceuil`` is what we actually need
2022-10-02 15:46:45 +05:30
Cleo Menezes Jr
af24bbff1b
fix: Show Report button should appear only if the doc is saved (#18268) 2022-10-01 00:10:55 +05:30
Shariq Ansari
fc1e01555b fix: added missing operators 2022-09-30 17:16:40 +05:30
Shariq Ansari
3162d192b8 fix: Chart filter not working if not operator is used 2022-09-30 17:16:40 +05:30
Ankush Menat
7b36265bad style: whitespace 2022-09-30 11:58:18 +05:30
Ankush Menat
7c423416b4
fix: report generation - frappe monitor (#18259)
- Identify original report name correctly.
- If sending to background, don't log it.
2022-09-29 19:35:38 +05:30
Shariq Ansari
ede9188aa6 fix: removed Vue.prototype implementation 2022-09-29 19:20:32 +05:30
Shariq Ansari
5373780741 fix: set vue global properties
since Vue.prototype is removed using app.config.globalProperties to set window.__ & window.frappe
2022-09-29 19:14:06 +05:30
Shariq Ansari
89af6d82e7 refactor: updated vue syntax 2022-09-29 16:59:45 +05:30
Shariq Ansari
7d238dcf37 chore: removed module_home.js
unused code
2022-09-29 16:58:52 +05:30
Shariq Ansari
7bc9319a69 refactor: updated vuex syntax in Kanabn Board 2022-09-29 16:40:53 +05:30