Commit graph

39435 commits

Author SHA1 Message Date
mergify[bot]
ff0f0db2e8
Merge pull request #17294 from resilient-tech/remove-old-ref
chore: remove old code where User Permissions were set in `tabDefaultValue`
2022-08-23 05:13:07 +00:00
Suraj Shetty
3d84a748b7
Merge pull request #17863 from shariquerik/web-form-misc-fixes 2022-08-23 09:54:23 +05:30
Shariq Ansari
2b57e77f29 feat: added not saved indicator if form is dirty 2022-08-22 19:40:51 +05:30
Shariq Ansari
7d245268ea style: rating field style changes in view mode
color field causing error in view mode (fixed)
2022-08-22 19:04:47 +05:30
Sagar Vora
c5face41b3 fix: clear notifications cache when deleting a Notification 2022-08-22 19:04:18 +05:30
Sagar Vora
2866721a78 test: clear lang_full_dict from local cache 2022-08-22 19:04:18 +05:30
Sagar Vora
63e760e3ad chore: remove old code where User Permissions were set in tabDefaultValue 2022-08-22 19:03:30 +05:30
Shariq Ansari
fb8ba3d881 fix: include Color field in Web Form fieldtypes 2022-08-22 18:21:48 +05:30
Shariq Ansari
02da933c16 fix: setup field's change event instead of input change event 2022-08-22 18:19:38 +05:30
Shariq Ansari
4b4d66d2a3 fix: title should never be empty 2022-08-22 16:47:15 +05:30
Shariq Ansari
309b42f1a3 fix: show webform name and webform doc name on header 2022-08-22 15:57:46 +05:30
Shariq Ansari
d0111f7d14
Merge pull request #17847 from shariquerik/edit-public-workspace-fix 2022-08-22 15:31:49 +05:30
Shariq Ansari
66389932d1 fix: show introduction in edit mode 2022-08-22 13:19:03 +05:30
Shariq Ansari
b1944916c3 fix: show discard dialog only if form is dirty 2022-08-22 13:16:30 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes
perf: ~45% faster Desk first response
2022-08-22 11:45:20 +05:30
Ankush Menat
b30a78aa40
perf: install hiredis for faster response parsing (#17893) 2022-08-22 11:39:18 +05:30
Ankush Menat
794a2b8101
Merge pull request #17894 from ankush/db_no_getall
chore: db.get_all -> get_all
2022-08-22 11:38:04 +05:30
Ankush Menat
1de22b6082 chore: ignore fluff change in blame
[skip ci]
2022-08-22 11:35:53 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
4241f8c8c0 perf: simpler/faster preload header computation
We parse entire response to find preload headers, instead just use
include_style and include_script to include assets directly into preload
headers. This shaves off ~13% overhead in response.
2022-08-21 18:46:58 +05:30
Ankush Menat
48869d506f perf: dont order by for uniq searches 2022-08-21 17:37:40 +05:30
Ankush Menat
61a9349789 perf: use is_virtual_doctype and remove limit
This reduces 1 query for each child table read

Removed limit cause with 1000+ doctypes in frappe+erpnext this cache
will just keep getting trashed for no reason. There's clear upper bound
on size so no need to limit it here.
2022-08-21 17:37:40 +05:30
Ankush Menat
786df3fbeb perf: ~33% faster Desk response
- hardcode `/app` resolution
- use cached website settings everywhere. It was mixing cache and DB
  everywhere and re-quering same thing (why ?)
2022-08-21 17:35:07 +05:30
Ankush Menat
04aeeabb2b fix(recorder): make whole order button clickable 2022-08-21 17:35:07 +05:30
Ankush Menat
69a8027935 fix: jump to field shows column/section breaks 2022-08-21 13:00:34 +05:30
mergify[bot]
d3da57cee2
fix: Turkey number format corrected (#17886) (#17888)
(cherry picked from commit b0a808b2c4c156c8374664f32b8a1a0106eb3b90)

Co-authored-by: Türker Tunalı <turker.tunali@gmail.com>

[skip ci]
2022-08-20 19:51:04 +05:30
Shariq Ansari
d274b56817 chore: code cleanup 2022-08-19 15:56:44 +05:30
HENRY Florian
11a17d3867
feat: STARTTLS authentication for IMAP (#17683)
Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2022-08-19 13:40:06 +05:30
Ankush Menat
f002016eb6
chore: limit over-logging of handled exception (#17878)
[skip ci]
2022-08-19 12:53:51 +05:30
Shariq Ansari
364366ae99 fix: submit button should always be on extreme right 2022-08-19 11:41:50 +05:30
mergify[bot]
eaf3aa28ee
Merge pull request #17860 from pps190/fix-dataimport
fix: data import preview link warning
2022-08-18 15:47:23 +00:00
mergify[bot]
d1ce02474a
Merge pull request #17826 from resilient-tech/perf-custom-fields-creation
perf: ~65% faster `create_custom_fields`
2022-08-18 15:30:26 +00:00
Ankush Menat
9fa24c2b46
Merge pull request #17872 from ankush/exceptions_logging
fix: pop pwd from form dict, disable auth logging
2022-08-18 18:58:17 +05:30
Ankush Menat
b2b0b64d8c
refactor: add default to pop
[skip ci]

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-08-18 18:34:52 +05:30
Shariq Ansari
c5f64d43bb fix: text editor overflow issue 2022-08-18 18:22:32 +05:30
Shariq Ansari
5cdf21d8ee fix: minor success page css changes 2022-08-18 16:39:21 +05:30
Ankush Menat
f2b6c937c9 fix: pop pwd from form dict, disable auth loggin
- This prevents accidental logging of this info somewhere down the line.
- Disable exception logging for auth failures
2022-08-18 15:32:42 +05:30
Shariq Ansari
fc2defcc3f fix: foreach doesnt work for html element looping 2022-08-18 15:19:59 +05:30
Shariq Ansari
8bd012da0c fix: remove page breaks without any fields in it 2022-08-18 15:12:29 +05:30
Faris Ansari
82fef72ce1
fix(db-query): parenttype condition on child table left join (#17865)
joining only on name is incorrect because parent primary keys are not unique across tables

How was this working all this time? 🥲
2022-08-18 09:04:40 +00:00
Shariq Ansari
9288d0cebf fix: replaced clear button with discard button 2022-08-18 13:18:55 +05:30
Shariq Ansari
6ed42f5213 test: fixed failing unit test 2022-08-17 21:37:20 +05:30
Shariq Ansari
2181233c75 test: fixed failing UI test 2022-08-17 21:27:09 +05:30
Shariq Ansari
7ae2202b75 fix(minor): success page button css (responsive) 2022-08-17 21:00:55 +05:30
Ankush Menat
48a735ccce
Merge pull request #17862 from ankush/boto3_bump
chore(deps): bump boto dependency
2022-08-17 20:56:25 +05:30
Shariq Ansari
05b1a99e53 chore: sider fixes 2022-08-17 20:34:48 +05:30
Devin Slauenwhite
87972656d4 fix: convert pk from db to str. 2022-08-17 10:52:31 -04:00
Ankush Menat
821a4df192 chore(deps): bump boto dependency 2022-08-17 20:18:14 +05:30
Shariq Ansari
eb7dccaae2 fix: made web form skeleton responsive 2022-08-17 20:15:22 +05:30
Shariq Ansari
0889d9137f fix: made web form and web list responsive 2022-08-17 20:12:46 +05:30