sokumon
ff24af1f08
fix: sidebar UI issues
2025-11-20 11:26:02 +05:30
Akhil Narang
69e768f191
Merge pull request #34782 from akhilnarang/fix-number-card-query
...
fix(number_card): migrate to new function syntax
2025-11-20 11:20:59 +05:30
Akhil Narang
a0176603d7
fix(number_card): migrate to new function syntax
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-20 11:11:25 +05:30
Akhil Narang
91df62f0f4
Merge pull request #34146 from akhilnarang/use-qb
...
feat(db_query)!: use query builder
2025-11-19 21:35:53 +05:30
Ankush Menat
81bc61fe97
chore: remove dead code
2025-11-19 21:15:58 +05:30
Akhil Narang
0f3fc00f00
fix: handle converting datetime -> date for fieldtype date
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
15588de6cd
fix(query): ensure backwards compatibility for sorting, filtering
...
If `db_query_compat=True` (set by `qb_query.py`), then we default to some `db_query.py` behaviour.
Otherwise, we'll retail the previous query builder behaviour, this is to minimize breakage on either side.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
2c15bb4a5b
fix(query): extend regex for allow backticked aliases
...
For example:
```
`tabSerial and Batch Entry`.`name` as `child_row`
```
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
bd84d7a66a
fix: match db_query behaviour for certain cases like
...
`filters.append(["reports_to", "=", ""])`
Earlier this generated:
```
( `tabEmployee`.`reports_to` is NULL OR `tabEmployee`.`reports_to` = '' )
```
Without this change, with qb it was
```
`reports_to`=''
```
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
952b0d4500
chore: test
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
9455721c77
fix: skip group by permission check for certain columns
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
978edeaa1d
feat: add in some functions
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
0bb1b4477c
fix(query): case insensitive check
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
ccb675b0f2
fix(list): fix distinct usage
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
07e8c987cb
fix(check_field_permissions): allow if no permissions defined
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
1ba9c14cd5
fix: check for shared documents
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
943df998d6
feat: support certain backticked expressions
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
7ad6f7e2c6
refactor: ensure no meta recursion
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
a5e44c4c6e
fix(query): check whether filter fields belong to child tables if not part of parent
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
30d6ebc6c6
fix: tests
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
90e4ec29b7
fix(reportview): temporarily skip validation for dict fields
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
ea926b0f31
fix(search): adjust query formation to align with new restrictions
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
08e7a72ba2
refactor: uppercase function assertions
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
49c451068f
fix: adjust tests for query builder permission
...
Earlier you could use fields you didn't have access to for filtering, now you can't.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
ddcda11d67
fix: function detection
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
b407fe8093
fix: allow function aliases
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
3040ab7eb2
feat(query): add in IFNULL logic from db_query
...
Use `IFNULL(var, "") == ""` instead of `isnull()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
df5080b45e
fix(linked_with): don't add tab prefix
...
query builder takes care of this
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
0ea49a8f1e
fix: make sure limit is an integer
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
bd48f5df65
fix(convert_to_value): convert dict_keys and dict_values to a tuple as well
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
a9d0abaf7b
fix(test_server_script): loosen test a bit, allow any case
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
e420e7646f
fix(query): match db_query, add parentheses around condition
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
b4cf69732b
fix(query): allow numeric strings
...
For things like `COUNT(1)`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
e15ec47ba1
fix(query): allow passing as in any case
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
8e03924356
fix(query): allow AggregateFunction as well in apply_field_permissions
...
Without this `fields=[{"COUNT": "name"}]` didn't work, although fields=[{"COUNT": "NAME"}] did.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
1d2a73f659
fix: support virtual doctype handling
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
7183caf871
fix(query_builder): default sorting based on doctype meta
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
5d992a5eb1
refactor: migrate a few queries to use query builder
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
977aee5ab3
refactor: backticks aren't allowed in order_by or group_by
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
90ed0502fa
refactor: support new function style
...
- Migrate all SQL function usage from string format to dict format
- Old: fields=['count(*) as count']
- New: fields=[{'COUNT': '*', 'as': 'count'}]
- Add `NULLIF`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
5d3f7aaab9
refactor: use qb_query for get_list
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
340fe279b3
feat: add in initial version of DatabaseQuery using query builder
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Soham Kulkarni
518e94ea98
Merge pull request #34769 from sokumon/desktop-fixes
...
fix: delete desktop icons when app is uninstalled
2025-11-19 16:45:36 +05:30
sokumon
7c93730cfc
fix: semgrep issues
2025-11-19 13:21:52 +05:30
sokumon
a0edd3e3f2
fix: delete desktop icons when app is uninstalled
2025-11-19 12:30:15 +05:30
Soham Kulkarni
7aba4a3dfd
Merge pull request #34766 from sokumon/desktop-fixes
...
fix: dark mode for folder icons and desktop icon access restrict
2025-11-19 10:58:52 +05:30
sokumon
656aaa1f2f
feat: show restricted desktop icons
2025-11-19 10:33:22 +05:30
Akhil Narang
1e2d730202
Merge pull request #34670 from trustedcomputer/cogkfix-host-url-when-printing-outside-request
...
fix: Get host URL when printing outside of request
2025-11-18 17:39:32 +05:30
sokumon
ed56722b03
fix: folder icon styles polish
2025-11-18 15:22:29 +05:30
Soham Kulkarni
7f72e988af
Merge pull request #34744 from sokumon/desktop-fixes
...
fix: set a fix width of sidebar header
2025-11-18 14:09:47 +05:30