Commit graph

1494 commits

Author SHA1 Message Date
AarDG10
9bcac62d98 fix(standard_macros): escape fields in standard print format template
Escaping on output, and reverting changes made in formatters.py.
2026-04-28 08:12:16 +05:30
Ankush Menat
1f9015a9c2
fix: Re-add rate limit on blog comments (#38862) 2026-04-24 05:09:14 +00:00
Shrihari Mahabal
117c09e8d9 fix: escape text and long text fields when printing 2026-04-17 16:32:10 +05:30
mergify[bot]
6480613103
Merge branch 'develop' into web-hero 2026-04-17 06:55:08 +00:00
Shariq Ansari
304283c222
Merge pull request #38588 from shariquerik/reset-password-fix 2026-04-15 16:13:28 +05:30
shariquerik
33077e0a2c test: ensure consistent response and messaging in password reset functionality 2026-04-15 12:13:19 +05:30
Ejaaz Khan
435f82a0f4
Merge pull request #37662 from safwansamsudeen/improve-barcode
fix: render barcodes in print view
2026-04-14 19:47:00 +05:30
Sabu Siyad
ec9a60172f
feat: security.txt (#38530)
* feat: `security.txt`

* fix(security-settings): public_policy must start be https

* feat(security-settings): preview `security.txt`

* refactor(security-settings): security_txt logic

* feat(security-settings): security_txt expires

* refactor(security-txt): get content from security settings

* fix(security-txt): serve only over https

* fix(security-settings): change labels (plural)

- contacts
- languages

* refactor(security-settings): move to website module

* feat(security-settings): banner/alert on security.txt with link to RFC

* feat(security-txt): expiry alert emails

* fix(security-settings): banner gets duplicated on save

* refactor(security-settings): move to `Core` module

* test(security-settings): add unit tests

* fix(security-settings): translatable strings on throw
2026-04-14 17:22:22 +05:30
Shariq Ansari
8764dada2a
Merge branch 'develop' into reset-password-fix 2026-04-14 15:28:01 +05:30
shariquerik
f00c4b7738 fix: enhance password reset flow to prevent username enumeration 2026-04-14 15:23:04 +05:30
sokumon
8d53f632e3 fix: remove unecessary user check for guest commenting 2026-04-06 13:53:43 +05:30
Shrihari Mahabal
1a03e5af8d fix: make translation version update for system and user translations both 2026-03-26 12:53:10 +05:30
Shrihari Mahabal
9ef5aa256b perf: remove translations from boot 2026-03-26 12:53:09 +05:30
Ejaaz Khan
4fa02b3494 fix: Add check for user_id in avatar macro
(cherry picked from commit 461391e0ba1a21103c2ad0680db44a128b26c79d)
2026-03-18 09:01:56 +00:00
Safwan Samsudeen
7e739faea7 fix: only render if barcode value is not an svg 2026-02-27 19:43:47 +05:30
Safwan Samsudeen
6e344db222 fix: support options
fix: bundle files
2026-02-27 18:38:58 +05:30
Safwan Samsudeen
97c3ce6408 fix: render barcodes in print view 2026-02-27 17:19:28 +05:30
Aarol D'Souza
3c027bdc58
fix: escape avatar image (#37633) 2026-02-27 17:11:14 +05:30
Sumit Jain
e9b1017d46 fix: Add translation for labels in print format templates 2026-02-25 20:49:06 +05:30
Aarol D'Souza
c55ff193a6
fix: add type hints to whitelisted methods 3 (#37149)
* fix(apps): add type hints to whitelisted methods

* fix(recorder): add type hints to whitelisted methods

* fix(comments): add type hints to whitelisted methods

* fix(oauth2): add type hints to whitelisted methods

* fix(google_calendar): add type hints to whitelisted methods

* fix(print): add type hints to whitelisted methods

* fix(print_format_builder): add type hints to whitelisted methods

* refactor(network_printer_settings): remove unused args

* fix(document): add type hints to whitelisted methods

* fix(user_settings): add type hints to whitelisted methods

* fix(mapper): add type hints to whitelisted methods

* fix(connected_app): add type hints to whitelisted methods

* fix(google_contacts): add type hints to whitelisted methods

* fix(frappecloud_billing): add type hints to whitelisted methods

* test: rewrite test to fit the strict type check

* fix(social_login_key): add type hints to whitelisted methods

* fix(share): add type hints to whitelisted methods

* fix(webhook): add type hints to whitelisted methods

* fix(workflow): add type hints to whitelisted methods

* fix(workflow main): add type hints to whitelisted methods

* fix(workflow_action): add type hints to whitelisted methods

* fix: flexible type hint

* fix(client): add type hints to whitelisted methods

* fix: fix some of the tighter types

* fix(frappecloud_billing): add str typehint to whitelisted endpoint

* fix: target_doc can be dict/json string

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-20 06:50:19 +00:00
Aditya Patil
35909f5c45
refactor: removed usage of cmd for login (#36801)
* refactor: removed usage of `cmd` for login

* refactor: use `set_request` in activity log tests
2026-02-16 14:09:48 +05:30
krantheman
5d135a20b2 fix: show search filter on portals and fix layout 2026-02-05 12:45:23 +07:00
ayushschaudhari1904@gmail.com
b52f14939d fix(print_format): better formatting for data field 2026-02-04 10:46:08 +05:30
barredterra
820c9092e9 fix: move hero block inside content block
The `hero` block was defined at the top level of `web.html`, but since `web.html` extends `base.html` which has no `hero` block, that content was simply discarded. By moving it inside the `content` block, child template's overrides will now work correctly.
2026-02-02 23:13:00 +01:00
Akhil Narang
238f25943b
fix(new_user): escape name
People can enter any name, including HTML, which would get rendered as the value was being used in jinja directly

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-27 18:04:48 +05:30
Akhil Narang
678d7ab0f9
fix(login): don't let button text stuck at "Verifying" if you get rate limited (#35671)
Resolves #35402

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-05 17:12:28 +00:00
K
2e36bfbbae
fix: add label for signature field in print format (#35144) 2025-12-10 07:35:36 +00:00
Ejaaz Khan
ac448227be feat: cool awesomebar 2025-11-26 12:22:28 +05:30
sokumon
49714e916f chore: rename from app to desk 2025-11-14 23:05:13 +05:30
Ejaaz Khan
4f365bfbf5 refactor: add backwards compatibility styles
Co-authored-by: Maharshiv Patel <maharshivpatel@users.noreply.github.com>
2025-10-07 16:33:59 +05:30
Ejaaz Khan
510669b64c fix: remove unwanted top padding 2025-09-29 12:19:59 +05:30
Ejaaz Khan
964dd6c034 feat: Chrome PDF generator
Co-authored-by: maharshivpatel <maharshivpatel@users.noreply.github.com>
2025-09-29 12:15:51 +05:30
Raizaaa
aa3bb0e4d7 fix: remove trailing spaces in translatable strings 2025-08-27 13:23:17 +03:00
Samuel Helbling
ed0d3c9616
fix: remove unnecessary xss sanitization from login email input (#33377) 2025-08-12 11:51:33 +05:30
Akhil Narang
0cd2f9ef05
fix: jinja template had missing }} (#33541)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-08-05 11:56:33 +00:00
Elton Lobo
6d1008933f
feat: add user invitation doctype & related public methods (#33308)
* feat: add user invitation doctype & related public methods

* style(user-invitation): execute formatters & add semgrep comments

* refactor(user-invitation): use `is` to compare `None` values

* fix(user-invitation): skip fetching `after_accept` for default app

* fix(user-invitation): translate email templates

* fix(user-invitaton): return pending invites from invite by email api

* refactor(user-invitation): improve code quality

* fix(user-invitation): translate all error messages

* refactor(user-invitation): improve security & readability

Improvements:
- move invite expiration check to `daily_maintenance`
- explicitly import all of the used packages
- specify methods for all security-critical endpoints
- improve error messages and give them suitable titles
- remove unnecessary utility functions
- make invitation key management secure
- translate all of the subjects of the sent emails
- use the `app_title` hook to create email titles
- commit the work done after each iteration of the background invitation
  expiry checker
- restructure code to improve readability
- use `user.reset_password` to generate the target link
- use clear long names to name identifiers
- add document states with relevant colors (User Invitation doctype)
- differ `sendmail` emails whenever possible
- send an email to the invitation creator instead of the invitee after
  the invite has expired
- remove `User Invitation Manager` role

* fix(user-invitation): use valid emails to test doctype & related code

* feat(user-invitation): support adding multiple roles

* refactor(user-invitation): mark relevant fields `set only once`

* feat(user-invitation): add `Cancelled` status

* test(user-invitation): correct broken tests

* test(user-invitation): form valid f-strings & run code formatter

* feat(user-invitation): make doctype usable from desk

* fix(user-invitation): remove delete permission from invitation doctype

* feat(user-invitation): pass user inserted info to `after_accept` hook

* refactor(user-invitation): improve custom action methods & errors

Improvements:
- trigger actions only when the invitation is in the `Pending` state
- use lowercase letters to start error messages
- handle cases where `user_invitation_hook` is not defined

* refactor(user-invitation): remove site name from email templates

* docs(user-invitation): add internal documentation

* feat(user-invitation): add 'get pending' & cancel invites apis

* fix(user-invitation): make invitation app specific

* refactor(user-invitation): avoid mixing function programming

* fix(user-invitation): make apis usable for app specific valid users

* fix(user-invitation): allow app specific invites

* feat(user-invitation): make list view & permission checks app specific

* refactor(user-invitation): convert class methods to static when possible

* feat(user-invitation): add `app_only_for` method to the doc

* fix(user-invitation): f-string syntax error in `get_permission_query_conditions`

* docs(user-invitation): add examples & improve the internal doc

* refactor: rename method name

static_ is unnecessary
only_for doesn't make sense in this context when arguments are not roles

* fix: Support POST request too

We dont follow REST semantics 100%, anything that modifies something
should ideally be doable with POST too.

* chore: cap

* fix: Avoid ignore_permissions as user arg

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2025-07-28 16:25:53 +05:30
Soham Kulkarni
64db88228f
refactor: seperate blogs into a seperate app (#32737)
* fix: remove doctypes,workspace blocks, files

* fix: minor python tests and UI tests

* fix: remove blog post from tests

* fix: remove blogger as role for tests

* fix: add check for if doctype exists

* fix: ui test

* fix: more cleanup

* fix: cleanup comments and fix test_query

* fix: resolve conflicts

* fix: add warning and handle comments
2025-07-28 14:35:02 +05:30
Ernesto Ruiz
57067b9af7
chore: add translation function to file_backup_notification template (#33231) 2025-07-07 11:28:05 +05:30
Vishal Sindham
e1217282ac feat(password-reset-form): Add show/hide toggle option to password reset form 2025-06-29 19:47:02 +05:30
Soham Kulkarni
e1aa789acf
Merge pull request #32971 from sokumon/newsletter-removal
refactor: seperate newsletter into app
2025-06-27 11:59:02 +05:30
Sagar Vora
2e5c8bea03 feat: frappe.utils.orjson_dumps 2025-06-26 17:37:51 +05:30
sokumon
32a87f53d6 fix: delete newsletter related files 2025-06-18 16:23:36 +05:30
Corentin Forler
26b279864f
fix: Fix link in delete data confirmation email template (#32544) 2025-05-16 10:00:20 +05:30
Corentin Forler
35d557f46d
chore: remove empty template (#32543) 2025-05-16 09:58:45 +05:30
Ankush Menat
66e91445f5 fix: remove eps template 2025-04-23 12:05:01 +05:30
Ejaaz Khan
ed6dd8cd5b fix: print builder beta print option not working 2025-04-14 11:32:44 +05:30
marination
4dcd579b47 fix: Translate Footer Items 2025-02-25 13:22:57 +01:00
Ejaaz Khan
2fb0629197
fix: alignment Issues with Serial Numbers and Descriptions (#29093)
* fix: serial numbers not aligned with other cells

* refactor: remove top margin from editor
2025-01-13 11:50:01 +05:30
Ejaaz Khan
93c33de489 fix: splash logo is not rendering properly 2025-01-09 16:24:04 +05:30
mahsem
e8698a98de
fix: add strings and fields to translation 2024-12-21 13:17:01 +01:00