Commit graph

44996 commits

Author SHA1 Message Date
Ankush Menat
ffe84c9f9d Revert "perf: cache fieldname extraction"
This reverts commit c591fcc5c1.
2024-01-17 12:44:09 +05:30
Ankush Menat
cf2be9d64e
Merge pull request #24410 from ankush/perf_fieldname
perf: cache fieldname extraction
2024-01-17 12:06:55 +05:30
Ankush Menat
c591fcc5c1 perf: cache fieldname extraction 2024-01-17 11:50:13 +05:30
Sambasiva Suda
642e9f4ec1
fix: search_link fails when txt contains parentheses (#22892)
* fix: search_link fails when txt contains parentheses

* fix: updating regex to replace number params also

* chore: replacing regex with sqlparse

* chore: not including fields like count(1) in asterisk_fields

* fix: owner/module not identified as column

* chore: lint fix and removing exception

* refactor: better function name

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-01-16 21:36:45 +05:30
Corentin Flr
7123f50912
feat(list): Add hide_name_filter setting (#24402)
Co-authored-by: Corentin Forler <8860073-cforler_dokos@users.noreply.gitlab.com>
2024-01-16 21:15:58 +05:30
Ankush Menat
484049c5ae
fix: simultenous sessions ux (#24387)
* fix: set 2 as simultaneous_sessions by default

* fix: Correct offset for simultaneous_sessions

* refactor: use freeze_time instead of patching

* chore: misleading docstring

* test: set lower simultaneous_sessions for test
2024-01-16 13:36:05 +00:00
Raffael Meyer
ed09885eb4
Merge pull request #24390 from barredterra/remove-redundant-drive-api-key 2024-01-16 14:08:23 +01:00
barredterra
c17f014ef4 refactor: remove redundant API Key from Google Picker 2024-01-16 13:26:03 +01:00
Ankush Menat
307da3097f
Merge pull request #23329 from akhilnarang/allow-setting-db-username
refactor: allow setting a db user name different from the database name
2024-01-16 17:46:03 +05:30
mergify[bot]
78463031b5
Merge pull request #24329 from blaggacao/fix/error
fix: undue error printing
2024-01-16 12:07:48 +00:00
David Arnold
dcf0efa123
Merge remote-tracking branch 'origin/develop' into fix/error 2024-01-16 12:47:51 +01:00
Akhil Narang
f57315c2ec
Merge pull request #24381 from akhilnarang/fix-sentry-background-job
fix(sentry): set scope for background jobs
2024-01-16 16:43:36 +05:30
Akhil Narang
92326d143d
fix(sentry): set scope for background jobs
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 16:26:48 +05:30
Akhil Narang
3ccdbfbde0
fix: drop a fallback
Had some issues earlier - seems to be resolved now

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 13:01:13 +05:30
Akhil Narang
fff866417d
fix: format
Got messed up during rebase - forgot to run pre-commit before `git rebase --continue`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
9b18289b33
fix: postgres uses double quotes for identifiers, especially if case-sensitive
(single quotes would force it to lowercase)

Also unconditionally create a new user while running tests - we're gonna be dropping the test site

Don't pass a `None` value to bench cli

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
265c0b0e01
fix(drop-site): set db root credentials in frappe.flags like how new-site is done
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
f876aa385c
fix(setup_db): use the correct user
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
1e6eeba9b7
fix: add in missing logic, add in a test for creating a site with a specific user
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
d1906b3c16
refactor: add in a fallback to use db name as db user name
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
ed05acd3d0
refactor(replica): allow using separate db user name
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
7419da64a1
fix: set a fallback for db user in connect()
In case we don't have a site name, `init()` won't be called, and we won't have a username

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Akhil Narang
c721fcf8c4
refactor: allow setting a db user name different from the database name
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-16 12:35:01 +05:30
Maharshi Patel
2ecb712e62
Merge pull request #24258 from maharshivpatel/event-add-more-options
feat(minor): add more event repeat options
2024-01-16 12:33:00 +05:30
Suraj Shetty
a28457ac15
Merge pull request #24374 from surajshetty3416/fix-sentry-1 2024-01-16 11:38:28 +05:30
Suraj Shetty
cbbd22a7eb fix: Handle edge case while searching in current context 2024-01-16 11:36:34 +05:30
Ankush Menat
a2525e545a
perf: Unbuffered cursors for large result sets (#24365)
If you're reading 1000s of rows from MySQL, the default behaviour is to
read all of them in memory at once.

One of the use case for reading large rows is reporting where a lot of
data is read and then processed in Python. The read row is hoever not
used again but still consumes memory until entire function exits.

SSCursor (Server Side Cursor) allows fetching one row at a time.

Note: This is slower than fetching everything at once AND has risk of
connection loss. So, don't use this as a crutch. If possible rewrite
code so processing is done in SQL.
2024-01-16 11:00:12 +05:30
David Arnold
608f2ed20b
test: make phone number unique bis (#24367) 2024-01-16 10:56:47 +05:30
Maharshi Patel
399ccfcdaf test: added test for new event repeat options
added test for quarterly and half yearly repeat option.
2024-01-16 10:39:50 +05:30
Maharshi Patel
40ed3abe1a Merge branch 'develop' into event-add-more-options 2024-01-16 10:19:59 +05:30
David Arnold
997a341b40
Merge remote-tracking branch 'origin/develop' into fix/error 2024-01-15 15:24:42 +01:00
Ankush Menat
b62aa06bc4
fix: translate show all activity label (#24363)
[skip ci]
2024-01-15 19:05:38 +05:30
Ankush Menat
1b7e8635b5
chore: New translations main.pot (German) (#24353) 2024-01-15 18:32:13 +05:30
mergify[bot]
7c526bc7cd
Merge pull request #24354 from akhilnarang/check-for-gpg-install
fix: add a check for `gpg` existing
2024-01-15 12:44:02 +00:00
Raffael Meyer
7f64abc9bd
Merge pull request #24328 from blaggacao/chore/use-configurable-folders-during-esbuild 2024-01-15 13:37:46 +01:00
Akhil Narang
235be44d7a
fix: add a check for gpg existing
Encrypted backup/restores just fail without a clear error message if gpg is missing

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-15 17:52:51 +05:30
David Arnold
93bbe615ba
chore: use env variables in esbuilds 2024-01-15 11:17:29 +01:00
Ankush Menat
d5d9b12472
test: flaky server tests (#24301)
* Revert "fix(test_recorder): get the correct request (#24143)"

This reverts commit 745080c56e.

* test: disable recording before running assertions

* test: Dont set emails in test for broken email setup
2024-01-15 08:09:46 +00:00
Ankush Menat
a69b779715 fix: Make as_iterator work when there are no child queries
QB child queries feature assumes that result will be list, at least in
case of no chlid queries we can make it work. (this is most common case anyway)
2024-01-15 13:05:35 +05:30
Ankush Menat
deebb1130b
Merge pull request #19810 from ankush/sql_iter
feat: `frappe.db.sql` results `as_iterator`
2024-01-15 12:37:57 +05:30
Ankush Menat
03b6d8a4b0 test: add perf test for references 2024-01-15 12:32:07 +05:30
Ankush Menat
d5b27061ad perf: avoid duplicate copies of result set
When as_list, as_dict is done we hold on to original result set until
next query is performed. This can be HUGE for large queries.
2024-01-15 12:32:07 +05:30
Ankush Menat
588157df74 feat: frappe.db.sql results as iterator
- Also avoid self.last_result that holds on to large result set reference.
2024-01-15 12:32:02 +05:30
Ankush Menat
cbf6faccb5 fix(DX): Print available sites when URL is invalid 2024-01-15 12:30:43 +05:30
Ankush Menat
0192df06ca
ci: use node20 for semantic release (#24343)
[skip ci[
2024-01-15 11:53:13 +05:30
Safwan Samsudeen
6e7a3c4863
fix: mobile sidebar disappearing (#24316) 2024-01-15 11:29:25 +05:30
Raffael Meyer
4e81587280
Merge pull request #24326 from barredterra/drop-giturlparse 2024-01-14 18:26:19 +01:00
Raffael Meyer
431b2eb89c
Merge pull request #24318 from blaggacao/refactor/explicit-current-db-name 2024-01-14 18:21:47 +01:00
Raffael Meyer
8b18397306
Merge pull request #24320 from maharshivpatel/check-markdown_preview 2024-01-14 18:00:43 +01:00
Raffael Meyer
0ff9657e12
Merge pull request #24323 from maharshivpatel/fix-base-control-input-var 2024-01-14 17:57:19 +01:00