vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

test: remove toleration for test record creation failure (#28143)

Browse source 
this ensures test record creation conforms with the spec or fails sharply
This commit is contained in:
David Arnold 2024-10-16 16:18:36 +02:00 • committed by GitHub
parent 860ae4fdcb
commit 30dda5287c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
frappe/tests/utils/generators.py
View file

@ -323,17 +323,11 @@ def _try_create(record, reset=False, commit=False) -> tuple["Document", bool]:
d.docstatus = 0
tolerated_errors = (frappe.NameError, *(d.flags.ignore_these_exceptions_in_test or []))
try:
d.run_method("before_test_insert")
d.insert(ignore_if_duplicate=True)
d.run_method("before_test_insert")
d.insert(ignore_if_duplicate=True)
if docstatus == 1:
d.submit()
except tolerated_errors as e:
logger.warning(f"Error during test record creation for {d.name} ({d.doctype}): {e!s}")
revert_naming(d)
if docstatus == 1:
d.submit()
if commit:
frappe.db.commit()