vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(query): don't allow using Document as a filter value (#34823)

Browse source 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-11-24 11:13:43 +05:30 • committed by GitHub
parent 5fecde5a6a
commit bd044e520c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/database/query.py
View file

@ -20,6 +20,7 @@ from frappe.database.utils import (
)
from frappe.model import get_permitted_fields
from frappe.model.base_document import DOCTYPES_FOR_DOCTYPE
from frappe.model.document import Document
from frappe.query_builder import Criterion, Field, Order, functions
from frappe.query_builder.custom import Month, MonthName, Quarter
from frappe.query_builder.utils import PseudoColumnMapper
@ -454,6 +455,9 @@ class Engine:
else:
# Regular value processing for literal comparisons like: table.field = 'value'
_value = convert_to_value(value)
if isinstance(value, Document):
frappe.throw(_("Document cannot be used as a filter value"))
_operator = operator
# For Date fields with datetime values, convert to date to match db_query behavior