Ankush Menat
00a82fabd7
Merge pull request #18164 from resilient-tech/perf-meta-field-map
...
perf: cache `Meta` directly and other improvements
2022-09-19 16:37:39 +05:30
Ankush Menat
40f6a34840
build: pin testing-library/dom temporarily
...
refer https://github.com/testing-library/dom-testing-library/issues/1169
2022-09-19 16:21:23 +05:30
Ankush Menat
c28ddcc3e6
test: basic perf test for rps on get_list
2022-09-19 16:21:20 +05:30
Ankush Menat
bcb5fe91aa
fix: pickle doc objects directly
...
This seems to be missed out and causes performance regression in IRL
usage when get_doc is called on cached doc already.
2022-09-19 16:21:20 +05:30
Ankush Menat
abd018773b
refactor: drop _allow_dict support
...
This is not required anymore since we store full doc anyway. Also since
they share same cache key calling get_cached_value and get_cached_doc
can end up doing duplicate / double work.
2022-09-19 16:21:11 +05:30
Sagar Vora
b529c27cb5
fix: ensure error is thrown
2022-09-19 16:21:11 +05:30
Sagar Vora
6c6a969d3a
perf: simpler, faster meta cache
2022-09-19 16:21:11 +05:30
Sagar Vora
df8399f5d3
perf: initialise field map when initialising meta
2022-09-19 16:21:11 +05:30
Sagar Vora
fc3ee12baf
perf: cache FormMeta directly ( #18165 )
...
* perf: cache `FormMeta` directly
* perf: check if `dt` is table, use `db.get_value` instead of `get_all`
2022-09-19 16:10:32 +05:30
Ankush Menat
7f1655fe46
build(deps): drop pyOpenSSL dependency ( #18162 )
...
- Not used anymore
- Official documentation suggests stopping use of
pyopenssl: https://github.com/pyca/pyopenssl
2022-09-17 12:15:26 +05:30
Devin Slauenwhite
4affd9b076
feat: specify sender for auto email report ( #18073 )
...
Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2022-09-16 18:56:36 +05:30
Nrtyck
1e87483a2c
fix: Must check array length ( #18161 )
...
If not check , it will not work
2022-09-16 17:05:05 +05:30
Sagar Vora
709c9305ae
chore: remove unused RequestContext class ( #18152 )
2022-09-15 23:22:14 +05:30
MOHAMMED NIYAS
2e7d41047b
feat: completed option to status ( #18104 )
...
if the event is completed today then user can mark it as completed not closed
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-15 20:17:48 +05:30
Rucha Mahabal
da5a6d3f24
fix: show Roles child table for custom reports ( #18139 )
2022-09-15 19:54:07 +05:30
Ankush Menat
82cd238f54
perf!: Only add modified index on parent doctypes ( #18119 )
...
When are child tables sorted by timestamp by default?
2022-09-15 19:16:12 +05:30
Saqib Ansari
6997f9e90f
fix: do not rename fieldtype options ( #18143 )
2022-09-15 17:30:52 +05:30
Nikhil Kothari
b974bed769
fix: signup link removed if user-pass disabled ( #18135 )
2022-09-14 19:53:53 +05:30
Ankush Menat
1ba99396bc
fix: fail code when build fails in production
...
In production it is useful to fail with proper exit code. To avoid
silently pushing bad assets in built pipelines.
2022-09-14 19:40:22 +05:30
Ankush Menat
06aaaaaedf
build: move all devDependencies to Dependencies
...
These are real dependencies without which you can't locally build apps.
2022-09-14 19:40:22 +05:30
Rucha Mahabal
529e8ebde1
fix(minor): Use colors passed to render_graph on form dashboards ( #18132 )
2022-09-14 17:31:18 +05:30
Athul Cyriac Ajay
31a37ed671
chore: Add make_put_requests method for Server Scripts ( #18128 )
2022-09-14 15:54:15 +05:30
rohitwaghchaure
fd3df669f7
fix: dynamic label for document rename ( #18125 )
2022-09-14 15:51:28 +05:30
Ankush Menat
4ca3bf2d0b
fix: show portal sidebar on login ( #18126 )
2022-09-14 15:37:43 +05:30
Ankush Menat
7453e8e3a1
perf: drop all old parent indexes
...
- re-add parent index on custom_docperm
2022-09-14 14:28:47 +05:30
Ankush Menat
3a5a45d8af
perf: drop many unused indexes
...
- reference owner - only used for activity page which is unusable
*anyway*
- same for timeline and link doctypes
perf: drop unused index from Commment
Can't find a single query that uses this index
perf: drop pointless "Is home folder" index
just why? It's checkbox index with 1 entry which has unique name already
Most pointless index I've seen no far.
perf: Drop "attached to doctype" separate index
There is already a composite index for this.
perf: drop indexes from web page view log
BOTH are totally unused in any of the queries related to this doctype.
Only "website analytics" report uses this which doesn't even show this
data lmao.
perf: drop unused index from EPS log
We never filter by doctype or type. pointless indexing.
perf: fix up notification log indexes
- drop unused index
- add "for user" index
2022-09-14 14:28:47 +05:30
Ritwik Puri
255bc211af
refactor(minor): simplify show_kanban_dialog & allow multiple kanban board creation ( #18111 )
...
* allow multiple kanban board creation for the same doctype
* simplify show_kanban_dialog
* directly jump to a kanban if available/from last_opened_kanban property - no need to show a dialog for selection
2022-09-14 14:26:18 +05:30
Ankush Menat
4120d5a8e3
fix: RQ job name when func object is passed ( #18112 )
...
[skip ci]
2022-09-13 19:10:21 +05:30
Shariq Ansari
df9ec9cb16
Merge pull request #18109 from shariquerik/duplicate-workspace-fix
2022-09-13 17:13:19 +05:30
Shariq Ansari
f00cf1e290
fix: always show edit button
2022-09-13 16:47:02 +05:30
Shariq Ansari
21650ef383
fix: while duplicating do not set module field
2022-09-13 16:43:21 +05:30
Shariq Ansari
d1abbed18b
fix: create a private workspace if user doesnt have access while duplicating
2022-09-13 16:32:55 +05:30
Rucha Mahabal
14a84793a8
fix: Show quick list only if user has access ( #18102 )
2022-09-13 16:09:33 +05:30
Ankush Menat
b47f9c25e5
chore: let frappe bot raise stable branch PRs
...
[skip ci]
2022-09-13 15:15:34 +05:30
Shariq Ansari
235171796d
fix: coalesce not in queries ( #18099 )
...
* fix: get workspaces with empty module fields
* Revert "fix: get workspaces with empty module fields"
This reverts commit 1f194be2c3642e31ebe2165e461b2f24be8cda4c.
* fix: always coalesce `not in` queries
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-13 12:08:07 +05:30
Ernesto Ruiz
931e91be3d
fix: Add text inside translate function ( #18085 )
2022-09-12 18:01:34 +05:30
Ankush Menat
fd3b4c919a
Merge pull request #18089 from phot0n/sync-dashboard
...
fix: sync app dashboard on app install
2022-09-12 17:54:42 +05:30
Ritwik Puri
7f4974e923
Merge branch 'develop' into sync-dashboard
2022-09-12 16:19:19 +05:30
phot0n
1d27f936e9
fix: allow syncing of dashboard even if setup is not complete
2022-09-12 16:03:06 +05:30
Sagar Vora
627302d851
fix: set doctype and name in docinfo ( #18088 )
2022-09-12 14:18:20 +05:30
Ankush Menat
2866069eb4
chore: make contribution license explicitly known
...
This is implicitly assumed.
[skip ci]
2022-09-12 13:52:39 +05:30
Ankush Menat
1a60049af0
refactor: simpler job queued checking ( #18091 )
2022-09-12 12:59:00 +05:30
phot0n
3539dacdf0
fix: commit after app install
...
Since we destroy the connection after app installation,
mariadb implicitly rollsback the transaction hence committing upon successfull
app installation to prevent data sync loss
2022-09-12 12:23:14 +05:30
Ankush Menat
e20655bd20
Merge pull request #18086 from ankush/rq_redo
...
feat: Improved RQ monitoring and control with virtual doctypes
2022-09-12 11:49:53 +05:30
Ankush Menat
11936a76df
feat: kill a running background job -f
...
Also refactor permission checks
2022-09-12 11:49:25 +05:30
Ankush Menat
2267d40420
test: add tests for bg job monitoring code
2022-09-12 11:49:25 +05:30
Ankush Menat
fc048ae5e3
refactor!: remove background jobs page
2022-09-12 11:49:25 +05:30
Ankush Menat
4ae85b20db
feat: auto refresh RQ job page
2022-09-12 11:49:25 +05:30
Ankush Menat
46df97c3f2
feat: show scheduler status on RQ job page
2022-09-12 11:49:25 +05:30
Ankush Menat
6d264b149a
fix: serialize function objects to their repr
2022-09-12 11:49:25 +05:30