Commit graph

47204 commits

Author SHA1 Message Date
Shariq Ansari
06d0f2525b
Merge pull request #27577 from shariquerik/apps-page-fix-1
fix: boot.default_path is moved to boot.apps_data.default_path
2024-08-30 17:41:46 +05:30
Shariq Ansari
cc5db784f3 fix: boot.default_path is moved to boot.apps_data.default_path 2024-08-30 17:20:36 +05:30
Shariq Ansari
f140d6d59e
Merge pull request #27571 from shariquerik/apps-switcher-fix-1
fix: Consider default app path for Website User if applicable
2024-08-30 17:02:12 +05:30
Shariq Ansari
aa99faddea test: fixed failing user test 2024-08-30 16:48:21 +05:30
Shariq Ansari
f2e8f05558 fix: redirect to /app if no apps are installed 2024-08-30 16:23:24 +05:30
Shariq Ansari
2973739f2e fix: show Apps if multiple app or show CRM if only CRM is installed in dropdown 2024-08-30 15:42:58 +05:30
Shariq Ansari
9133f2a9c5 fix: added apps data in boot 2024-08-30 15:42:58 +05:30
Shariq Ansari
a7543a5b24 fix: consider default path for Website User if applicable 2024-08-30 15:42:58 +05:30
Shariq Ansari
ad077644c5 fix: changed default check icon 2024-08-30 15:42:58 +05:30
David Arnold
73610fed57
Merge pull request #27557 from blaggacao/chore/fix-editorconfig-json
chore: ignore helix folder
2024-08-30 08:54:39 +02:00
David
de49e03fde
chore: ignore helix folder 2024-08-29 14:28:52 +02:00
Raffael Meyer
cad512e5a0
fix(query report)!: skip empty filters in print (#27016) 2024-08-29 13:58:21 +02:00
Akhil Narang
37732496ad
Merge pull request #27542 from akhilnarang/clear-all-user-sessions
fix(sessions): logout properly when user requests logout on password change
2024-08-29 11:21:13 +05:30
Akhil Narang
cdfbbde3d5
Merge pull request #23691 from phot0n/fix-email-bulk-retry
refactor(minor): email retry
2024-08-28 16:54:48 +05:30
David Arnold
b0362684ef
Merge pull request #26752 from blaggacao/perf/make-get-requests-potentially-cachable
perf: make get requests cacheable
2024-08-28 10:44:19 +02:00
Akhil Narang
848bbe2382
Merge pull request #27539 from frappe/gavindsouza/website_search-norerun
fix(website_search): Avoid recursive loop if _items_to_index is falsy
2024-08-28 10:59:29 +05:30
Akhil Narang
84f1a2cdbe
Merge pull request #27541 from cogk/fix-round_floats_in-ensure-values-are-set-to-zero
fix: Set undefined values to zero in round_floats_in
2024-08-28 10:55:51 +05:30
Akhil Narang
5570aa71be
fix(sessions): logout properly when user requests logout on password change
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-27 17:58:20 +05:30
Corentin Forler
22324ab9e8
fix: Set undefined values to zero in round_floats_in 2024-08-27 14:19:57 +02:00
gavin
3544b87f58
fix(website_search): Avoid recursive loop if _items_to_index is falsy 2024-08-27 14:11:37 +02:00
Akhil Narang
dcd14d07dc
Merge pull request #27515 from Ninad1306/map_docs_fix
fix: Update Child table from the Last Source Doc
2024-08-27 13:29:20 +05:30
David Arnold
33de9ea8c6
Merge pull request #27237 from blaggacao/feat/datatable-tree-depth-on-query-reports
feat: set variable datatable tree depth
2024-08-27 09:36:19 +02:00
Akhil Narang
beadf189bf
Merge pull request #27528 from akhilnarang/escape-html-awesomebar
fix(search_utils): escape HTML before displaying in awesomebar
2024-08-27 11:26:24 +05:30
Rushabh Mehta
dfd7606d03
Merge pull request #27499 from rmehta/espresso-sidebar
feat(design): espresso style sidebar
2024-08-27 09:16:57 +05:30
Rushabh Mehta
2823f1a595 fix(minor): style fixes 2024-08-27 08:59:00 +05:30
Rushabh Mehta
25d1218f20
Merge pull request #27441 from cogk/fix-form-geolocation-field-in-tabbed-layout
fix(form): Fix Geolocation/Signature fields in tabbed layout
2024-08-26 23:44:11 +05:30
Rushabh Mehta
5a5fa9a440 fix(tests): workspace, awesome_bar 2024-08-26 23:06:19 +05:30
Rushabh Mehta
8793ca506f fix(tests): workspace 2024-08-26 22:04:20 +05:30
Rushabh Mehta
77b11dd1ce fix(tests): workspace tests and more style fixes 2024-08-26 18:15:59 +05:30
Akhil Narang
fbdd9e2484
fix(search_utils): escape HTML before displaying in awesomebar
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-26 16:21:57 +05:30
Rushabh Mehta
72eb501de3 fix(minor): breadcrumbs without app icon 2024-08-23 22:15:35 +05:30
Rushabh Mehta
b31cf8ba79 fix(style): sidebar overlay + polishes 2024-08-23 22:15:35 +05:30
Rushabh Mehta
087ee41ea1 feat(design): espresso style sidebar 2024-08-23 22:15:33 +05:30
Akhil Narang
a162e61e26
Merge pull request #27518 from akhilnarang/fixup-27495
fix(grid): `this` is defined here, meant to check if `this.grid_rows_by_docname` was defined
2024-08-23 16:21:29 +05:30
Akhil Narang
7828c51d90
fix(grid): this is defined here, meant to this if this.grid_rows_by_docname was defined
Followup to #27495

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-23 16:07:22 +05:30
Akhil Narang
09c28f1fd1
Merge pull request #27495 from akhilnarang/fix-grid-error
Each individual commit message has details
2024-08-23 14:48:13 +05:30
Ninad1306
827acd2975 fix: update child table value from the last doc 2024-08-23 12:47:08 +05:30
Akhil Narang
9ebda98c2d
Merge pull request #27494 from akhilnarang/fix-ratelimiter
fix(rate_limiter): we can't call str.join([]) with NoneTypes in the list
2024-08-23 10:46:33 +05:30
Raffael Meyer
f7fb0d7b35
fix(Workspace): translatable sidebar sections (#27281) 2024-08-22 14:03:15 +00:00
Akhil Narang
eb509e9ae8
fix(query_report): sentry FRAPPE-2TF
```
TypeError: Cannot read properties of undefined (reading 'map')
  at items.action(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1688:39)
  at $link(../../../../../apps/frappe/frappe/public/js/frappe/ui/page.js:506:11)
  at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
  at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
  at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)
```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 15:29:44 +05:30
Akhil Narang
678a404181
fix(table_multiselect): sentry FRAPPE-6QQ
```
TypeError: Cannot read properties of undefined (reading 'fields')
  at frappe.ui.form.ControlTableMultiSelectget_link_field(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table_multiselect.js:151:28)
  at frappe.ui.form.ControlTableMultiSelectset_formatted_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table_multiselect.js:124:27)
  at _a.set_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/data.js:247:8)
  at update_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/base_input.js:89:8)
  at _a.refresh_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/base_input.js:110:5)
  at frappe.ui.form.Controlrefresh(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/base_control.js:140:9)
  at frappe.ui.form.Layoutattach_doc_and_docfields(../../../../../apps/frappe/frappe/public/js/frappe/form/layout.js:490:59)
  at frappe.ui.form.Layoutrefresh(../../../../../apps/frappe/frappe/public/js/frappe/form/layout.js:344:8)
  at frappe.ui.form.Formrefresh_fields(../../../../../apps/frappe/frappe/public/js/frappe/form/form.js:679:15)
  at <anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/form/form.js:618:16)```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 15:27:40 +05:30
Akhil Narang
cfc8d7a010
fix(print_utils): simplify checks
Make it more readable, and prevent error

Sentry FRAPPE-4SQ

```
TypeError: Cannot read properties of undefined (reading 'default_letter_head')
  at frappe.ui.get_print_settings(../../../../../apps/frappe/frappe/public/js/frappe/form/print_utils.js:6:65)
  at items.action(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:1640:29)
  at $link(../../../../../apps/frappe/frappe/public/js/frappe/ui/page.js:506:11)
  at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
  at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
  at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 15:25:42 +05:30
Akhil Narang
7547937521
fix(query_report): sentry FRAPPE-6P0
TypeError: Cannot read properties of undefined (reading 'ref_doctype')
  at <anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/views/reports/query_report.js:417:58)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 15:25:16 +05:30
Sagar Vora
3eeeab72a2
Merge pull request #27346 from Ninad1306/before_mapping
fix: Before Mapping the Doc run `before_mapping` hook
2024-08-22 15:11:33 +05:30
Akhil Narang
00cfaa719e
fix(grid): check that this.grid_rows_by_docname isn't undefined
Sentry FRAPPE-60X

```
TypeError: this.grid_rows_by_docname is undefined
  at Grid.set_value(../../../../../apps/frappe/frappe/public/js/frappe/form/grid.js:793:41)
  at fn(../../../../../apps/frappe/frappe/public/js/frappe/form/form.js:317:40)
  at o/<(../../../../../apps/frappe/frappe/public/js/frappe/model/model.js:604:27)
```

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 14:51:28 +05:30
Akhil Narang
ad0a9106de
fix(rate_limiter): we can't call str.join([]) with NoneTypes in the list
Default to an empty string for `user_key`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 14:25:03 +05:30
Akhil Narang
43385060e1
Merge pull request #27491 from akhilnarang/revert-27386
revert: Merge pull request #27386 from GursheenK/grid-dependent-fields
2024-08-22 12:54:19 +05:30
Kunhi
2596fb7a2f
fix: Unable to save JSON field type in the customize form. (#27472)
* fix: Unable to save JSON field type in the customize form

* fix: run pre-commit

* precommit, fix

* precommit, linter issue
2024-08-22 12:49:01 +05:30
Akhil Narang
38f4871e23
Revert "Merge pull request #27386 from GursheenK/grid-dependent-fields"
This reverts commit ede8e06c03, reversing
changes made to 35fb0e2687.
2024-08-22 12:38:40 +05:30
Akhil Narang
273545dcae
Merge pull request #27474 from akhilnarang/notify-email-queue-suspended
chore(email_queue): nudge user to resume email queue if suspended and they are manually sending
2024-08-22 12:12:15 +05:30