Commit graph

52428 commits

Author SHA1 Message Date
sokumon
0ea047a776 fix: reroute portal users correctly 2025-12-19 20:34:28 +05:30
Akhil Narang
50c7a69697
Merge pull request #35333 from akhilnarang/reportview-qb
refactor(reportview): use query builder
2025-12-19 15:17:44 +05:30
Abdeali Chharchhodawala
a333241d95
fix: handle password feedback for common words and suggestions (#35156)
* fix: handle password feedback for common words and suggestions

* refactor: enhance password strength failure msg

* refactor: keep suggestion html align with title
2025-12-19 14:44:22 +05:30
MochaMind
0f278bb795
fix: sync translations from crowdin (#35286)
* fix: Hungarian translations

* fix: Slovenian translations

* fix: Swedish translations
2025-12-19 12:09:02 +05:30
Soham Kulkarni
0560eb92e6
Merge pull request #35330 from sokumon/rename-app-to-desk
chore: rename app to desk in get url methods
2025-12-19 10:33:56 +05:30
sokumon
dd2dc053ca chore: more renames to /desk 2025-12-18 20:45:04 +05:30
sokumon
0e3ff92996 chore: rename app to desk in get url methods 2025-12-18 19:56:04 +05:30
Soni Karm
61cd779872
fix: return empty string instead of undefined for URL and IBAN options (#34939) 2025-12-18 19:16:23 +05:30
Smit Vora
18b336a7be
fix: filter virtual fields from column picker (#35279) 2025-12-18 19:14:32 +05:30
Abdeali Chharchhodawala
d6c19e856d
refactor: proper msg for users with role (#35099)
* refactor: proper msg for users with role

* refactor: better UI for showing users with role

* refactor: filter with role name instead usernames

* chore: simplify user list display in permission manager
2025-12-18 18:45:01 +05:30
Akhil Narang
3a2dcaa2de
fix(with_comment_count): handle string values
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-18 18:11:02 +05:30
Ejaaz Khan
45c0696c57
Merge pull request #35245 from sokumon/form-sidebar
feat: init form sidebar redesign
2025-12-18 17:56:46 +05:30
Ejaaz Khan
fbe22accb1 feat: re-design attachment and image section 2025-12-18 17:44:27 +05:30
Akhil Narang
c0ebc96597
feat(qb_query): expose fields like db_query
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-18 17:26:52 +05:30
Akhil Narang
81f7a247f0
fix(query): track aliases for DynamicTableField as well
Child tables, links for example.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-18 17:26:52 +05:30
Akhil Narang
c90d3c5c20
refactor(reportview): use query builder
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-18 17:26:52 +05:30
Ankush Menat
c944981a3e
fix: Lock email queue before sending (#35334)
Avoids duplicate flushes.
2025-12-18 10:36:24 +00:00
Soham Kulkarni
8cf4af84f4
fix: always allow folders to be shown (#35325) 2025-12-18 14:41:07 +05:30
sokumon
709169a538 chore: clean desktop icon controller 2025-12-18 14:20:00 +05:30
rohitwaghchaure
6e944f8d55
Merge pull request #35307 from rohitwaghchaure/fixed-support-53592-4
fix: qty reset on selecting new item
2025-12-18 14:14:21 +05:30
Ejaaz Khan
424222dc81 fix: change url from app to desk 2025-12-18 14:01:52 +05:30
sokumon
c92a23d958 fix: always allow folders to be shown 2025-12-18 13:39:25 +05:30
Ejaaz Khan
fb0296f210 feat: redesign sidebar assignment 2025-12-18 12:57:54 +05:30
Soham Kulkarni
b559fee24e
fix: add default list.html for web view (#35300) 2025-12-18 12:16:05 +05:30
Ankush Menat
2505fa9c8c
Merge pull request #35308 from akhilnarang/qb-ifnull-optimization
perf: Split ifnull into two conditions
2025-12-18 10:31:30 +05:30
Ankush Menat
3177f6f5de
Merge pull request #35306 from frappe/fix/ss-cl
fix: don't auto enable create log for `All` and `Cron`
2025-12-18 10:30:31 +05:30
Ejaaz Khan
fc09193fbd feat: move like to sidebar 2025-12-18 00:53:01 +05:30
Sagar Vora
cc731988ce
Merge pull request #35303 from sagarvora/improve-perm-conds 2025-12-17 22:38:36 +05:30
Sagar Vora
d1ffd99fe8 fix(query): wrap CombinedRawCriterion in parentheses for correct precedence
Without proper grouping, OR conditions from shared docs could bypass WHERE filters:
  WHERE filter=X AND perm_cond OR shared_cond  -- shared_cond ignores filter!

With proper grouping:
  WHERE filter=X AND (perm_cond OR shared_cond)  -- correct behavior
2025-12-17 22:28:52 +05:30
Soham Kulkarni
f6521ded0b
Merge pull request #35314 from sokumon/sidebar-fixes
fix: dont show sidebar for setup wizard
2025-12-17 21:46:48 +05:30
sokumon
48e82d1d3e fix: dont show sidebar for setup wizard 2025-12-17 21:05:36 +05:30
Soham Kulkarni
b53cb2092c
Merge pull request #35311 from sokumon/rename-icons 2025-12-17 21:01:34 +05:30
sokumon
a8e24f9b10 chore: rename icons to match labels 2025-12-17 20:49:25 +05:30
Sagar Vora
b76706ac28 test: improve single query test 2025-12-17 19:30:32 +05:30
Sagar Vora
c7e9e01eb8 chore: fix linter issues 2025-12-17 19:04:00 +05:30
Sagar Vora
591d9a3535 fix: update logic for child tables 2025-12-17 19:03:15 +05:30
Ankush Menat
7be9fec036
perf: Split ifnull into two conditions
This produces better query plan with index intersection using 2
conditions instead of fulltable scan on dumb condition

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-12-17 17:47:08 +05:30
Rohit Waghchaure
a1cf7d0407 fix: qty reset on selecting new item 2025-12-17 17:44:05 +05:30
Hussain Nagaria
a9a4c79819 fix: don't auto enable create log for All and Cron 2025-12-17 17:35:48 +05:30
Ankush Menat
35dc034c7d
Merge pull request #35301 from ankush/sendmail_now
fix!: Sendmail shouldn't implicitly commit transaction
2025-12-17 16:47:18 +05:30
Ankush Menat
9979314b32 test: commit to trigger sendmail 2025-12-17 16:36:06 +05:30
Ankush Menat
5922f29806 chore: remove unncessary print 2025-12-17 16:30:46 +05:30
Sagar Vora
2b822cc63f refactor(query): simplify permission logic in add_permission_conditions
- Extract _raise_permission_error helper for reuse
- Simplify get_user_permission_conditions to return list[Criterion]
- Rewrite add_permission_conditions to match documented logic:
  - No role perms → apply only share permissions
  - Role perms → (owner OR user perms) AND query conditions
  - Shared docs OR other conditions when applicable
- Move apply_permissions check inside add_permission_conditions
2025-12-17 15:59:37 +05:30
Ankush Menat
71692b487b fix!: sendmail now=True after current transaction is commited
Sendmail implicitly commits transaction to update status.

Do it after the parent transaction is commited.

closes https://github.com/frappe/frappe/issues/33343
2025-12-17 15:53:16 +05:30
Ankush Menat
c4c18427b1
Merge pull request #35298 from ankush/password_strenth
fix(UX): Add description for password strength levels
2025-12-17 15:33:52 +05:30
Soham Kulkarni
06619819b5
Merge pull request #35297 from sokumon/quick-desktop-1 2025-12-17 15:19:34 +05:30
Ankush Menat
3f79f179f2 fix(UX): Add description for password strength levels
As per zxcvbn
2025-12-17 15:07:23 +05:30
sokumon
c4b2636c6a fix: add quick way to go back to desktop 2025-12-17 14:46:46 +05:30
Ankush Menat
7205e1e075
Merge pull request #35273 from akhilnarang/fix-shared-docs-query
fix(query): use `AND` if adding shared query
2025-12-17 14:35:58 +05:30
Ankush Menat
32d003c981
fix: Allow GIF uploads (#35295) 2025-12-17 08:48:31 +00:00