Commit graph

184 commits

Author SHA1 Message Date
Ahmad
bc675bab4a fix: Convert user to lower case before equating
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2021-12-13 15:54:14 +05:30
ahmadpak
22b89f2152 fix: method-get_doc_permissions 2021-12-13 15:53:44 +05:30
Suraj Shetty
4e6ea8fdbd fix: Docstring of has_permission & made error title translatable
- doctype -> DocType
- fixed other typo
2021-10-28 15:25:45 +05:30
Suraj Shetty
bf34de1d04 fix: Assume that child doc will have parent references 2021-10-28 15:06:38 +05:30
Suraj Shetty
7670c0430a fix: Simplify code and fix typo 2021-10-28 14:49:52 +05:30
Suraj Shetty
cb76118268 refactor: Check parent validity using parent meta 2021-10-28 13:41:12 +05:30
Suraj Shetty
9ce52fcd18 fix: Properly pass kwargs to has_permission of parent 2021-10-28 11:17:10 +05:30
Suraj Shetty
b68d6fe879 fix: typo 2021-10-27 13:57:44 +05:30
Suraj Shetty
9189c62437 fix: Pass parent_doctype while checking permission for child_table in db_query 2021-10-27 13:52:34 +05:30
Suraj Shetty
64822df6ff
Merge branch 'develop' into fix-has-permission-for-child-doc 2021-10-27 13:07:44 +05:30
Suraj Shetty
0f98b4d174 fix: Make parent_doctype mandatory while accessing child doctype 2021-10-27 12:59:42 +05:30
Suraj Shetty
494cc83bde fix: Return parent doc object for further permission check 2021-10-26 14:30:13 +05:30
mergify[bot]
8cbbda7ab7
Merge pull request #14441 from Aradhya-Tripathi/query-conversion
refactor: replacing raw SQL queries with frappe ORM
2021-10-22 09:00:42 +00:00
Gavin D'souza
cb66e6508d refactor(minor): Use pluck & better var naming 2021-10-22 14:17:52 +05:30
Suraj Shetty
cdde111021 fix: Re-arrange code
Return true if user is Admin before checking child table condition
2021-10-21 13:00:52 +05:30
Suraj Shetty
2a2421888f fix: Check parent permission while doing has_permission for child
- Since, permissions for child table is based on parent doctype
2021-10-21 12:21:51 +05:30
Sagar Vora
5c86dc80c7
fix: if_owner constraint being applied wrongly (#14471)
* fix: `if_owner` constraint being applied wrongly

* test: check if owner on `frappe.get_list`

Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com>
2021-10-19 15:03:17 +05:30
Aradhya-Tripathi
e01d97b8df refactor: replacing queries with frappe ORM 2021-10-14 01:16:46 +05:30
Aradhya-Tripathi
a621c4178c fix: fixing erroneous query conversions 2021-10-13 14:28:13 +05:30
Aradhya-Tripathi
7315076038 refactor: converted queries 2021-10-13 14:06:34 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Sagar Vora
e48d979c2b fix: improved execution logic for has_permission hook 2021-08-05 11:52:31 +05:30
Gavin D'souza
01d275f667 style: Format code for better readability
* Remove trailing whitespaces
* Format code to fit module conventions
* Add appropriate new lines between imports, classes, fn defs, etc
* Added comments, docstrings & module headers
2021-07-28 18:55:27 +05:30
Aradhya-Tripathi
84ff1d0af9 style: removed frappe.db.sql comments 2021-07-28 13:48:01 +05:30
Aradhya-Tripathi
538ef2168b fix: removed wrong queries 2021-07-24 22:58:12 +05:30
Aradhya-Tripathi
1204ae8ce4 fix: fixed spacing and ui tests 2021-07-23 10:45:54 +05:30
Aradhya-Tripathi
eb7e95ae26 refactor: using frappe orm 2021-07-21 19:19:06 +05:30
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
Gavin D'souza
793b5638d3 style: Fix E201, E202, E401, E701
reported by sider: https://sider.review/gh/repos/1864194/pulls/13344?statuses#issues
2021-05-27 12:48:01 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Ankush Menat
d8a4cf896b
perf: prefer set builder notation over constructor 2021-05-12 20:38:18 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
Deepesh Garg
a0fa3d0fd5 Merge branch 'develop' of https://github.com/frappe/frappe into if_owner_per_check_url 2021-04-12 21:24:19 +05:30
Suraj Shetty
f53c09ada2
Merge branch 'develop' into custom-user-type-feat 2021-04-05 19:01:42 +05:30
Rucha Mahabal
d2c81925b0 feat: DocShare with Submit 2021-04-04 16:14:07 +05:30
Deepesh Garg
bd8862f1a4 fix: Apply only if creator perm irrespective of user 2021-04-03 15:08:27 +05:30
Rohit Waghchaure
112784e7ae feat: custom user type with doctypes 2021-04-01 13:54:11 +05:30
shariquerik
7aa0628731 refactor: relocated get_doctype_roles function 2021-03-24 16:41:01 +05:30
marination
4887dd1d5a chore: Rename 'Exclude Descendants' to 'Hide Descendants'
- Rename 'Exclude Descendants' to 'Hide Descendants'
- Rename js trigger to 'toggle_hide_descendants'
2021-01-21 18:48:25 +05:30
marination
ac2ab580db feat: Hide Child Records for a Nested DocType via User Permissions 2021-01-13 23:55:18 +05:30
Saurabh
97b693c6b0
feat: Added permission to grant only Select access to document (#12063)
* feat: add permtype 'select' to DocPerm and CustomDocPerm

* feat: add 'select' perm in rights tupple

* feat: provisions to handle select permission

* feat: toggle href based on permissions

* feat: pass permission type explicitly while validating link in permission check

* fix: sider

* feat: added test cases to validate select perm

* feat: add method frappe.only_has_select_perm to explicitly check the select perm

* fix: if user only has select perm then do not show anchor tag for link fields

* fix: sider
2020-12-29 16:58:28 +05:30
prssanna
d9f1a85d00 fix: only encode if type is not str 2020-03-31 16:23:12 +05:30
prssanna
1bfb1a3d37 refactor(Dashboard): refactor dashboard permissions 2020-03-26 14:50:57 +05:30
Faris Ansari
7b9ee521ee fix: Use get_all instead of get_list 2019-09-11 15:58:36 +05:30
Faris Ansari
1eecc3dadb Revert "fix(pg test): get_list to get_all"
This reverts commit ef665c4c87.
2019-09-10 13:34:48 +05:30
Faris Ansari
ef665c4c87 fix(pg test): get_list to get_all 2019-09-10 11:45:45 +05:30
Suraj Shetty
10e20adcf3 fix: Allow user to export if user has permission to export own documents (#8172) 2019-08-19 11:55:29 +05:30
Mangesh-Khairnar
cc0ea13ec5
fix: has permission decorator 2019-05-23 13:04:59 +05:30
Suraj Shetty
1bcdc0b7cb fix(report): Allow report export only if user has export permission on ref doctype (#7458)
* fix: Allow export only if user has export permission on reference doctype

* fix: Show only custom "no permission" error

* fix: while saving employee user getting user permissions error
2019-05-15 11:59:13 +05:30
Mangesh-Khairnar
c23876198d fix: filter default docs from allowed docs 2019-04-22 13:54:05 +05:30