Commit graph

46441 commits

Author SHA1 Message Date
barredterra
12d18fa46c perf: undebounce autocomplete 2024-05-20 15:54:26 +02:00
Ankush Menat
025727674f
fix: scheduled type syncing (#26490)
- Scheduled Job sync when type was changed from scheduled to some other
  type didn't work.
- It updates on every save with message, bad DX IMO (can't save script
  and edit without dismissing)
- This was because of complex walrus which was triggering rest of code
  even when nothing changed. Maybe walrus opponents were onto something.
- `Truthy` couples two different operations and hence makes code
  complicated. In most cases where these checks are required it's not
  performance critical, we can do 1 more function call to avoid this
  coupling of change + actual value.
2024-05-20 13:43:20 +00:00
Rutwik Hiwalkar
cbbe57db24
fix: don't fail if input_wrapper is not defined while attaching markdown_editor (#26460)
Sentry FRAPPE-6K1
2024-05-20 11:48:58 +05:30
Corentin Flr
c4492cc378
refactor(code): Fix "copy text" button in dialogs and read_only_depends_on (#26467)
* refactor(code): Use get_status for "copy text" button

* refactor(code): Rename method to setup_copy_button

* refactor(code): Toggle "copy text" button on refresh

* refactor(code): Use get_model_value when copying to clipboard
2024-05-20 11:47:06 +05:30
Raino-Harvest
9ad376a579
fix: enable fetch_from for Time fieldtype (#25266) (#26471)
* fix: enable fetch_from for Time fieldtype

* Update frappe/public/js/frappe/form/script_manager.js

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-05-20 05:35:05 +00:00
Ernesto Ruiz
5ee0cac068
chore: Add translation functio to Email link text in Update login.html (#26472)
chore: Add translation functio to Email link text in Update login.html
2024-05-20 10:49:05 +05:30
Frappe PR Bot
65f0400596
chore: update POT file (#26479) 2024-05-20 10:27:38 +05:30
Raffael Meyer
d693b5b899
Merge pull request #26473 from barredterra/default-tree-view 2024-05-19 15:43:00 +02:00
Ankush Menat
445e1dbd6b
perf: num2words, babel, gettext, sentry imports (#26475)
num2words - 260KB - Used frequently on ERPNext sites.
babel - 1.1MB Gets imported because of dates, localization
sentry - 2.8MB should be loaded only if envvar is set
gettext - required for reading translations
2024-05-18 07:20:41 +00:00
barredterra
9a5d42e793 fix: default tree view 2024-05-17 20:33:32 +02:00
Nihantra C. Patel
c8a276b477
fix: overlap filter dialog box (#25772)
* fix: overlap filter dialog box

* fix: overlap filter dialog box - mousedown
2024-05-17 16:48:53 +05:30
Ankush Menat
3b53bb4f3f
fix: "Not assigned" filter (#26468)
This filter doesn't work because `"[]"` is empty assignment list but
truthy value.
2024-05-17 10:14:16 +00:00
Corentin Flr
17a0c9a211
fix(modal): Stack modals when minimized (#26458)
* fix(modal): Fix backdrop for multiple minimized modals

* feat(modal): Visually stack minimized modals
2024-05-17 15:36:20 +05:30
Ankush Menat
513957ee40
Merge pull request #26457 from ankush/ci_skip
fix(DX): Don't run CI if there are no tests
2024-05-17 13:17:16 +05:30
Ankush Menat
1b0ad4137a fix(DX): Don't run CI if there are no tests
New apps keep burning CI just to install the app and run nothing.
This adds a small check before install to avoid unnecessary CI runs.
2024-05-17 13:05:06 +05:30
Ankush Menat
afed21e29f fix: dont translate syntax error messages
closes https://github.com/frappe/frappe/issues/26443
2024-05-17 13:05:06 +05:30
Ankush Menat
a1bd916cfa
docs: typo in db.delete (#26464) 2024-05-17 07:32:23 +00:00
Nihantra C. Patel
c353aae012
fix: condition of event participants (#26300) 2024-05-16 18:04:18 +05:30
Ankush Menat
803f7b3990
fix: Don't fiddle with child table indexes (#26450)
- Link fields when referred to increase idx
- This is used in search.py to rank most referred documents higher than
- This doesn't make for child table links at all.
2024-05-16 17:09:56 +05:30
Akhil Narang
b2e3f3dcdd
Merge pull request #26446 from akhilnarang/fix-FRAPPE-698
fix(grid_row): don't crash when undefined
2024-05-16 13:10:38 +05:30
Akhil Narang
0892609710
fix(grid_row): don't crash when undefined
TypeError: Cannot read properties of undefined (reading 'fields')
  at frappe.ui.form.ControlTable.get_field(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table.js:120:18)
  at HTMLInputElement.<anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table.js:46:13)
  at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
  at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
  at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)

Sentry FRAPPE-698

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-16 12:56:02 +05:30
Maxim Sysoev
557293adfe
feat: show link field title in sidebar filters if set (#26417)
* feat: In sidebar filter link field show Title of Field if set (#26413)

* fix: test_list_view_child_table_filter_with_created_by_filter

* fix tests

* fix: formatting

* fix: formatting

* refactor: cleanup logic slightly, reduce code repetition

Respect value of show_title_field_in_link

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2024-05-15 12:48:05 +00:00
Akhil Narang
3a4dd9a671
Merge pull request #26183 from vmatt/data_import_delimiter
feat(Data Import): custom csv delimiters, UTF-8 BOM handling
2024-05-15 16:45:31 +05:30
Akhil Narang
9986ea8171
chore: update labels and a comment
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-15 16:29:55 +05:30
Raffael Meyer
5cb9f04bca
Merge pull request #26429 from cogk/fix-dont-add-decontextualized-translations 2024-05-15 10:34:50 +02:00
Akhil Narang
4298fc0493
Merge pull request #26434 from akhilnarang/fix-multiselectdialog
fix: preserve checked items after a search
2024-05-15 13:12:33 +05:30
Akhil Narang
19f01c990c
fix: preserve checked items after a search
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-15 12:53:35 +05:30
Ankush Menat
6fb6c4035c
Merge pull request #26433 from ankush/query_optimzier
feat(recorder): Suggest index for optimizing query
2024-05-14 19:08:41 +05:30
Ankush Menat
b169f8780a feat: Add identified index from UI 2024-05-14 18:54:38 +05:30
Ankush Menat
4e251e9b0b feat(recorder): Suggest query index 2024-05-14 16:05:58 +05:30
Ashish Shah
fdc2bd8fe6
feat: functionality to assign users by user group (#26044)
* feat: functionality to assign users by user group

* fix: incorporate four comments from review by ankush

* fix: linting issues
2024-05-14 15:35:33 +05:30
Corentin Flr
ace4ea328b
fix(translate)!: Don't add decontextualized translations 2024-05-14 11:00:46 +02:00
Ankush Menat
49f8f4fe45 fix(UX): colour duration to highlight bad rows 2024-05-14 12:22:03 +05:30
Ankush Menat
bbf18d39cc
Merge pull request #26369 from gavindsouza/refactor-scheduled-server_script
refactor!: Server Script (Scheduler Event) & misc APIs
2024-05-13 20:25:29 +05:30
gavin
665a18b063
fix: Implement Truthy.__eq __
Implement equality check, compare with True rather than self for a Truthy instance

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-05-13 14:17:40 +02:00
Ankush Menat
16c8a30861 fix: Avoid erasing recorder during clear_cache
This reverts commit eadfe86fd834f43925956fa6d759127aaf363441.
2024-05-13 17:41:34 +05:30
Ankush Menat
aba8d4e5b5 fix(DX): fix up column widths in recorder grid
Query is most important yet it was only taking 2 cols, unreadable.
2024-05-13 17:38:18 +05:30
Ankush Menat
65debdb137
test: Drop threshold for JS builds to be 1% (3.3 KB) (#26426)
Multiple recent cases of unknowingly pushing more JS in `/app`'s JS.
2024-05-13 10:08:14 +00:00
Gavin D'souza
9c20649022
Revert "fix: ServerScript.safe_exec as a doc method"
This reverts commit cf2a3e926e.
2024-05-13 11:31:19 +02:00
Frappe PR Bot
78321360a6
chore: update POT file (#26325) 2024-05-13 08:23:47 +00:00
paurosello
c19e6a8732
feat: pre-login hook (#26394) 2024-05-13 13:41:06 +05:30
Ankush Menat
49fb60a0dd
Merge pull request #26360 from rutwikhdev/upgrade-fullcalendar
feat: upgrade fullcalendar
2024-05-13 13:38:34 +05:30
Corentin Flr
016e41c29a
fix(TextEditor): Show editable rich editor in grid row (#26366) 2024-05-13 13:38:11 +05:30
Smit Vora
4522d10afb
fix(test records): rollback only the test record that exists (#26415) 2024-05-13 13:34:23 +05:30
Raffael Meyer
da740081c6
fix: make rename_doc work pre_model_sync (#26419) 2024-05-13 13:32:23 +05:30
Rutwik Hiwalkar
35f0d92e40
Merge pull request #26328 from rutwikhdev/fix-empty-tree-view
fix: new and add child button for empty tree doctype
2024-05-13 12:48:40 +05:30
Rutwik Hiwalkar
b8f7c4c11f chore: show doctype name as root node in treeview 2024-05-13 11:31:19 +05:30
Rutwik Hiwalkar
def9630e1c chore: move fullcalendar libs to a separate bundle 2024-05-11 13:51:42 +05:30
Ankush Menat
c3c579bdc5 test: update asset size values 2024-05-11 13:51:42 +05:30
Rutwik Hiwalkar
e520a39da8 fix: misc fixes for event datetime and styling 2024-05-11 13:23:27 +05:30