Ankush Menat
4f70200bd5
chore: track update actions per doctype
...
[skip ci]
2023-06-22 12:10:43 +05:30
Ankush Menat
69220a9a9e
fix(dx): Reset module onboarding progress
...
Useful while working on form tours to quickly reset progress
[skip ci]
2023-06-22 11:53:22 +05:30
Shariq Ansari
b0793ebb7f
Merge branch 'develop' into re-delete-after-deleting-dependent-doc
2023-06-19 11:39:55 +05:30
Ankush Menat
ae0edd85fe
perf: Faster report exporting logic ( #21415 )
...
* perf: Faster report exports to Excel
Try exporting report with 100K rows, most likely it fails or takes a really long time.
Root causes:
- visible_idx was a list, lookups are SLOW AF when lists grow to 100k+
- visible_idx check is not required when I am exporting entire report.
Test with 85,000 rows.
| | Before | After | Improvement |
| --- | --- | --- | --- |
| Export | 25.99 | 0.77 | ~33x faster |
2023-06-17 21:07:59 +05:30
Shariq Ansari
51fe34006b
Merge branch 'develop' into re-delete-after-deleting-dependent-doc
2023-06-16 16:59:59 +05:30
gavin
09501da12f
fix(meta): Revert to using conf over _dev_server for cache ( #21391 )
2023-06-15 17:45:10 +05:30
Shariq Ansari
f679930790
revert: last commit
2023-06-15 14:07:53 +05:30
Shariq Ansari
4ec2d5f00d
fix: commit after successfull deletion of all tasks
2023-06-15 12:48:55 +05:30
Ankush Menat
fcce713b14
perf: index for_user in Notification log ( #21379 )
...
Missed out before somehow: 3a5a45d8af
2023-06-14 21:24:54 +05:30
Shariq Ansari
cc1e89c2f6
Merge branch 'develop' into re-delete-after-deleting-dependent-doc
2023-06-14 12:18:26 +05:30
Shariq Ansari
fd65fe8625
fix: clear throw message
2023-06-14 12:11:21 +05:30
Shariq Ansari
d1aea9981a
fix: re-delete doc if dependent doc is deleted
2023-06-14 12:10:52 +05:30
Ankush Menat
039be73af4
refactor: Consider singles for dynamic set_value usage ( #21367 )
...
Found all usage using this semgrep rule:
```yaml
- pattern: frappe.db.set_value($DOCTYPE, ...)
- pattern-not: frappe.db.set_value("$STR", ...)
```
2023-06-14 10:46:25 +05:30
Shariq Ansari
9e0ed9d2a2
fix: convert string to int
2023-06-13 16:23:39 +05:30
Shariq Ansari
0e962078fe
revert: temp fix to load communications
2023-06-13 16:20:07 +05:30
Ankush Menat
22149b5bff
chore: increase communication limit
...
This needs better fix, added temporarily
2023-06-13 12:12:21 +05:30
Ankush Menat
8a30667a97
fix: Fetch non-cached version of Meta on Customize Form. ( #21269 )
...
* fix: Replace meta cache when uncached meta is requested
* fix: use meta from DB on customize form
* refactor: make cached kw only, use _dev_server
2023-06-12 14:59:42 +05:30
Shariq Ansari
428eaf6a16
chore: linter fix
2023-06-08 16:52:24 +05:30
Vimal Patel
48b9128904
fix: remove redundant prepare_filter method
2023-06-08 11:26:22 +01:00
Vimal Patel
0d729e5e47
fix: New Dashboard Chart throws TypeError: format requires a mapping
...
closes #21250
backport version-14-hotfix
2023-06-08 11:18:44 +01:00
Vimal Patel
70944cabb3
fix: New Dashboard Chart throws TypeError: format requires a mapping
...
closes #21250
2023-06-08 11:11:33 +01:00
Ritwik Puri
3446ca9155
fix: consider default value for content in update_workspace2 patch ( #21258 )
2023-06-08 13:14:37 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache ( #21282 )
2023-06-08 11:47:17 +05:30
Ankush Menat
34ee6a1677
fix: declare the function ( #21261 )
...
[skip ci]
2023-06-06 16:11:02 +05:30
Ankush Menat
be1da0dd00
chore: remove duplicate cache clearing
2023-06-03 22:53:10 +05:30
Sagar Vora
9f5a994f70
fix!: improved filter validation in Engine.get_query
2023-05-31 14:16:52 +05:30
Ankush Menat
77db84a2be
fix: reset tour
...
[skip ci]
2023-05-30 15:39:14 +05:30
Shariq Ansari
474186c264
fix: only show public and user's private blocks in dropdown
2023-05-30 12:08:43 +05:30
Shariq Ansari
07781eefe9
fix: create private custom html block
2023-05-30 12:07:43 +05:30
Shariq Ansari
d00e41d725
refactor: rearranged code
2023-05-29 16:21:00 +05:30
Shariq Ansari
7776f85cb0
Merge branch 'develop' into custom-html-block-global-css
2023-05-29 16:02:24 +05:30
Shariq Ansari
2a97e3b19f
fix: removed html message since we no longer have no ristrictions
2023-05-29 15:59:41 +05:30
Shariq Ansari
62565b5191
fix: made a util to create shadow element
2023-05-29 15:57:58 +05:30
Shariq Ansari
08f0f8beb1
fix: make desk css available i shadow html
2023-05-29 15:56:38 +05:30
Ankush Menat
2ed2f8747d
chore: track doc creation
...
This is alternate to "Activation" level that already exists, activation
level will be phased out over time.
2023-05-29 13:34:24 +05:30
Shariq Ansari
0c90d1748f
fix: go back instead of opening select_doctype dialog
2023-05-26 21:12:05 +05:30
Shariq Ansari
2af7e74eb9
fix: made select_doctype accessable gobally which can be used to change doctype from form-builder
2023-05-26 20:41:28 +05:30
Shariq Ansari
17f25aab93
fix: form-builder/new-doctype opens separate dialog
...
refactored form_builder.js
2023-05-26 20:38:43 +05:30
Ankush Menat
7c82876305
fix: patch existing users/site
2023-05-25 15:25:57 +05:30
Ankush Menat
81c103a741
refactor: remove form tour settings
2023-05-25 15:04:38 +05:30
Maharshi Patel
639de716d5
Merge branch 'develop' into onboarding-tour
2023-05-25 12:30:04 +05:30
Maharshi Patel
40b78692fe
chore: fix linters
...
missing translate function and newline at end of file.
2023-05-25 11:54:37 +05:30
Maharshi Patel
32396c7fe5
fix: guess module if not set in form tour
...
if unable to guess save in Desk module.
2023-05-25 11:42:24 +05:30
Ankush Menat
4ab98b998d
fix: setup wizard recursion in routing ( #21101 )
...
- setup wizard shows slide from index in route
- if you visit `/app/setup-wizard` then index in route is `undefined`
- because of hacky code we do `id + ''` so `undefined` becomes `"undefined"` a truthy value
The recursion of undefined > 0 > undefined > 0 continues until browser
intervenes and stops further routing.
2023-05-24 17:43:51 +05:30
Ankush Menat
4376ebb3dc
refactor: replace todo tour with user tour
...
adding more users is most likely to improve adoption. so better place to
show tours is user doctype?
2023-05-24 13:24:09 +05:30
Ankush Menat
657c2ba3b2
fix: clear cached onboarding status on update
2023-05-24 12:48:07 +05:30
Ankush Menat
09ce5f7a94
chore: fix main workspace tour copy
...
- fix copy
- make it run on any workspace
2023-05-24 12:44:27 +05:30
Ankush Menat
8d63e2f183
fix: clear boot cache on updating form tour
2023-05-24 12:31:51 +05:30
Ankush Menat
78dc9fc9ac
fix: fieldtype json -> text
2023-05-24 12:06:04 +05:30
Maharshi Patel
19c4b396ae
chore: fix linters
2023-05-24 11:44:36 +05:30