Shariq Ansari
f679930790
revert: last commit
2023-06-15 14:07:53 +05:30
Shariq Ansari
4ec2d5f00d
fix: commit after successfull deletion of all tasks
2023-06-15 12:48:55 +05:30
Shariq Ansari
fd65fe8625
fix: clear throw message
2023-06-14 12:11:21 +05:30
Shariq Ansari
d1aea9981a
fix: re-delete doc if dependent doc is deleted
2023-06-14 12:10:52 +05:30
ruthra kumar
6b2bcd5b07
fix: using 'Equals' and 'Is' on multiselect throws error
2023-05-18 16:48:19 +05:30
Gavin D'souza
52973ed85d
fix(reportview): Use get_permitted_fields for resource API
2023-04-22 14:59:33 +05:30
Shariq Ansari
6b2b161876
fix: filter with capitalized operator was getting bypassed
2023-04-13 14:11:52 +05:30
Gavin D'souza
6b0e4695a8
Merge branch 'develop' into permlevel-apis
2023-01-25 12:08:47 +05:30
Gavin D'souza
e75bfd0e73
refactor: Split objects just once
...
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2023-01-25 10:45:30 +05:30
Gavin D'souza
d357af1533
refactor: Add a maxsplit limit to string splits
2023-01-24 19:22:51 +05:30
Gavin D'souza
9efe84a644
fix(reportview): Remove aggregate_on_field added in fields
...
Essentially reverts changes added via
https://github.com/frappe/frappe/pull/14424 but works just the same
without the additional column :thonk:
The added column's data in mariadb was essentially garbage data. Wasn't
meaningful from what I could tell - couldn't play well with postgres
either
2023-01-20 19:26:56 +05:30
Gavin D'souza
9012b95a9a
fix(postgres): group_by in reportview, tests
...
Add approporiate group_by, order_by clauses in reportview and tests for
featureset compatibility with postgres
2023-01-11 12:42:45 +05:30
Daizy Modi
d6c6df74db
fix: use doc.has_permission instead of frappe.has_permission ( #19541 )
2023-01-09 19:03:45 +05:30
jiangying
8273c9f244
chore: fix comment typo in frappe/desk/reportview.py ( #19517 )
2023-01-08 20:04:14 +05:30
barredterra
b1f6152f38
fix: pop from form_params
2022-11-28 12:19:14 +01:00
barredterra
ee18984e1f
refactor: export_query
2022-11-28 12:15:57 +01:00
barredterra
5008bc0b09
fix: fieldname referenced before assignment
2022-11-28 12:15:30 +01:00
barredterra
d70e5e73e2
refactor: extract common methods
2022-11-26 20:00:58 +01:00
Raffael Meyer
cca25174ab
Merge branch 'develop' into csv-params
2022-11-14 12:38:51 +01:00
Ankush Menat
52ee21270e
refactor: validation of permlevel
2022-11-10 14:15:24 +05:30
AMS Fauzi
ab35ec8f48
fix: reportview permlevel bug ( #18822 )
2022-11-10 13:05:10 +05:30
barredterra
a232e7f0c1
fix: don't parse CSV params for Excel
2022-10-29 18:05:52 +02:00
barredterra
26534118e4
feat: CSV params for report view
2022-10-28 19:54:03 +02:00
Ankush Menat
e8efd64dbc
refactor!: better API contracts for virtual doctype
...
Current APIs implement class methods as instance method, which is
problamamtic while implementing methods. E.g. If load_from_db doesn't
like empty docname then all class method will stop working.
This change while breaking is essential for usability of virtual
doctype.
2022-07-22 14:26:02 +05:30
Ankush Menat
e88bc35cae
refactor: move is_virtual_doctype to relevant file
2022-07-22 14:25:48 +05:30
Shridhar
b2203893a1
fix: do not fetch comments from parent for virtual doctype
2022-07-22 14:25:48 +05:30
gavin
486f26a1ff
Merge branch 'develop' into mariadb-client-refactor
2022-07-20 12:41:46 +05:30
Suraj Shetty
99c6990761
fix: Allow fields to have "*" without array
2022-07-20 11:30:57 +05:30
Gavin D'souza
71b5c77e6e
Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor
2022-07-05 14:55:02 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features ( #17367 )
...
refactor: clean up code to py39+ supported syntax
- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes
Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Gavin D'souza
cf699fe40b
Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor
2022-06-29 13:49:18 +05:30
Ankush Menat
c8ac3f922e
Revert "fix: extra column in excel after exporting report with group by ( #17126 )"
...
This reverts commit 971b8160a3
2022-06-28 18:40:27 +05:30
gavin
bb0283a1cf
Merge branch 'develop' into mariadb-client-refactor
2022-06-28 14:57:21 +05:30
Shariq Ansari
971b8160a3
fix: extra column in excel after exporting report with group by ( #17126 )
...
Co-authored-by: gavin <gavin18d@gmail.com>
2022-06-28 12:39:45 +05:30
Gavin D'souza
48243346e3
fix(get_contact_list): Don't pass conditions as query value
...
* Conditions passed are not valid prepared statement values. They
can be passed as string substitution since they're generated by DBQuery.
* Added typing hints & other improvements
* Removed seemingly pointless try-except block
2022-06-20 13:10:03 +05:30
Gavin D'souza
9c02205fc1
perf: Cache is_virtual_doctype with maxsize 128
2022-06-07 18:36:38 +05:30
Faris Ansari
96b30e714c
feat: table_field.fieldname field syntax for db_query
2022-05-27 16:04:22 +05:30
Suraj Shetty
1469339335
revert: "refactor: new query engine in get_count()"
...
Co-Authored-By: Gavin Dsouza <gavin18d@gmail.com>
2022-05-17 13:30:36 +05:30
saxenabhishek
d39e6a7890
refactor: new query engine in get_count()
2022-04-28 17:10:31 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black ( #16453 )
...
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
barredterra
745297a49d
refactor: a not in b
...
Search: if not ([\w\d]*?) in ([\w\d]*?)
Replace: if $1 not in $2
2022-02-21 19:54:34 +01:00
Sagar Vora
976c3bedc3
fix: use correct indicator
2022-02-09 15:45:30 +05:30
Sagar Vora
d8fc39659a
fix: docstring
2022-02-09 12:37:41 +05:30
Sagar Vora
a49a07e419
fix: sider issues
2022-02-09 12:35:44 +05:30
Sagar Vora
f0a10efa62
fix: improved validations
2022-02-09 12:22:54 +05:30
Daizy
ddd45a71bc
feat: Allow users to customize their own reports
2022-02-09 11:07:04 +05:30
phot0n
b31f3c24f6
refactor: remove parent, parenttype, parentfield, idx columns from non-child table doctypes
...
* feat: add parent, parenttype, idx, parentfield columns to doctypes when transitioning from normal -> child table
* fix: remove parent, parenttype, parentfield, idx from DocType DocType
2022-02-07 15:12:37 +05:30
mergify[bot]
3da7a5c1ff
Merge pull request #15679 from alyf-de/translate-report-export
...
feat: translate column names in export of report
2022-02-02 11:35:58 +00:00
Raffael Meyer
07ae6855c3
fix: use format string
...
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
2022-01-28 12:01:38 +01:00
hrwx
dbb609bd0b
chore: review changes
2022-01-26 09:12:42 +00:00
