Shariq Ansari
ea20cdd4d5
Merge pull request #20971 from shariquerik/maintain-frappe-current-route
...
fix: maintain frappe.router.current_router
2023-05-12 12:59:20 +05:30
Shariq Ansari
fd493e3f86
Merge branch 'develop' into maintain-frappe-current-route
2023-05-12 12:27:26 +05:30
Shariq Ansari
7bd810950e
fix: maintain frappe.router.current_router
2023-05-12 12:23:46 +05:30
Faris Ansari
2df7fdd79e
Merge pull request #20908 from netchampfaris/qb-getquery-child-fields-syntax-sugar
2023-05-11 12:02:30 +05:30
Leonard Goertz
33246bbb8f
fix: call make_columns before update_order ( #20710 )
2023-05-11 09:20:47 +05:30
Ritwik Puri
da5f642d4c
chore: make skipped and traceback fields read_only in patch log & newline after traceback for better readability while skipping failing patches ( #20961 )
2023-05-10 19:36:58 +05:30
Anand Baburajan
2ca07df530
Merge branch 'develop' into custom_report_export_and_auto_email
2023-05-10 19:20:11 +05:30
anandbaburajan
348f852792
fix: custom filters while exporting and creating new auto email reports
2023-05-10 19:08:01 +05:30
Shariq Ansari
cf950b885d
Merge pull request #20880 from shariquerik/workflow-builder
2023-05-10 18:47:55 +05:30
Shadrak Gurupnor
d9b2d23ec3
feat: track skipped patch with traceback ( #20931 )
...
* feat: track skipped patch with traceback
* fix: dump all the patches in patch log
* fix: check non-skipped patches
* fix: print traceback if failed && reload patch_log before migrate
* chore: dont force patch log reload
* chore: remove unnecessary checks
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-05-10 18:44:40 +05:30
Shariq Ansari
6dfcd529d1
fix: max width for state and text center
2023-05-10 17:57:25 +05:30
Shariq Ansari
3736aaa26f
chore: linter fix
2023-05-10 17:36:57 +05:30
Shariq Ansari
93f9492ad7
Merge branch 'develop' into workflow-builder
2023-05-10 17:30:26 +05:30
Shariq Ansari
ecc431875e
chore: updated banner text
2023-05-10 17:21:39 +05:30
Shariq Ansari
c3e6d7c620
fix: changed state shape
...
default fitview
2023-05-10 15:14:52 +05:30
Shariq Ansari
ab5570f447
chore: removed try new workflow builder button
2023-05-10 14:42:35 +05:30
Shariq Ansari
35f1c0213d
fix: dont save if state or transition is empty and is_active is set
2023-05-10 14:41:15 +05:30
Shariq Ansari
90d03d96fa
Merge pull request #20950 from shariquerik/avoid-internal-arrays-fix
2023-05-10 14:08:27 +05:30
Smit Vora
9f35d0e894
fix: don't use default filters for auto-email report ( #20876 )
2023-05-10 13:12:05 +05:30
Ankush Menat
ef6f4b5956
refactor!: Use job_id for bg job deduplication ( #20951 )
2023-05-10 12:45:05 +05:30
Shariq Ansari
46c37c2a5f
fix: avoid internal arrays in get_all_docs
2023-05-10 11:47:33 +05:30
Ankush Menat
f842c85419
chore: log skipped scheduling events
...
Rare but Useful for debugging
2023-05-10 10:58:07 +05:30
Shariq Ansari
a6ce4736f7
Merge branch 'develop' into workflow-builder
2023-05-10 10:02:44 +05:30
Ritwik Puri
66716fbe12
fix: use smaller font only if the report doesnt have a standard print format ( #20878 )
2023-05-09 19:34:50 +05:30
Ankush Menat
5f623c9148
Merge pull request #20937 from ankush/scheduled_job_dedup
...
perf: Faster scheduled job deduplication
2023-05-09 19:11:22 +05:30
Ritwik Puri
ab6e74e37d
fix: strip comma, space from recipients before sending email for auto repeat ( #20940 )
2023-05-09 18:29:13 +05:30
Ankush Menat
ecce4ba5a7
test: deduplication with unique job id
2023-05-09 14:23:07 +05:30
Ankush Menat
bc3871b657
refactor: standardize assigning job_id
2023-05-09 14:23:04 +05:30
Ankush Menat
e0f465ed9c
test: expected failing test
2023-05-09 12:42:25 +05:30
Faris Ansari
7e7b1e024a
test: for child query in qb.get_query
2023-05-08 18:55:11 +05:30
Faris Ansari
c4bb732eaa
fix: use dict syntax instead of string
2023-05-08 18:55:11 +05:30
Faris Ansari
41d7563aff
feat: child_field[] syntax sugar for qb
...
- fetch child table rows in qb.get_query
- runs one query each for each child field
2023-05-08 18:55:11 +05:30
Ankush Menat
4bd02a4ed1
perf: Faster scheduled job deduplication
...
O(n) to O(1) dedup by specifying unique IDs on scheduled RQ jobs.
2023-05-08 18:28:09 +05:30
Ankush Menat
cf53b1a58e
chore: set_value docstring
...
[skip ci]
2023-05-08 16:23:29 +05:30
Shariq Ansari
860f17edea
Merge pull request #20932 from shariquerik/workspace-listview-title-fix
2023-05-08 12:13:23 +05:30
Shariq Ansari
c0e56c204f
Merge branch 'develop' into workspace-listview-title-fix
2023-05-08 12:06:39 +05:30
Shariq Ansari
4c14e6835d
fix: escape html from listview row title
2023-05-08 12:05:22 +05:30
Shariq Ansari
f1f23f4116
fix: escape html from workspace title
2023-05-08 12:04:44 +05:30
Ankush Menat
eb8da5fd59
fix!: Correct resolution order for template page ( #20927 )
...
Current resolution is confusing mess:
1. Evaluation is done in order of installed app, first install wins
2. Except frappe, frappe is treated as lowest priority.
Following same principle of "last write wins" everywhere similar to
previous PRs:
- https://github.com/frappe/frappe/pull/17869
- https://github.com/frappe/frappe/pull/20648
- https://github.com/frappe/frappe/pull/19653
Closes https://github.com/frappe/frappe/issues/20377
2023-05-07 13:19:23 +05:30
Ritwik Puri
4b103888a7
chore: remove default None from address_dict param
2023-05-06 22:48:19 +05:30
Ritwik Puri
88bdefcc30
fix: type hints for get_address_display ( #20923 )
2023-05-06 21:36:07 +05:30
Ankush Menat
715dc569e9
fix: reload communication before re-save ( #20914 )
2023-05-06 15:51:07 +05:30
Raffael Meyer
bb14fe61c8
fix: remove wrong translations ( #20917 )
2023-05-06 02:00:36 +05:30
Raffael Meyer
504b33ceb8
fix: translate lowercase operators to german ( #20912 )
2023-05-05 18:22:59 +05:30
Ritwik Puri
4418aa3129
chore: remove unscrubbing while displaying link field filters
2023-05-05 16:56:08 +05:30
Raffael Meyer
4af75f2462
fix: translation files ( #20750 )
...
- remove leading "DocType: XXX"
- remove leading path and line number
- add trailing comma (three columns total)
2023-05-05 15:58:56 +05:30
Ankush Menat
cbbb6a7d85
chore: track onboarding progress
...
Easy self-onboarding has been hardest to get right in complex business
apps, even though we have worked on this for long long time we have no
clear idea on how well it works, or if it's severly lacking.
We want to improve this by first understanding how efficient current
system is.
This PR adds basic telemetry for which steps are being completed, which
are skipped and what onboarding group is dismissed completely.
2023-05-05 12:54:14 +05:30
Shariq Ansari
fa80cfd2cf
Merge pull request #20853 from rtdany10/bulk-print-changes
2023-05-05 11:27:26 +05:30
William Luke
e0ed7d3b97
fix(oauth): add exp to idToken ( #20694 )
2023-05-05 01:19:03 +05:30
Ritwik Puri
f5ba787f4b
Merge pull request #20856 from resilient-tech/perf-private-file
2023-05-05 00:46:16 +05:30