Commit graph

42389 commits

Author SHA1 Message Date
Gavin D'souza
acb0dc38ae fix: Check if attr exists before checking permlevel 2023-01-24 12:17:57 +05:30
gavin
6f04951801
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-24 11:57:08 +05:30
dependabot[bot]
788d512a69
chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (#19737)
Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-24 11:33:00 +05:30
Shariq Ansari
af671fc22b
Merge pull request #19710 from shariquerik/pass-strength-progress-bar 2023-01-24 11:31:26 +05:30
Gavin D'souza
81d6b282a3 chore: Remove errprint triggered by passing Query object to db.sql 2023-01-24 11:26:31 +05:30
Shariq Ansari
56c822b274
Merge pull request #19740 from shariquerik/ldap-fix
Fixes https://github.com/frappe/frappe/issues/19702
2023-01-24 11:25:43 +05:30
Shariq Ansari
229ca404ae fix: LDAP - default user role mandatory logic broken 2023-01-24 11:22:05 +05:30
Shariq Ansari
4afd96baae
Merge pull request #19731 from shariquerik/child-table-fields-in-dialog-readonly-fix
fix: child table readonly field in dialog is not readonly
2023-01-24 09:55:25 +05:30
Sagar Vora
71420eb4e6
refactor: simplified get_controller (#19684)
* refactor: simplified `get_controller`

* chore: more refactor, better error if not subclass

* chore: more correct condition

* refactor: `class_` > `_class`

* chore: use `Meta` instead of DB calls

* chore: `_get_controller` => `import_controller`

* style: remove else block
2023-01-24 01:27:26 +05:30
barredterra
2a84b18d13 feat: load address and contact display
- Handle missing permissions
- Split into smaller functions
2023-01-23 18:59:16 +01:00
Riandrys Góngora Román
ba438fe4a6 test: update docfield property using set_df_property in child table
add UI test with cypress on form.js
update docfield property using set_df_property in child table
2023-01-23 11:26:07 -05:00
Riandrys Góngora Román
ce4450cd95 fix(child table): Update docfield property using set_df_property
update docfield property using set_df_property
set_df_property doesn't work when it's call it in form_render event of child table
2023-01-23 11:26:07 -05:00
Ankush Menat
30e9fc4cb6 chore: remove unnessary todo comment 2023-01-23 20:05:28 +05:30
Shariq Ansari
3d280a2d3f fix: child table readonly field in dialog is not readonly 2023-01-23 18:17:21 +05:30
Ankush Menat
3821167f66
Merge pull request #19725 from ankush/migration_fixes_moar
fix: misc migration issues
2023-01-23 16:44:19 +05:30
Ankush Menat
391edba10a fix(UX): better error message for dead link fields
Link fields referring to non-existing doctypes are possible when

- Removing customizations.
- Removing app which added a custom field but didn't clean up after
  itself.

[skip ci]
2023-01-23 16:43:57 +05:30
Shariq Ansari
bbcdd3102e
Merge branch 'develop' into pass-strength-progress-bar 2023-01-23 16:29:47 +05:30
Shariq Ansari
6c1624d41e feat: toggle password icon 2023-01-23 16:23:44 +05:30
Ankush Menat
224ab37924 fix: Dont apply non-standard perms in migrate
ref: agent-job/b8bca95f25
2023-01-23 15:07:13 +05:30
Ankush Menat
87561940a4
feat: Interactively add a new patch (#19722) 2023-01-23 15:04:43 +05:30
Anand Baburajan
6554919f1e
fix: improve invalid naming series message (#19711)
* fix: show the invalid naming series in special chars error msg

* chore: translations

[skip ci]
2023-01-23 15:00:04 +05:30
Richard Case
0e6e2609b5 fix: unhelpful error message (#19666) 2023-01-23 14:48:27 +05:30
Ritwik Puri
65a76cc0f3
Merge pull request #19083 from Aradhya-Tripathi/refactor-bg-submissions
fix: misc fixes (background submission)
2023-01-23 13:18:18 +05:30
phot0n
4144c45b2a fix: make job_id link field and allow all (if owner) to read their submission queues 2023-01-23 13:13:27 +05:30
phot0n
230d36e789 chore: revert things related to workflow 2023-01-23 12:59:18 +05:30
phot0n
99fbe969e8 Revert "fix: workflow mechanics for submission queue (start)"
This reverts commit bb8b0d415e.
2023-01-23 12:57:20 +05:30
phot0n
af093dd598 fix: traceback with context for submission queue 2023-01-23 12:57:20 +05:30
phot0n
bb8b0d415e fix: workflow mechanics for submission queue (start) 2023-01-23 12:45:22 +05:30
phot0n
08c8ab0229 chore: better notification message
Co-authored-by: Aradhya-Tripathi
2023-01-23 12:45:22 +05:30
phot0n
64cb507fae chore: verbose confimation dialog message 2023-01-23 12:45:22 +05:30
Sagar Vora
23c9d8a42d chore: remove old cache reference 2023-01-21 17:46:41 +05:30
Sagar Vora
05c03a9345 chore!: remove cache_locally parameter 2023-01-21 17:32:24 +05:30
Sagar Vora
30941c49f5 chore!: remove special local cache for documents 2023-01-21 17:28:42 +05:30
Shariq Ansari
bd3ee0d4c0 fix: Password Strength Progress Bar 2023-01-20 22:03:21 +05:30
Suraj Shetty
eb086268b0
Merge pull request #19681 from surajshetty3416/fix-indicator-colors 2023-01-20 20:01:31 +05:30
Gavin D'souza
9efe84a644 fix(reportview): Remove aggregate_on_field added in fields
Essentially reverts changes added via
https://github.com/frappe/frappe/pull/14424 but works just the same
without the additional column :thonk:

The added column's data in mariadb was essentially garbage data. Wasn't
meaningful from what I could tell - couldn't play well with postgres
either
2023-01-20 19:26:56 +05:30
Suraj Shetty
ee3a6fab7d fix: Add cyan and pink indicator color for dark theme
- fix gray indicator colors on dark... make them lighter to make it more consistent and visible
2023-01-20 19:24:21 +05:30
Suraj Shetty
e2b3dd60c2 fix: Indicator contrast to make it more readable 2023-01-20 19:12:21 +05:30
Ankush Menat
e1ed1e9899
fix: rate limit newsletter subscriptions (#19690) 2023-01-20 19:05:51 +05:30
Ankush Menat
e8209b5dce
fix: invalid "empty form" message (#19696) 2023-01-20 19:03:56 +05:30
Shariq Ansari
f81dc3fce8
Merge pull request #19695 from frappe/fix-comment-email-title 2023-01-20 18:47:59 +05:30
Hussain Nagaria
0411328101 fix: use document title instead of name in subject 2023-01-20 18:30:27 +05:30
casesolved-co-uk
85a7757779 fix: listview stats speedup 2023-01-20 12:44:04 +00:00
Richard Case
457114521f
fix: prevent web form button resubmit and add freeze (#19670)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-01-20 17:22:37 +05:30
Richard Case
b66f93bdf5
feat: allow 'content' attribute for website structured data schema (#19667) 2023-01-20 14:37:18 +05:30
Sagar Vora
e208db7104
perf: only clear controller cache from current site (#19661)
* perf: only clear controller from current site

* chore: only pop current site controllers if doctype isnt specified
2023-01-20 14:36:42 +05:30
Suraj Shetty
dcbc9e54ca fix: Indicator dot colors in dark mode 2023-01-20 14:16:04 +05:30
Ritwik Puri
98191c5a94
Merge pull request #19677 from phot0n/commentcountui
fix(minor): show 0 as comment count if _comment_count doesnt exist
2023-01-20 13:52:39 +05:30
Ankush Menat
0449f851c7
fix: correct exit code on missing app failure (#19676) 2023-01-20 13:51:00 +05:30
phot0n
586555a1c4 fix(minor): show 0 as comment count if _comment_count doesnt exist 2023-01-20 13:48:47 +05:30