Commit graph

42389 commits

Author SHA1 Message Date
Ankush Menat
c7edd7e57c chore: remove unnecessary assertion 2023-01-16 18:02:40 +05:30
Ankush Menat
366ba4720e
Merge pull request #17869 from resilient-tech/refactor-installed
refactor!: deprecate sorting based on `apps.txt` in `get_installed_apps`
2023-01-16 17:56:06 +05:30
Ankush Menat
8adfdcbc1d tests: clear DB transactions before all db calls
Because of repeatable read isolation,
changes from externally executed command dont reflect until transaction is ended.
2023-01-16 17:32:29 +05:30
marination
8bd1b7b019 fix: Remove unnecessary get_sql 2023-01-16 17:09:21 +05:30
Marica
6164817748
Merge branch 'develop' into report-sidebar-respect-perm-query 2023-01-16 16:51:43 +05:30
marination
2702bf60aa refactor: Use Query instead of MySQLQueryBuilder
- Use `Query` from database/utils which will consider postgres query type as well
- Reduce LOC where unnecessary

Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
2023-01-16 16:51:11 +05:30
Deepesh Garg
0f5d17663d
fix: Remove setup wizard user image (#19601) 2023-01-16 16:44:04 +05:30
Ritwik Puri
1e6086fd75
fix(minor): only show authorization message if connected app is set (#19605) 2023-01-16 16:22:38 +05:30
Faris Ansari
543458b473 fix: handle empty list as filters 2023-01-16 15:38:15 +05:30
Ritwik Puri
50327203ce
Merge pull request #18750 from revant/oauth-email
feat: use Connected App for OAuth based Email Account
2023-01-16 15:24:05 +05:30
gavin
d1b7a69141
Merge branch 'develop' into permlevel-apis 2023-01-16 14:54:36 +05:30
Gavin D'souza
47bcc527f3 fix: Remove logic short circuit / dont reject fields easily 2023-01-16 14:51:31 +05:30
Gavin D'souza
85d6949d04 fix: Raise PermissionError when user doesnt have access to linked table 2023-01-16 14:28:47 +05:30
Gavin D'souza
f0a282e941 test: Add test for linked table permission check 2023-01-16 14:28:13 +05:30
Faris Ansari
5bc5ff100b test: tests for various filter options 2023-01-16 14:12:04 +05:30
Faris Ansari
52e3d8d58b fix: handle empty string passed to filters 2023-01-16 14:11:37 +05:30
Gavin D'souza
7e38d7fe63 test: Make test_child_table_join more resilient 2023-01-16 13:56:37 +05:30
Gavin D'souza
0355f33b77 fix(db_query): Handle permlevel check cases clearer
- Split to utility functions for clarity
- Add example over code blocks
- Re-arrange blocks based on priority
2023-01-16 13:54:56 +05:30
Ankush Menat
5e2bbf834f refactor: filter out apps not installed on bench 2023-01-16 13:54:40 +05:30
Sagar Vora
f5cbcec103 fix: defer local.all_apps loading 2023-01-16 13:54:27 +05:30
Sagar Vora
d8b7bc18d7 refactor!: deprecate sorting based on apps.txt in get_installed_apps 2023-01-16 13:54:27 +05:30
phot0n
b5c81cc015 chore(patch): disable all email accounts with oauth mechanism 2023-01-16 12:56:22 +05:30
Gavin D'souza
197de99e35 refactor: Use permitted over available in variable naming 2023-01-16 11:07:56 +05:30
aissa-berrachiche
bfaadfd32d
fix: passwords are updated on every login (#19594)
Co-authored-by: aberrachiche <aberrachiche@aas.com.sa>
2023-01-16 11:06:05 +05:30
Shariq Ansari
701415142b
Merge pull request #19597 from shariquerik/test-form-builder-fix 2023-01-16 10:47:40 +05:30
Shariq Ansari
fae098f661
Merge pull request #19587 from shariquerik/hide-workspace-firefox-fix 2023-01-16 10:27:20 +05:30
Shariq Ansari
cd8049e569
Merge pull request #19586 from ruchamahabal/fix-fetch-if-empty 2023-01-16 10:26:42 +05:30
Shariq Ansari
8abd144de6 test: fixed failing UI test 2023-01-16 10:24:45 +05:30
Shariq Ansari
35f4f22c7d
Merge branch 'develop' into fix-fetch-if-empty 2023-01-16 09:34:50 +05:30
phot0n
88d4d5e10d chore: minor cleanup - removed unnecessary branches and comments 2023-01-15 21:02:21 +05:30
phot0n
c2ceceea6e fix: use OAUTHLIB_RELAX_TOKEN_SCOPE for ignoring scope change
without this we get an error regarding the mismatch of scopes from microsoft
2023-01-15 21:02:21 +05:30
marination
0ba158979d fix: Make run_with_permission_query private (not a general util)
- Also switch query and doctype parameter positions in `_run_with_permission_query`
2023-01-13 21:30:54 +05:30
marination
c41b5e9511 fix: Report sidebar must consider Permission Query
- On boot cache permissible reports, filter out reports blocked by Permission Query
- Sidebar report selector uses boot cache to get allowed reports, which now respects Permission Query
- Convert qb query to str and append permission query and then execute

Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
2023-01-13 21:23:47 +05:30
Shariq Ansari
66d35ed3f4 fix: if workspace has children always show drop-icon in edit mode 2023-01-13 17:08:46 +05:30
Shariq Ansari
d7a50e4dfd fix: Hide drop-icon if all children is hidden
Hide section if all workspaces are hidden
2023-01-13 17:00:46 +05:30
Faris Ansari
a93380ac9c fix: handle empty list for "in" and "not in" 2023-01-13 16:22:25 +05:30
Faris Ansari
5340efd156 fix: don't cast integer value in filter 2023-01-13 16:21:51 +05:30
Shariq Ansari
20ff30896a
Merge pull request #19477 from shariquerik/form-builder-fixes-1
Fixes https://github.com/frappe/frappe/issues/19476
2023-01-13 14:55:18 +05:30
Rucha Mahabal
381ae564aa fix: fetch_if_empty not honoured on the client-side 2023-01-13 14:30:13 +05:30
phot0n
f6489a6de8 fix: allow submission queue doc reads from users if theyre owners
* only show unlock doc button to system managers
2023-01-13 12:57:32 +05:30
phot0n
12f0be1906 refactor(minor): better banner and removed unnecessary complexity for unlocking ref document 2023-01-13 12:57:32 +05:30
Aradhya
cffcb0fa17 refactor: failed attempts banner 2023-01-13 12:57:32 +05:30
Aradhya
e00d89f430 feat: Added queue_submission to workflows 2023-01-13 12:57:32 +05:30
Aradhya
1b46b0e347 fix: fixed status fetch and refactored message 2023-01-13 12:57:32 +05:30
Aradhya
4e8bbd6c93 refactor: allowing unlocking of doc when job id is not set 2023-01-13 12:57:32 +05:30
Ritwik Puri
27a2689678
fix: slug doctype when building url to report with filters (#19581) 2023-01-12 23:36:46 +05:30
Shariq Ansari
e9ac718199 fix: cannot focus on disabled input field in firefox
made it readonly
2023-01-12 21:56:52 +05:30
Shariq Ansari
4ba615608c
Merge branch 'develop' into form-builder-fixes-1 2023-01-12 21:00:45 +05:30
Shariq Ansari
e29d9451bf fix: removed :has() pseudo class since it is not yet supported in firefox 2023-01-12 20:57:17 +05:30
Pruthvi Patel
2e87b405fe
chore(docstring): fix docstring to match the value of MAX_WRITES_PER_TRANSACTION (#19572) 2023-01-12 17:47:59 +05:30