Commit graph

42389 commits

Author SHA1 Message Date
Ankush Menat
f5771baf66
ci: use GITHUB_TOKEN for roulette api calls (#19537)
This is safe cuz we set read only permission on this token in workflows.

NOTE: Changing permission type is dangerous here!
2023-01-09 17:09:59 +05:30
Gavin D'souza
058c49f439 fix: Pass parenttype in meta calls, handle count(*) type queries 2023-01-09 17:09:36 +05:30
Ankush Menat
3e715985c6
fix: ignore unhandled emails while deleting email account (#19534)
[skip ci]
2023-01-09 16:53:23 +05:30
Faris Ansari
f982439eb9 fix: pass fields explicitly
- to prevent addition of default `name` field
- also, add fields only if it is a select query
2023-01-09 16:43:44 +05:30
Gavin D'souza
2a6f9b1b9a fix(db_query): Load doctype meta on demand not on init 2023-01-09 16:22:01 +05:30
Gavin D'souza
1f50370599 fix(db_query): Apply permlevel checks on child/joined table queries 2023-01-09 16:12:22 +05:30
Gavin D'souza
15e51307b1 fix(db_query): Maintain order of dict[/select] keys
* Reduce internals' mutating calls
* maintain order of fields as previous function
* Use performant f-strings over concat + formatting
2023-01-09 15:47:21 +05:30
Gavin D'souza
1cd7620a3c fix: Fetch fields according to meta maintain order 2023-01-09 15:47:21 +05:30
Gavin D'souza
48aa7e8a93 perf(db_query): Avoid re-fetching doctype meta
Store doctype meta in DatabaseQuery instance under `doctype_meta`
bypassing multiple get_meta calls and Redis/DB IO & serialization overheads.
2023-01-09 15:47:21 +05:30
Gavin D'souza
d71522091e fix: Apply permlevel restrictions to DatabaseQuery
Allow reading only accessible fields for given user session if
ignore_permissions (get_all) is unset.
2023-01-09 15:47:21 +05:30
Gavin D'souza
ee074ec3c0 perf: DatabaseQuery.prepare_args
* Re-use stripped str variable where possible
* Remove use of any + [], startswith to get rid of unnecessary evaluations
2023-01-09 15:47:21 +05:30
Gavin D'souza
c28e4590e8 fix(rest): Delete doc attr if insufficient field permissions 2023-01-09 15:47:21 +05:30
Gavin D'souza
84ccf3d128 fix: Apply field permlevel for doc GET via REST 2023-01-09 15:47:21 +05:30
Faris Ansari
35c2654f00 chore: indentation fix 2023-01-09 15:34:50 +05:30
Faris Ansari
be654eaa60
Merge branch 'develop' into refactor-qb-engine 2023-01-09 15:23:20 +05:30
Faris Ansari
e4ac91a035 fix: ignore string with parenthesis
if it is not an sql function
2023-01-09 15:20:30 +05:30
Ankush Menat
92a705f8fd
ci: retry if rate limited in roulette (#19523)
[skip ci]
2023-01-09 13:11:22 +05:30
Ankush Menat
ac5b86cab1
ci: use node18 for releases (#19525)
Node <18 isn't supported anymore

> [semantic-release]: node version >=18 is required. Found v14.21.1.

> See https://github.com/semantic-release/semantic-release/blob/master/docs/support/node-version.md for more details and solutions.

[skip ci]
2023-01-09 13:10:26 +05:30
jiangying
f18135b52b
chore: simplify frappe/permissions.py raise_exception condition assignment (#19518)
* simplify frappe/permissions.py raise_exception
2023-01-09 13:03:59 +05:30
Ankush Menat
82d18f0bf0
Merge pull request #19519 from AHasanin/fix-userprofile-with-postgres
fix(user profile): fix user profile queries to support postgresql
2023-01-09 12:23:07 +05:30
Ankush Menat
075a2d778e feat: UnixTimestamp QB function 2023-01-09 12:05:52 +05:30
Ahmed Hasanin
45c80669bc
Merge branch 'develop' into fix-userprofile-with-postgres 2023-01-08 19:52:46 +02:00
AHasanin
78816428e4 fix(user_profile): remove unnecessary f string 2023-01-08 19:51:05 +02:00
jiangying
8273c9f244
chore: fix comment typo in frappe/desk/reportview.py (#19517) 2023-01-08 20:04:14 +05:30
AHasanin
9d14c68ca8 fix(user profile): fix user profile qeuries to support postgres 2023-01-08 16:15:20 +02:00
Ritwik Puri
e315c4f4b6
Merge pull request #19516 from dj12djdjs/fix-customize-form
fix: use doc_type within frappe.model.with_doctype
2023-01-08 10:15:27 +05:30
Devin Slauenwhite
fa06093fc4 fix: use doc_type within frappe.model.with_doctype 2023-01-07 17:35:50 -05:00
Shariq Ansari
32ea734e9c
Merge pull request #19510 from shariquerik/delete-standard-workspace-fix 2023-01-07 19:21:25 +05:30
Shariq Ansari
6f1e3e1a91 fix: show settings button only to workspace manager 2023-01-07 19:01:41 +05:30
Shariq Ansari
056d8e0368
Merge branch 'develop' into delete-standard-workspace-fix 2023-01-07 17:57:22 +05:30
Shariq Ansari
0a8591ffa4
Merge pull request #19496 from barredterra/workspace-perms 2023-01-07 17:30:24 +05:30
Shariq Ansari
580c9d6571 fix: do not allow to change module field if developer_mode is not set 2023-01-07 17:19:38 +05:30
Shariq Ansari
6f8fd738c4 fix: do not show delete button for standard workspace if developer_mode is not on 2023-01-07 17:18:58 +05:30
Gughan Ravikumar
4654db6e26
fix: use file name for backups to Google Drive (#19504)
Currently, backups to Google Drive are uploaded with the absolute path as the filenames. This fix changes that.

[skip ci]
2023-01-06 17:06:51 +05:30
Ankush Menat
6bae5a2974 fix: Dont create __init__.py in prod
closes https://github.com/frappe/frappe/issues/16618
2023-01-06 13:31:32 +05:30
phot0n
481d72c0ae fix: only pull from email accoutns which have token
* removed unnecessary after_save client hook from email account
* renamed check_active_token -> has_token (no need to refresh the access token)
* removed oauthentication error from email oauth - now just a simple validation error
2023-01-06 13:07:13 +05:30
Ankush Menat
010aa4636a
fix: Dont throw back to / if desk page not found (#19494) 2023-01-06 10:54:02 +05:30
Shariq Ansari
deaaa789cf
Merge pull request #19495 from shariquerik/redirect-to-fix 2023-01-05 21:47:07 +05:30
barredterra
033c6b357e fix: remove "All" permission for Workpace 2023-01-05 17:02:31 +01:00
Shariq Ansari
abc5b51e57 fix: after login if redirect is used getting blank screen 2023-01-05 20:39:35 +05:30
Shariq Ansari
bfa488c7fb
Merge pull request #19492 from ruchamahabal/fix-tab 2023-01-05 19:23:33 +05:30
Shariq Ansari
8fab9e8b1f
Merge branch 'develop' into fix-tab 2023-01-05 17:02:33 +05:30
Shariq Ansari
a221d37157
Merge pull request #19491 from shariquerik/failing-date-test 2023-01-05 17:02:21 +05:30
Shariq Ansari
a135ac587c test: fixed failing date control UI test 2023-01-05 16:46:24 +05:30
Rucha Mahabal
f5e81d4dfa fix: Activate tab when scrolling to field 2023-01-05 16:41:17 +05:30
Shariq Ansari
efeed5cffe
Merge pull request #19469 from Tom-Finke/fix_child_table_in_dialog_sortable
closes https://github.com/frappe/frappe/issues/19468
2023-01-05 13:59:13 +05:30
Shariq Ansari
da6809ec09
revert: checking if user has permission to meta (#19485) 2023-01-05 13:47:14 +05:30
Shariq Ansari
94669b13a1
Merge branch 'develop' into fix_child_table_in_dialog_sortable 2023-01-05 13:38:55 +05:30
Shariq Ansari
5705da52df chore: linter fix 2023-01-05 13:36:45 +05:30
Ankush Menat
28375e8e6e
refactor: deprecate db.set_value on singles completely (#19481) 2023-01-05 13:04:08 +05:30