vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
44192 commits 1 branch 0 tags 587 MiB
Commit graph

44192 commits

This branch
This branch
All branches
Author SHA1 Message Date
Suraj Shetty
8f5a199d64 test: Remove cacheAcrossSpecs to avoid bulk permission failure 2023-11-17 15:03:21 +05:30
David Arnold
283e91fd43
fix: minor fixes 
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-17 10:01:53 +01:00
Revant Nandgaonkar
1ecb60f1b0 fix: call auth hooks before validate auth 2023-11-17 14:10:37 +05:30
David Arnold
9228cd70f8
fix: code style 2023-11-17 09:30:53 +01:00
Revant Nandgaonkar
fea87d09dc fix: call auth hooks before raising error 2023-11-17 12:48:49 +05:30
mergify[bot]
443d508669
Merge pull request #22884 from zeel-codder/fix-email-message-email-group 
fix: use the use_html check in the Email Group
 2023-11-17 06:17:17 +00:00
anandbaburajan
ebccab0652 fix: copy any flags if required in rename_doc() only on validate 2023-11-17 00:32:28 +05:30
anandbaburajan
0aab6160a4 chore: validate arg for rename_field() 2023-11-17 00:31:04 +05:30
Shariq Ansari
bfe5d819a3
Merge pull request #23241 from shariquerik/workflow-fix-1 2023-11-16 18:01:56 +05:30
Akhil Narang
50129d3220
refactor(email_group): simplify logic to figure out which response to use 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 18:01:33 +05:30
Shariq Ansari
a339e83b25
Merge pull request #23238 from shariquerik/add-submit-role 2023-11-16 17:59:54 +05:30
Maharshi Patel
0b4f06c325
fix: remove quotes from IMAP Folder Name (#23242) 
Quotes were added around folder name as spaces would cause issue with IMAP.

This extra quotes are also passed to query which sets the
uidnext and uidvalidity. where condition is never met

This values are used on subsequent pulls and without this values,
it is considered first pull and all UNSEEN mails are synced.

So even If user selected All in sync option it will always work as UNSEEN
option.

When UNSEEN is used it will mark all emails as seen on IMAP server when pulled.
 2023-11-16 17:36:39 +05:30
Shariq Ansari
9adea285a3 test: fixed failing Customize Form UI test 2023-11-16 16:34:55 +05:30
mergify[bot]
4f90d24f02
Merge pull request #23170 from blaggacao/feat-add-new-db-bootstrap-only-command 
feat(db): boostrap only option if database and user is managed externally to bench
 2023-11-16 11:03:19 +00:00
Shariq Ansari
1ae12170e9 test: fixed failing Workspace UI test 2023-11-16 16:24:35 +05:30
Akhil Narang
5c023d238d
fix: get correct column definition 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 16:14:50 +05:30
Akhil Narang
e1bbcd73ab
fix: 0 is falsy, set correct defaults 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 16:14:50 +05:30
Akhil Narang
e3f6437245
fix(postgres): properly change nullability and default values 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 16:14:50 +05:30
Akhil Narang
ea7f611745
fix: adapt tests to actually work 
Couldn't seem to sanely get postgres default state

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 16:14:50 +05:30
David Arnold
5b33608fe3
fix: shell escaping in execute_in_shell helper 2023-11-16 10:52:11 +01:00
Shariq Ansari
4e00c36f0d test: fixed failing Web Form UI test 2023-11-16 14:57:52 +05:30
Shariq Ansari
bb0a2ca4df fix: not able to edit private workspace 2023-11-16 14:57:31 +05:30
Akhil Narang
75c8445b6a
refactor: cleanup column definition 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
5598fe241e
fix: use default default if a custom default isn't specified 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
b901f37267
feat(postgres/schema): add support for setting fields as not-nullable 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
558ac413ce
fix(mariadb/schema): use correct default value 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
731c5c8cd5
refactor(db_query): check for docfield not_nullable 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
10ad99869a
feat: use user-specified default value if passed 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
8d91e4524f
feat(exporter): handle docfield being non-nullable 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
8d540963c8
refactor(mariadb/schema): use sql_ddl() method 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
ccc2bdad52
fix: go back to original transaction handling mechanism 
This reverts the following:
07acfeed47 chore: move check_implicit_commit() call back to its original location
fc38a0b503 chore: simplify transaction handling
1e29e81543 chore: rework implicit commit checks
ae0a3fd202 feat: allow ignoring implicit commit warning

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
4855ec76c2
chore: use index to access table column instead of getattr 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
7d3295f09e
fix(doctype): update query was broken 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
5a4053fe2c
chore: make use of non_nullable to avoid ifnull usage 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
12a0afd91f
refactor: cleanup DbColumn.get_definition() 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
b88f3597fa
chore: add in tests for non-nullable field 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
5e6be19fe3
chore(DbColumn): force constructor arguments to be kwargs 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
6b49b5f32a
chore: move check_implicit_commit() call back to its original location 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
806748b063
chore: simplify transaction handling 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
fe549ecc49
chore: don't check for semgrep here 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
f9b9184223
chore: rework implicit commit checks 
Add in some more "reset" queries
- begin
- start

Also check *after* resetting

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
58b8b26b93
chore(mariadb): switch to using query builder for update statement 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
e41fa2dfc7
feat: migrate columns to be non-nullable if required 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
6550e0769b
feat: allow ignoring implicit commit warning 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
4f9ee8b633
feat(DbColumn): set non_nullable attribute and make use of it for column definition 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
15c925ccc7
feat: check for docfield not_nullable property to decide whether a field can be nullable 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
390d4e1b13
chore: drop unused variables and parameters 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
75709eede7
feat: set a non-null value if docfield isn't set as nullable 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
18867b273f
chore: make return type annotation make more sense 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
0026a6ceac
feat(docfield): add in a nullable checkbox field 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:55 +05:30