vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
45857 commits 1 branch 0 tags 587 MiB
Commit graph

45857 commits

This branch
This branch
All branches
Author SHA1 Message Date
Akhil Narang
19fcaff098
fix: miscellaneous cleanup 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-03-26 18:40:43 +05:30
Akhil Narang
bf2472d650
fix: set sender of communication as reply-to if its a reply 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-03-26 18:40:43 +05:30
Ankush Menat
7f4bcf37ce
fix: check object instead of DB for amended_from field (#25645) 2024-03-26 13:11:17 +05:30
Ankush Menat
76096f5fb8
perf: use meta for virtual and single checks (#25620) 
RQ workers spawn a new process for every job so site_cache does
nothing to prevent repeated queries.
 2024-03-26 13:10:15 +05:30
Akhil Narang
8961461bcb
Merge pull request #25643 from frappe/mergify/bp/develop/pr-25640 
fix: download_multi_pdf doesn't print letter head (backport #25640)
 2024-03-26 11:20:53 +05:30
Akash
aba2b7808f fix: add missing arg while invoking _download_multi_pdf 
(cherry picked from commit f82ed9fe11831d78e612ccd5db189f61439f1026)
 2024-03-26 05:41:02 +00:00
Akhil Narang
7c126f0555
Merge pull request #25610 from akhilnarang/fix-sentry-background-job 
feat: drop sentry's RQ integration
 2024-03-26 11:08:36 +05:30
Akhil Narang
baa5b1cb5f
fix(test): update RQ serialization test 
The job name will now be the module + qualname instead of just the method name

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-03-26 10:53:42 +05:30
Raffael Meyer
b27f7d2596
Merge pull request #25628 from frappe/pot_develop_2024-03-24 2024-03-25 21:36:52 +01:00
Raffael Meyer
58eafa2f17
Merge pull request #25550 from barredterra/refactor-like-unlike 2024-03-25 21:35:35 +01:00
barredterra
21780d2d2e Merge branch 'develop' into refactor-like-unlike 2024-03-25 21:31:39 +01:00
Ankush Menat
c75242cce4
Revert "fix: ensure that prepared report is set even on timeout (#25565)" (#25637) 
This reverts commit 6613ed76fe.
 2024-03-25 05:24:10 +00:00
Ankush Menat
4f205e2942
fix: only add title field in search if it exists (#25634) 2024-03-25 05:18:07 +00:00
Ankush Menat
bc47576faf
feat: after refresh event on query reports (#25632) 
There's no way to run something after report has refreshed right now.
This hook simplifies that.
 2024-03-24 13:20:38 +00:00
Ankush Menat
8ee28507f4
fix: Mark totals row correctly for print (#25629) 2024-03-24 11:10:11 +00:00
frappe-pr-bot
252bc97b9c chore: update POT file 2024-03-24 09:33:16 +00:00
Ankush Menat
54776f796b
perf: dont set defaults unless required (#25626) 
On site with many signups this causes cache trashing because every
signup clears cache.
 2024-03-23 14:35:56 +00:00
Faris Ansari
439e7c5b1a
fix: set list row height to 40px (#25619) 
- make checkbox container area larger to avoid accidental click routing to form
 2024-03-23 19:12:26 +05:30
Raffael Meyer
ffc45f287d
Merge pull request #25614 from barredterra/translate-contact-msg 2024-03-22 18:22:27 +01:00
barredterra
f40fa6ec73 style: newlines that don't trigger semgrep 2024-03-22 17:54:22 +01:00
Suraj Shetty
d12123f757
Merge pull request #25598 from surajshetty3416/embedable-webform 2024-03-22 22:23:52 +05:30
barredterra
457f5bf437 fix(Contact form): translate internal notification to system language 2024-03-22 17:45:10 +01:00
barredterra
b440eab24f fix(Contact form): make title and options translatable 2024-03-22 17:44:37 +01:00
barredterra
bcdce09dba fix(Contact form): make email translatable 2024-03-22 17:28:15 +01:00
Suraj Shetty
5bd496d2ee
Merge branch 'develop' into embedable-webform 2024-03-22 20:32:48 +05:30
Akhil Narang
c907636c3e
Merge pull request #25611 from akhilnarang/fix-unbound-local-variable 
fix(webhook): `r` is referenced here before its initialized
 2024-03-22 19:11:14 +05:30
Akhil Narang
2af42f5501
fix(webhook): r is referenced here before its initialized 
Broke in #21064

Sentry: FRAPPE-2SH

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-03-22 18:59:02 +05:30
Akhil Narang
bd6eaab00e
feat: drop sentry's RQ integration 
It overrides what we set with information that isn't really useful for us.
Set a more readable method name, and add in some additional job metadata.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-03-22 18:51:38 +05:30
Raffael Meyer
4c8562687f
feat: add option to set default email recipients (#25555) 
* feat: add option to set default email recipients

* fix: don't crash if no events

communication.js:206 Uncaught TypeError: Cannot read properties of undefined (reading 'events')
    at frappe.views.CommunicationComposer.get_default_recipients (communication.js:206:16)
    at frappe.views.CommunicationComposer.get_fields (communication.js:57:19)
    at frappe.views.CommunicationComposer.make (communication.js:25:17)
    at new frappe.views.CommunicationComposer (communication.js:16:8)
    at Object.primary_action (communication__list_js:34:3)
    at HTMLButtonElement.<anonymous> (list_view.js:1432:19)
    at HTMLButtonElement.dispatch (jquery.js:5135:27)
    at elemData.handle (jquery.js:4939:28)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
 2024-03-22 17:53:53 +05:30
Ankush Menat
bad3b9e6e7
perf: Faster "show title in link field" on list view (#25597) 
Ideally, this query should be converted to "Top N" variant and just pick
first 20 records, join only them with other table and send data back.

Currently we always group by `name` in list view. This makes "show title
in link field" join queries insanely slow as it first queries entire
table and then applies limit.
 2024-03-22 17:51:27 +05:30
Frappe PR Bot
0f138daf60
fix: Spanish translations (#25608) 2024-03-22 17:50:29 +05:30
Akhil Narang
4680c640dc
Merge pull request #25599 from akhilnarang/system-setting-global-ratelimit 
feat: allow setting a custom rate limit for `login via email link` feature
 2024-03-22 16:06:39 +05:30
Akhil Narang
766d2ae778
feat: allow setting a custom rate limit for login via email link feature 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-03-22 15:50:45 +05:30
Suraj Shetty
30082da7af feat: Option to make webform embeddable 
- If Web Form is rendered in Iframe all unnecessary elements from the web form view is hidden
 2024-03-22 15:06:12 +05:30
Nihantra C. Patel
f2561c46ef
fix: depend on condition in "Allow in Quick Entry" (#25579) 
* fix: depend on condition in "Allow in Quick Entry"

* remove section break and column break from the condition
 2024-03-21 23:48:55 +05:30
Ankush Menat
a9ebf58bd9
fix: diff after converting to html to text (#25582) 2024-03-21 13:30:54 +00:00
Ankush Menat
6613ed76fe
fix: ensure that prepared report is set even on timeout (#25565) 
* fix: ensure that prepared report is set even on timeout

Under following condition prepared report is never enabled:
- Process takes too much time and is killed
- HTTP timeout

Fix:
- We spawn a thread and ask it to wait till prepared report threshold
  time is elapsed and set prepared report on it.
- Condvar is used to immdiately wake up and end the thread if report
  finsihed early.

* refactor: use threading.Timer

No need to implement it ourselves
 2024-03-21 11:18:29 +00:00
Ankush Menat
a12fc118f4
perf: remove useless sorting on docstatus (#25571) 2024-03-21 06:17:23 +00:00
Shariq Ansari
695d822a23
Merge pull request #25532 from barredterra/list-frappe-ui 
refactor: align list style to frappe-ui
 2024-03-21 11:25:40 +05:30
barredterra
9292838cfa Merge branch 'develop' into list-frappe-ui 2024-03-20 15:15:03 +01:00
barredterra
2105bdb668 Merge branch 'develop' into refactor-like-unlike 2024-03-20 15:13:36 +01:00
Shariq Ansari
d7dbf774e7
Merge pull request #25257 from cogk/feat-default-workspace 
feat(workspace): Allow user to choose a default workspace
 2024-03-20 17:56:20 +05:30
Frappe PR Bot
b4f97a188d
fix: sync translations from crowdin (#25563) 
* fix: Spanish translations

* fix: German translations

* fix: Spanish translations
 2024-03-20 17:37:40 +05:30
Shariq Ansari
61cac70b3e chore: moved workspaces section inside settings tab 2024-03-20 17:16:33 +05:30
Ankush Menat
571ca34eca
fix: redirect after login, todo filters (#25521) 
* Revert "fix: default filter setup on todo list (#25455)"

This reverts commit 396bc4102e.

* Revert "Revert "fix: default filter setup on todo list (#25455)""

This reverts commit 5e6b6997d526446760c42e7e812ceef5fe416492.

* test: wait longer for filters to apply

* fix: route redirects after login

* test: use clear_filters

* fix: don't set default filters on ToDo

This messes with previous filters logic.
 2024-03-20 17:02:24 +05:30
Ankush Menat
ea0b266409
Merge pull request #24411 from ankush/field_extraction 
fix: fieldname extraction
 2024-03-20 16:43:23 +05:30
Ankush Menat
f642b1881f fix: invalid select star expansions 2024-03-20 16:31:02 +05:30
Ankush Menat
33547a6354 ci: group output and limit diff 
Verbose outut is MASSIVE and unreadable.
 2024-03-20 14:23:08 +05:30
Shariq Ansari
2e47f66d4e fix: row border was leaking 2024-03-20 14:19:57 +05:30
Ankush Menat
fbaa2549f2 test: add test for searching with paren 2024-03-20 12:30:11 +05:30