- Scheduled Job sync when type was changed from scheduled to some other
type didn't work.
- It updates on every save with message, bad DX IMO (can't save script
and edit without dismissing)
- This was because of complex walrus which was triggering rest of code
even when nothing changed. Maybe walrus opponents were onto something.
- `Truthy` couples two different operations and hence makes code
complicated. In most cases where these checks are required it's not
performance critical, we can do 1 more function call to avoid this
coupling of change + actual value.
* refactor(code): Use get_status for "copy text" button
* refactor(code): Rename method to setup_copy_button
* refactor(code): Toggle "copy text" button on refresh
* refactor(code): Use get_model_value when copying to clipboard
num2words - 260KB - Used frequently on ERPNext sites.
babel - 1.1MB Gets imported because of dates, localization
sentry - 2.8MB should be loaded only if envvar is set
gettext - required for reading translations
This seems to occur when new files are being created as we're archiving
the files on a site. Doesn't make sense to fail the entire backup
because of that.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
- Link fields when referred to increase idx
- This is used in search.py to rank most referred documents higher than
- This doesn't make for child table links at all.
TypeError: Cannot read properties of undefined (reading 'fields')
at frappe.ui.form.ControlTable.get_field(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table.js:120:18)
at HTMLInputElement.<anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table.js:46:13)
at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)
Sentry FRAPPE-698
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* feat: In sidebar filter link field show Title of Field if set (#26413)
* fix: test_list_view_child_table_filter_with_created_by_filter
* fix tests
* fix: formatting
* fix: formatting
* refactor: cleanup logic slightly, reduce code repetition
Respect value of show_title_field_in_link
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
