Commit graph

49610 commits

Author SHA1 Message Date
flaviacastro
1bf0aaf8ee chore: add webform list empty state messages to load_translations 2025-04-28 19:44:38 -03:00
Marica
3f813b347e
Merge pull request #32283 from barredterra/simplify-comment-refresh
refactor: simplify comment refresh
2025-04-28 17:28:08 +05:30
Frappe PR Bot
4b33808538
chore: update POT file (#32314) 2025-04-28 12:27:40 +02:00
Ejaaz Khan
1b0c886b2f
Merge pull request #32310 from cogk/fix-load-missing-option-dynamic-link
fix(load): Don't fetch Dynamic Link titles if missing doctype
2025-04-28 11:52:05 +05:30
Ankush Menat
2dfb96f91c
fix: handle snapshot isolation errors better (#32318)
* fix: Avoid Snapshot violation

- Main thread created and "read" user
- Other thread modified something
- Main thread wants to delete or "write" to same row.

This violates snapshot isolation.

* fix: treat snapshot violation as deadlock for now

* test: handle snapshot violations
2025-04-28 06:18:38 +00:00
Soham Kulkarni
0535a2f1f6
Merge pull request #32317 from sokumon/better-sidebar
fix: sidebar interaction
2025-04-28 01:38:44 +05:30
sokumon
c5ee716890 fix: child sidebar item interaction 2025-04-28 01:19:13 +05:30
Soham Kulkarni
6305e848b4
fix(safe_exec): add get_content_hash (#32265)
* fix(safe_exec): add get_content_hash

* fix: replace exposed function with sha256

* fix: rename function to sha256_hash and make it consistent
2025-04-27 13:37:25 +05:30
Sagar Vora
4dd98f8f06
Merge pull request #32309 from cogk/chore-typo-text
chore: Fix typo in comment
2025-04-27 00:46:37 +05:30
Corentin Forler
f5e99424ce
fix(load): Don't fetch Dynamic Link titles if missing doctype 2025-04-26 14:42:34 +02:00
Corentin Forler
6180622275
chore: Fix typo in comment 2025-04-26 10:01:50 +02:00
sokumon
b8da56d03d fix(minor): collapse text should be visible 2025-04-25 18:08:06 +05:30
Marica
2a75c27d17
fix: Show authorized private attachments in web forms (#32177) 2025-04-25 14:21:41 +02:00
Ankush Menat
856513423f
fix: recorder auto-disable (#32296)
This broke with client cache implementation... oopsie.
2025-04-25 11:32:55 +00:00
Ejaaz Khan
002892d0bf
Merge pull request #32300 from iamejaaz/35786-module-not-found
fix: Module not found error for custom doctypes
2025-04-25 15:54:04 +05:30
Marica
790a5fd28c
Merge pull request #32282 from barredterra/comment-notify-update
fix(Comment): logic for update notification
2025-04-25 15:36:35 +05:30
Ejaaz Khan
cae7759df6 refactor: pass app as an argument to avoid duplicte function call 2025-04-25 14:55:07 +05:30
Ejaaz Khan
2e0db2d69e fix: Module not found error for custom doctypes 2025-04-25 14:51:16 +05:30
Soham Kulkarni
84d1403f5c
Merge pull request #32299 from sokumon/better-sidebar
fix(minor): clean up variable
2025-04-25 14:15:44 +05:30
sokumon
e1c8d62ee3 fix(minor): clean up variable 2025-04-25 13:56:25 +05:30
Ankush Menat
32bde73607
perf: cast filters to string for assignments (#32297)
lessen impact of https://github.com/frappe/frappe/issues/32287
2025-04-25 06:18:33 +00:00
Ankush Menat
b4f8549c52
perf: cast todo queries for int PK (#32295)
https://github.com/frappe/frappe/issues/32287
2025-04-25 05:49:11 +00:00
Ankush Menat
dcb476c990
perf: cast dynamic links while filtering (#32294)
lessen impact of https://github.com/frappe/frappe/issues/32287
2025-04-25 05:43:01 +00:00
Ankush Menat
266ec9f76e
perf: Fix child table queries for int-PK parent (#32293)
Lessen but not eliminate impact of https://github.com/frappe/frappe/issues/32287
2025-04-25 05:33:07 +00:00
Ankush Menat
afc19dec10
perf: manually cast doc.name to string (#32292)
This avoid full table scans and undesired implicit casting at MySQL level.
2025-04-25 10:51:08 +05:30
Ankush Menat
d998d520fb
perf: use raw query for reading int-pk docs too (#32286)
Currently only string PK is supported but that wasn't the intention,
isinstance check is only there to avoid dicts/filters.
2025-04-24 13:11:07 +00:00
barredterra
525647a607 refactor: simplify comment refresh 2025-04-24 14:01:49 +02:00
Raffael Meyer
7c2205b703
feat: publish comment from desk (#32256) 2025-04-24 13:57:50 +02:00
barredterra
17ae73acad fix(Comment): logic for update notification 2025-04-24 13:08:14 +02:00
gavin
6bbd85a37d
Merge pull request #32262 from frappe/mergify/bp/develop/pr-32261
fix(get_events): Pass date objects instead of string (backport #32261)
2025-04-24 09:16:40 +02:00
Ankush Menat
8f8e7a14e7
Merge pull request #32280 from ankush/recorder_replica
fix: recorder with replica
2025-04-24 11:10:25 +05:30
Ankush Menat
360d19741e fix(recorder): patch replica DB connection 2025-04-24 11:02:03 +05:30
Ankush Menat
26b1360c50 refactor: Remember patched connections
This way if `frappe.db` changes we don't end up trying to unpatch the
wrong thing.
2025-04-24 10:52:53 +05:30
Ankush Menat
0be27d78b5
Merge pull request #32278 from sagarvora/time-in-ms
fix(DX): log execution time in `ms`
2025-04-24 10:33:53 +05:30
Sagar Vora
e6196672ca fix(DX): log execution time in ms 2025-04-23 22:40:23 +05:30
Ankush Menat
61b6e566cb
Merge pull request #32273 from ankush/int_key_version
fix: Avoid unnecessary version logs for int PK
2025-04-23 17:58:45 +05:30
Sagar Vora
6e5210078a
Merge pull request #32269 from ljain112/virtual--field 2025-04-23 17:49:34 +05:30
Ankush Menat
e9f5d9f61a fix: Avoid unnecessary version logs for int PK 2025-04-23 17:44:01 +05:30
Ankush Menat
5d380e6f93
Merge pull request #32040 from sokumon/eps-removal
refactor: separate EPS into an app
2025-04-23 17:40:16 +05:30
ljain112
259aae65c6 fix: do not create version for virtual fields 2025-04-23 17:39:35 +05:30
sokumon
b55c8d29fe fix(revert): remove patch to remove ep fields in Notification Settings 2025-04-23 16:58:03 +05:30
Ankush Menat
66e91445f5 fix: remove eps template 2025-04-23 12:05:01 +05:30
Ankush Menat
82c90bdbbd fix: Orphan doctype check should remove doctypes with no module 2025-04-23 12:02:58 +05:30
Ankush Menat
70e56b2e14
perf: Selectively switch to LIFO ordering when queue is starved (#32226)
When queue is overloaded every job gets delayed by size of the queue,
this means even interactive jobs like prepared reports face significant
wait times.

This flag allows developer to selectively enable LIFO on such jobs where
ordering doesn't matter. Any time we observe queue to be too large,
we'll insert the job at front so it gets highest priority.

This is a common strategy to deal with queue starvation, we are only
applying it explicitly because job execution order matters for
correctness in some cases.
2025-04-23 11:54:21 +05:30
Gavin D'souza
6fdbbb70ce fix(get_events): Pass date objects instead of string
Closes https://github.com/frappe/frappe/issues/32246

(cherry picked from commit a4590fa4cc09b44c444e10f212f31fc26f4f81aa)
2025-04-22 22:43:50 +00:00
Soham Kulkarni
f841f77534
Merge branch 'develop' into eps-removal 2025-04-23 01:21:07 +05:30
sokumon
9735aed5b0 fix(patch): remove ep related fields from notifcation settings 2025-04-23 01:17:49 +05:30
Suhail
3cd9b577e2
fix(fc-billing): switch manage billing to a button instead of div (#32248) 2025-04-22 11:43:59 +00:00
Sagar Vora
90de57730d
Merge pull request #32091 from marination/list-filter-permlevel 2025-04-22 17:00:56 +05:30
Ejaaz Khan
0f2c81e862
Merge pull request #32243 from cogk/fix-blog-intro-strip-tags-before-truncate
fix(blog): Strip tags before truncating content for intro
2025-04-22 14:50:57 +05:30