Akhil Narang
216015f49e
fix: Revert "fix: refresh fields after changing form to read-only ( #26439 )"
...
This reverts commit cc8c0f917cfix : #26983
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-07-04 17:29:26 +05:30
Akhil Narang
b91612bfa3
Merge pull request #26988 from akhilnarang/fix-grid-typeerror
...
fix(grid): TypeError from undefined return value
2024-07-04 16:25:37 +05:30
Akhil Narang
70b9e25190
fix(grid): TypeError from undefined return value
...
Sentry: FRAPPE-634
TypeError: this.frm.get_docfield(...) is undefined
at Grid.setup_allow_bulk_edit(../../../../../apps/frappe/frappe/public/js/frappe/form/grid.js:1073:28)
at Grid.make(../../../../../apps/frappe/frappe/public/js/frappe/form/grid.js:138:8)
at Grid.refresh(../../../../../apps/frappe/frappe/public/js/frappe/form/grid.js:399:25)
at frappe.ui.form.ControlTablerefresh_input(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table.js:141:13)
at frappe.ui.form.Controlrefresh(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/base_control.js:140:9)
at frappe.ui.form.Layoutattach_doc_and_docfields(../../../../../apps/frappe/frappe/public/js/frappe/form/layout.js:480:59)
at frappe.ui.form.Layoutrefresh(../../../../../apps/frappe/frappe/public/js/frappe/form/layout.js:342:8)
at GridRowForm.render(../../../../../apps/frappe/frappe/public/js/frappe/form/grid_row_form.js:26:15)
at GridRow.show_form(../../../../../apps/frappe/frappe/public/js/frappe/form/grid_row.js:1328:18)
at GridRow.toggle_view(../../../../../apps/frappe/frappe/public/js/frappe/form/grid_row.js:1310:9)
at this.open_form_button(../../../../../apps/frappe/frappe/public/js/frappe/form/grid_row.js:346:11)
at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-07-04 16:00:44 +05:30
Akhil Narang
08eb40de51
Merge pull request #26983 from akhilnarang/fix-undefined-refresh
...
fix(form): check that we can refresh the layout
2024-07-04 15:56:54 +05:30
Akhil Narang
e156ee1c14
fix(form): check that we can refresh the layout
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-07-04 15:42:55 +05:30
Akhil Narang
636147b81e
Merge pull request #26973 from akhilnarang/fix-quick-list-widget-create-button
...
fix(quick_list_widget): ensure that the user has create permissions before showing a create button
2024-07-03 20:53:14 +05:30
Akhil Narang
58cfaf804c
Merge pull request #26940 from ljain112/fix-tree
...
fix: clear doctype cache for tree doctype on modification
2024-07-03 20:52:35 +05:30
Akhil Narang
b7c15c6de3
fix(quick_list_widget): ensure that the user has create permissions before showing a create button
...
Also remove an extra whitespace after `Add New`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-07-03 20:29:11 +05:30
Frappe PR Bot
ed5201812f
fix: sync translations from crowdin ( #26860 )
2024-07-03 16:53:01 +02:00
Markus Lobedann
8badd16f1f
fix: don't run setattr for a virtual (read-only) field ( #26365 )
2024-07-03 16:27:27 +02:00
Akhil Narang
c8a7c48aba
Merge pull request #26954 from blaggacao/fix/issue-26953
...
fix(notification): error message
2024-07-03 14:14:31 +05:30
Raffael Meyer
fe820f79f1
fix: make view switcher translatable ( #26960 )
2024-07-02 16:49:16 +02:00
ljain112
28f575e254
fix: clear doctype cache for tree doctype on modification
2024-07-02 17:17:06 +05:30
mahsem
9f207eab0b
fix: closing HTML tag in System Console ( #26900 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2024-07-01 23:23:06 +00:00
Markus Lobedann
cc8c0f917c
fix: refresh fields after changing form to read-only ( #26439 )
2024-07-02 01:01:25 +02:00
Kenyi Watanabe
f70108502a
feat(List View): sort List Filters by filter_name ( #26747 )
2024-07-02 00:51:20 +02:00
David
4a2e929f43
fix(notification): error message
2024-07-01 21:17:11 +02:00
mahsem
6443b21e13
fix: make field labels translatable in Widget Dialog ( #26919 )
2024-07-01 19:23:44 +02:00
mahsem
ce52ac689c
fix: translation in query_report.js ( #26914 )
2024-07-01 17:21:25 +00:00
mahsem
659baa1591
fix: make error title translatable ( #26922 )
2024-07-01 19:12:58 +02:00
mahsem
52b562a7e0
fix: make web sidebar translatable ( #26921 )
2024-07-01 19:02:04 +02:00
Raffael Meyer
1e3260993a
Merge pull request #26942 from barredterra/contact-links
2024-07-01 18:59:06 +02:00
Raffael Meyer
748effe806
Merge pull request #26928 from frappe/pot_develop_2024-06-30
2024-07-01 18:13:05 +02:00
barredterra
c4e35ba5be
fix(Contact): set address query and buttons from links
2024-07-01 18:10:47 +02:00
Sumit Bhanushali
78c37e0731
Merge pull request #26874 from frappe/link_timeline
...
[Timeline] Show title field value if field is Link and show_title_field_in_link is True
2024-07-01 14:57:39 +05:30
Gursheen Kaur Anand
0bdcaa5ff8
Merge pull request #26933 from GursheenK/data-import-type-error
...
fix(minor): TypeError for undefined columns in data import
2024-07-01 12:50:27 +05:30
Gursheen Anand
e24fc51e21
fix: TypeError for undefined columns
2024-07-01 12:23:51 +05:30
Sumit Bhanushali
f46e506fed
fix: formatting
2024-07-01 11:39:29 +05:30
frappe-pr-bot
61b3f18e64
chore: update POT file
2024-06-30 09:33:36 +00:00
Sumit Bhanushali
b9e733d6e4
fix: default val when empty, match by name to match values
2024-06-29 22:57:32 +05:30
Gursheen Kaur Anand
8735244f9c
Merge pull request #26892 from GursheenK/print-shortcut-perms
...
fix(minor): check permission for ctrl+p shortcut
2024-06-29 16:24:01 +05:30
Sumit Bhanushali
5a1cac6bc3
perf: removed redundant db calls
...
Co-authored-by: gavin <gavin.dsouza@switchup.de>
2024-06-29 00:00:59 +05:30
Raffael Meyer
552646daf2
Merge pull request #26893 from barredterra/query-report-filters
2024-06-28 19:37:53 +02:00
barredterra
ff70fece72
fix: layout of printed report filters
2024-06-28 18:48:59 +02:00
barredterra
c1d1a3bab1
fix: don't add empty multiselect to filters object
...
The convention is that if a filter is not set, then it does not exist in the dictionary. However, empty multiselects used to appear as an empty list, breaking this convention. Now we filter out empty lists just like other falsy values.
2024-06-28 18:45:22 +02:00
Gursheen Anand
77e3fdd375
fix: check permission for ctrl+p shortcut
2024-06-28 20:29:15 +05:30
Raffael Meyer
ae0b6510fe
Merge pull request #26875 from barredterra/invalid-characters-unhandled
2024-06-28 15:16:53 +02:00
barredterra
722807ee14
test: email with invalid encoding
2024-06-28 14:39:06 +02:00
Raffael Meyer
8cd0ec12cf
Merge pull request #26879 from barredterra/stage-only-pot-file
2024-06-28 13:02:58 +02:00
Sumit Bhanushali
094a0de0d0
fix: incorrect double entry for link field when title_field is checked
2024-06-28 16:17:26 +05:30
Sumit Bhanushali
273ab9011e
fix: failing checks
2024-06-28 12:42:25 +05:30
Sumit Bhanushali
7c5485c46d
fix: password reset text should be generalized #26816
2024-06-28 12:16:02 +05:30
Sagar Vora
39c7c3d097
Merge pull request #26823 from ljain112/fix-dashboard
2024-06-28 12:01:04 +05:30
ljain112
e9bf5022a9
fix: update filters from dynamic link for dashboard open count
2024-06-28 11:45:56 +05:30
barredterra
ea5aec20d0
ci: explicitly stage pot file
...
Avoid accidentally adding any other changed files, like yarn.lock, to the commit.
2024-06-27 19:44:28 +02:00
Raffael Meyer
f3816fa2ea
Merge pull request #26425 from cogk/feat-add-translation-context-to-select-options
2024-06-27 19:34:32 +02:00
Raffael Meyer
fab5dcf938
Merge pull request #26167 from earona/feat-translation-customizations
2024-06-27 18:58:17 +02:00
barredterra
5f1b33e1fb
fix: docstring
2024-06-27 18:39:54 +02:00
barredterra
47d79b168d
refactor: extract common methods for parsing df and links
2024-06-27 18:38:05 +02:00
barredterra
aa43edf1d6
refactor: move EXCLUDE_SELECT_OPTIONS to utils
2024-06-27 18:07:07 +02:00
