Commit graph

43888 commits

Author SHA1 Message Date
Ankush Menat
2375f2ee05
Merge pull request #23031 from ankush/perm_search
fix: enforce perms on global search
2023-10-31 21:57:38 +05:30
Ankush Menat
db01c05eb8 fix: enforce perms on global search 2023-10-31 21:37:30 +05:30
mergify[bot]
f2c3978009
Merge pull request #23021 from akhilnarang/drop-ifnull-helparticle
refactor(help_article): drop usage of ifnull
2023-10-31 10:35:40 +00:00
Ankush Menat
f41451708a
Merge pull request #23019 from ankush/amended_from_likns
perf: Improve link checks during cancellation
2023-10-31 15:55:40 +05:30
Akhil Narang
796b11d665
chore(help_article): drop usage of ifnull
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-31 15:36:01 +05:30
Ankush Menat
cc9e92572b perf: dont query ignored link doctypes
Currently the code first queries and then ignores, just don't query linked doctypes if they are ignored via validation.
2023-10-31 15:14:24 +05:30
Ankush Menat
6062eec0d6 fix(recorder): Always enable sortable 2023-10-31 15:03:11 +05:30
Ankush Menat
55da69ad50 perf: Make amended_from indexed by default
This is checked before every cancellation, so it makes sense to index it.

Not touching any existing records *for now*.
2023-10-31 15:03:11 +05:30
Ankush Menat
6926669577 perf: Ignore amended_from link fields in link field checks
Small perf benefit at not much cost. `amended_from` are *always*
refererring to cancelled documents so there's no need to check these
fields.
2023-10-31 15:03:08 +05:30
Maharshi Patel
8d7eac3cb0
fix(minor): mobile menu & sidebar attachment text (#23013)
- Added Mobile Menu to be left Aligned until SM Breakpoint.
- Attachment Text in Sidebar is now smaller to match the rest of the text
- fixed close icon aligned in form tags that broken by .btn padding
2023-10-31 14:08:00 +05:30
gavin
00e222f303
fix(cli): Use mysql CLI as fallback is mariadb isnt found (#23009)
[skip_ci]
2023-10-30 16:16:22 +00:00
Akhil Narang
6418320d61
fix: directly assign return value (#23007)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-30 21:37:42 +05:30
gavin
9b112b3e03
fix(cli): Use mysql CLI as fallback is mariadb isnt found (#23006) 2023-10-30 15:39:36 +00:00
gavin
bedef22f34
fix(cli): Use mysql CLI as fallback is mariadb isnt found (#23004) 2023-10-30 19:48:04 +05:30
David Arnold
68d586e206
feat: import scss from node_modules in apps also (#22519)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-30 19:01:47 +05:30
Kevin Shenk
0c0fbc4248
fix: skip invalid numbers on SMS receiver_list (#22879)
This PR switches the loop in the `validate_receiver_nos` function in the SMS Settings Doctype from `break` to `continue`.

The prior functionality would throw an error if any recipients on the receiver_list were invalid, which created an issue with SMS notifications that send to a user role, since any user without a valid mobile phone number would prevent the notification sending to any users (even those with valid mobile numbers).

By switching the loop from `break` to `continue`, the function still eliminates invalid entries and enforces the existence of at least one valid phone number, but doesn't break sending based on a single absent or invalid recipient entry.

[skip ci]
2023-10-30 18:47:14 +05:30
Marica
6b1ec4703d
fix: Validate invalid links in fetch_from dependency fields (#22993) 2023-10-30 18:43:41 +05:30
Kevin Shenk
ca3ecc2da7
fix: Strip HTML tags from SMS Notifications (#22880) 2023-10-30 18:34:35 +05:30
Vishnu VS
e06200400f
feat: added "Dashboard Chart" button (#22960) 2023-10-30 18:30:03 +05:30
Bernd Oliver Sünderhauf
f51a788a0a
chore: Fix #22658 codestyle. (#23001) 2023-10-30 18:29:33 +05:30
Ankush Menat
c354b31b1f
fix(migrate): raise exception even if db is not available (#22922)
* fix(migrate): raise exception even if db is not available

* fix: wrap correctly
2023-10-30 12:51:22 +00:00
Thomas Fojan
36ad7e053e
fix: developer mode in website theme (#22958)
[skip ci]
2023-10-30 18:06:19 +05:30
Akhil Narang
03c88d145e
chore: print full path to backup (#22984)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-30 18:04:33 +05:30
Ernesto Ruiz
78781952a3
fix: Add translation to "Not Saved" state in print format builder (#22920)
[skip ci]
2023-10-30 17:57:52 +05:30
hyaray
51db89dfd1
feat(data export): Option to programattically set default filetype (#22658) 2023-10-30 17:52:20 +05:30
Suraj Shetty
7497b00167
Merge pull request #22967 from maharshivpatel/fix-inter-font-load-web 2023-10-30 17:39:38 +05:30
Ankush Menat
daca4dd31c chore: keep deprecated function slated for removal in future
This is used in ERPNext.
2023-10-30 17:31:25 +05:30
Ankush Menat
d3225a6df9
refactor: Writing multi-pdf (#22981)
- rename variables, output -> pdf_writer
- write to in memory stream instead of disk


[skip ci]
2023-10-30 17:26:01 +05:30
Akhil Narang
13537ad0f6
chore(blog_post): drop usage of ifnull (#22983)
`published` is a `Check` (int, non-nullable) field which has a default value in the database

Signed-off-by: Akhil Narang <me@akhilnarang.dev>


[skip ci]
2023-10-30 17:21:43 +05:30
Akhil Narang
c4544e8989
perf: query fields only once (#22982)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>

[skip ci]
2023-10-30 17:20:32 +05:30
gavin
8e7cd47d3d
feat: Document.remove_tag (#22970)
Added remove_tag API for consistency
2023-10-30 16:10:20 +05:30
Sagar Vora
fb5ca37cac
Merge pull request #22977 from resilient-tech/dynamic_link_auto_set
fix: revert to setting `frappe.dynamic_link` instead of using `cur_frm`
2023-10-30 16:07:09 +05:30
Sagar Vora
d23483d9aa fix: revert to setting frappe.dynamic_link instead of using cur_frm 2023-10-30 15:45:17 +05:30
Sagar Vora
e8cbf61e6a
fix: revert unintentional quick entry default for Address (#22974) 2023-10-30 15:23:25 +05:30
rohitwaghchaure
aa0f0d51e7
fix: group by didn't work for the frappe.client.get_value (#22969) 2023-10-30 15:15:56 +05:30
Ankush Menat
5fe80d3f34 chore: bump default session expiry to 7 days 2023-10-30 14:30:15 +05:30
Maharshi Patel
cd8c2dd21c fix: font loading on custom website theme
- added inter.scss as css import is failing in custom website theme
- changed css to inter.scss for website/index.scss
- inter.css is deprecated and should be removed in future
- update --font-stack if custom fonts are used in website theme.
- removed espresso variables from css_variables.scss
  as they are already imported in variables.scss
2023-10-30 12:44:35 +05:30
Bernd Oliver Sünderhauf
d92f74f877
chore: Fix codestyle to satisfy linter, and typo. (#22954) 2023-10-28 17:12:39 +05:30
Sagar Vora
c4cabbb11a
chore: bump werkzeug to 3.0.1 (#22945) 2023-10-27 16:47:26 +05:30
Ankush Menat
1560fa8610
fix: ignore stale custom fields while checking back-links (#22940)
* fix: ignore non-existing back-links

* refactor: less indentation, guard clauses
2023-10-27 14:07:58 +05:30
Faris Ansari
f4cd1bb8af
Merge pull request #22931 from netchampfaris/socketio-auth-url 2023-10-27 00:07:10 +05:30
Maharshi Patel
c7fa8e694a
Merge pull request #22924 from maharshivpatel/fix-espresso-web
fix: web styles espresso
2023-10-26 16:16:59 +05:30
Maharshi Patel
875bca7051
fix(minor): hide grid row on modal close (#22930)
Sometimes grid row is open in modal and people closes the dialog
which closes orphan backdrop and people are unable to access UI.

check if grid row is open and hide it on hide of modal.
2023-10-26 15:51:22 +05:30
Maharshi Patel
2e08741e60 fix: button size for md and lg
espresso buttons don't have large size but on website large size is used
so only apply espresso padding on buttons if they are not md or lg
2023-10-26 15:48:26 +05:30
Faris Ansari
be85c246ff fix(socketio): send correct url for auth
in case, an app uses a different frontend stack on a different development server,
socketio should use the correct webserver port when authenticating
2023-10-26 15:27:27 +05:30
Sagar Vora
9fdd432b4d
Merge pull request #22916 from resilient-tech/fetch-if-empty-revert 2023-10-26 15:14:51 +05:30
Sagar Vora
f08f128b1c fix: improve label and description for fetch_if_empty 2023-10-26 15:02:03 +05:30
Maharshi Patel
f1abf04a5a fix(minor): add min-width to modified
added min-width to modified so avatars column won't break
2023-10-26 13:26:18 +05:30
Maharshi Patel
e4de5bf0d1 fix: datepicker make current date bold. 2023-10-26 13:11:39 +05:30
Maharshi Patel
259695a1c7 fix: web styles espresso
- added Inter & Inter V on website and font-stack
- added flex to logged-in to center avatar
- decreased brand logo height to 22px
- added primary border-bottom to active navbar link
- added underline to links for blog content
  and added to from-markdown for web pages
2023-10-26 12:50:56 +05:30