Ankush Menat
b2abc2c9d1
Merge pull request #24624 from ankush/fix_private_file
...
perf: optional faster perm check for files
2024-01-31 11:06:09 +05:30
Ankush Menat
dedadbb0d9
perf: optional faster perm check for files
2024-01-31 10:49:18 +05:30
David Arnold
3abbde3284
fix: shell escaping on external commands
2024-01-30 18:23:05 +01:00
Ankush Menat
40438b400f
ci: set node env as production in tests
2024-01-30 21:55:51 +05:30
mergify[bot]
5031e9dbf4
Merge branch 'develop' into chore/cleanup-frappe-connect-2
2024-01-30 15:48:28 +00:00
Ankush Menat
e1f20f7305
Merge pull request #24621 from ankush/short_circuit_guest
...
fix: short circuit private files perm check
2024-01-30 20:48:42 +05:30
Ankush Menat
d838da51dd
fix: short circuit private files perm check
...
For guest users there's no point in checking permissions, they'll eventually fail... instead just fail immediately.
2024-01-30 20:31:28 +05:30
Akhil Narang
075ce78fbe
Merge pull request #24616 from akhilnarang/fix-import-log-success-rows
...
fix: show successful rows in the import log
2024-01-30 17:26:36 +05:30
Akhil Narang
db1e692d4f
chore: reword checkbox
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-30 17:08:14 +05:30
Akhil Narang
ba64285c66
Revert "fix(data_import): respect the value of show_failed_logs checkbox"
...
This reverts commit 34f03a2de2
2024-01-30 17:07:47 +05:30
barredterra
b59ba82ae6
fix(Data Import): translatability
2024-01-30 11:48:19 +01:00
David Arnold
b57dbe2dbc
Merge remote-tracking branch 'origin/develop' into chore/cleanup-frappe-connect-2
2024-01-30 10:47:19 +01:00
Shariq Ansari
dc7637991e
Merge pull request #24582 from shariquerik/if_owner_and_report_perm_fix
...
fix: do not allow to set if_owner & report perm together
2024-01-30 14:28:37 +05:30
Ankush Menat
d53a0ae45e
Revert "fix(module_map): only include apps installed on the site - not everything on the bench" ( #24605 )
2024-01-30 07:39:09 +00:00
Rucha Mahabal
3990da0620
feat: show doctype description in list views ( #24583 )
2024-01-30 09:39:59 +05:30
Raffael Meyer
a378c8bee2
chore: regenerate pot file ( #24600 )
2024-01-30 08:19:32 +05:30
Ankush Menat
2f28a5e224
Merge pull request #23904 from cogk/fix-fieldlevel-access-to-shared-document-list
...
fix(meta)!: Allow level 0 fields if a doc has been shared with user
2024-01-29 20:17:29 +05:30
Ankush Menat
d2d1b14cc6
fix: Always allow meta/standard fields in perm level
...
Perm levels CANNOT applied on these fields so these should ALWAYS be allowed.
2024-01-29 20:00:41 +05:30
Ankush Menat
3bea50d519
fix: Return empty result if no perm level access ( #24591 )
2024-01-29 19:48:19 +05:30
Ankush Menat
797cd696a7
Merge branch 'develop' into fix-fieldlevel-access-to-shared-document-list
2024-01-29 19:39:56 +05:30
Shariq Ansari
1cce6588ee
fix: sentry minor fix ( #24588 )
2024-01-29 18:08:11 +05:30
marination
bcca1da8d8
fix: Extract header/footer html into content to simplify things
...
- Extract header/footer html into `content` first, then remove any instances from the main content since it is already rendered via the extracted header/footer html
2024-01-29 13:25:45 +01:00
mergify[bot]
c9f8daf82d
Merge pull request #24511 from akhilnarang/module-map-only-site-apps
...
fix(module_map): only include apps installed on the site - not everything on the bench
2024-01-29 12:18:59 +00:00
Akhil Narang
db72dd37aa
refactor: fallback to all apps on bench when site isn't ready yet
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 17:31:52 +05:30
Shariq Ansari
08d5880683
Merge pull request #24584 from shariquerik/revert-quick-list-indicator
...
revert: added back quick list status indicator
2024-01-29 17:31:25 +05:30
Akhil Narang
f967aa9508
feat: print a warning if module names conflict
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 17:25:37 +05:30
Akhil Narang
f48ec5b690
refactor(module_map): fetch only installed apps if a site is initialized
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 17:25:37 +05:30
Shariq Ansari
0973e20c19
revert: added back quick list status indicator
2024-01-29 17:09:00 +05:30
Ankush Menat
4dce9d0d37
ci: skip UI test for PO files ( #24581 )
2024-01-29 11:17:04 +00:00
Shariq Ansari
d89cec362c
fix: do not allow to set if_owner & report perm together
2024-01-29 16:46:42 +05:30
Ankush Menat
89e89f72d5
chore: New translations main.pot (German) ( #24557 )
2024-01-29 11:16:25 +00:00
Dany Robert
eeac2bb6f0
fix(mobile): scroll issue after workspace change ( #24555 )
2024-01-29 16:27:15 +05:30
Govind Jangid
cb841bde6d
fix: depends on
2024-01-29 14:47:42 +05:30
Govind Jangid
39d3a5e8f4
fix: suggestion
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2024-01-29 14:39:58 +05:30
Govind Jangid
9e74bfbb8c
fix: description
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2024-01-29 14:35:54 +05:30
Akhil Narang
9b2e0446c5
Merge pull request #24575 from akhilnarang/sort-grid_row-options
...
fix(grid_row): sort options based on selected data first, so as to maintain order
2024-01-29 13:47:04 +05:30
Akhil Narang
b2002e6aed
fix(grid_row): sort options based on selected data first, so as to maintain order
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-29 13:31:09 +05:30
Ankush Menat
555bed36a2
fix: ignore dead columns in user_settings ( #24572 )
2024-01-29 13:14:34 +05:30
Govind Jangid
bb746d5e9c
fix: formatting
2024-01-29 12:31:54 +05:30
Govind Jangid
503222391b
fix: formatting
2024-01-29 12:30:35 +05:30
Govind Jangid
0c6c0c5f50
feat: use_first_day_of_period
2024-01-29 12:17:58 +05:30
Ankush Menat
70a6a8334f
fix: set same cookie expiry as client side ( #24560 )
2024-01-29 05:52:40 +00:00
mergify[bot]
4b87bf6ec4
Merge pull request #24549 from cogk/url_encode
...
fix(search): Fix URL encoding for search result
2024-01-28 05:35:00 +00:00
Raffael Meyer
0006f23898
Merge pull request #24552 from barredterra/translatability-assignment-days
2024-01-26 19:20:22 +01:00
barredterra
9fa409eae4
fix: translatability
2024-01-26 19:02:44 +01:00
mergify[bot]
783cb78731
Merge pull request #24548 from cogk/fix-24547-dont-translate-the-result-of-num2words
...
fix(money_in_words)!: Don't translate the result of num2words
2024-01-26 15:13:26 +00:00
Corentin Flr
7651b51af7
fix(search): Fix URL encoding for search result
2024-01-26 16:07:51 +01:00
Corentin Flr
dde34f9402
fix(money_in_words)!: Don't translate the result of num2words
...
It's unlikely that a translation for the results of num2words exists, because it should return a string that is already translated in the target language. If there are some numbers that have a specific translation, then it should already be handled in the num2words library. A domain-specific library is surely better at this hypothetical task than Frappe's generic translation system.
In French, 100 is called Cent. But in English, Cent is 1/100th of a dollar, which is called Centime in French.
Expected: num2words(200).title() == "Cent"
Actual: _(num2words(200).title()) == _("Cent") == "Centime"
2024-01-26 15:49:18 +01:00
Ankush Menat
63e2e2db56
feat: Configurable search link limit ( #24539 )
2024-01-26 06:31:11 +00:00
Raffael Meyer
aa7e111186
fix: consider only source_doc's no_copy ( #24501 )
2024-01-25 15:05:41 +05:30
