vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
52865 commits 1 branch 0 tags 587 MiB
Commit graph

208 commits

Author SHA1 Message Date
ismxilxrif
2f50f3174f
fix(desk): guard owner/modified_by access in update_user_info (#35581) 
* fix(desk): guard owner/modified_by access in update_user_info

Fixes a regression introduced by #35557

This updates the code to safely check for the presence of those
fields using `getattr` before adding them to the uservlist. This
preserves the intended upstream behavior while avoiding
runtime errors for virtual/single/transient documents.

* chore: cache getattr instead of calling it twice

* refactor: less code

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2026-01-01 07:03:15 +00:00
Ankush Menat
e7598ec3a8
fix: Fetch user info for owner, modified_by and versions (#35557) 2025-12-31 07:56:26 +00:00
Ejaaz Khan
8824f6fb4d feat: minimal attachment view design 2025-12-26 16:53:53 +05:30
Akhil Narang
7a229d3c25
fix(getdoc): typo in docstring (#35380) 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2025-12-22 06:33:31 +00:00
Ejaaz Khan
fbe22accb1 feat: re-design attachment and image section 2025-12-18 17:44:27 +05:30
Akhil Narang
2dcfe07ca8
refactor: make use of check_permission parameter for get_lazy_doc 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2025-12-10 16:52:26 +05:30
Hussain Nagaria
5fd6691548 fix: query placeholders 2025-11-28 11:40:05 +05:30
Hussain Nagaria
2b54da0219 fix: select correct number of rows in CTEs 
Thanks @ankush for helping with this competetive coding task 😂
 2025-11-27 22:36:57 +05:30
Hussain Nagaria
077c54a1a5
Merge branch 'develop' into perf/comm 2025-11-27 22:26:50 +05:30
Hussain Nagaria
3c5affd359 refactor: use CTEs to get merged results 2025-11-12 12:44:21 +05:30
Saqib Ansari
d63363fc97 feat: show custom perm types in share dialog 2025-11-10 14:00:02 +05:30
Sagar Vora
a084f5a2f3 refactor: separate only computed CTs, with new include_computed flag 2025-10-14 12:31:47 +05:30
Sagar Vora
2c9c6c0fd5 fix: correct table_fields references 2025-10-01 12:25:00 +05:30
Ankush Menat
f56c405e26
fix: Remove meta-bundle caching (#33029) 
- This has never worked
- using `modified` isn't a good way to invalidate this cache because it
  doesn't change with customization
 2025-06-20 18:33:30 +05:30
Ankush Menat
49f582ae57 perf: Use lazy doc in a lot more places 2025-06-11 09:55:45 +05:30
Corentin Forler
f5e99424ce
fix(load): Don't fetch Dynamic Link titles if missing doctype 2025-04-26 14:42:34 +02:00
Ankush Menat
afc19dec10
perf: manually cast doc.name to string (#32292) 
This avoid full table scans and undesired implicit casting at MySQL level.
 2025-04-25 10:51:08 +05:30
Raffael Meyer
7c2205b703
feat: publish comment from desk (#32256) 2025-04-24 13:57:50 +02:00
sokumon
196f76028f fix: remove leaderboard and custom timeline handling 2025-04-17 00:26:57 +05:30
sokumon
a1fca6ab63 fix: remove energy points / social module 2025-04-17 00:26:57 +05:30
Akhil Narang
ad32216040
fix: support sqlite 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2025-04-15 13:59:16 +05:30
Sagar Vora
f4062b4d7a fix: ensure consistent error in response 2025-02-19 12:10:59 +05:30
Ejaaz Khan
701e744211
Revert "fix(_get_communications): clean email content before returning" 2025-02-13 23:32:55 +05:30
Ankush Menat
429dab759d
perf: Skip loading EPS if not enabled (#31099) 
It's disabled by default 🤷
 2025-02-04 07:28:29 +00:00
Ankush Menat
84f9c5d48a
Merge pull request #31098 from ankush/perf/docinfo_1 
perf: speedup docinfo - skip tags when not used
 2025-02-04 12:41:29 +05:30
Ankush Menat
a8bfd540e1 perf: Avoid querying default email account on every load 2025-02-04 12:31:31 +05:30
Ankush Menat
7c67ca43ef perf: index tags for a document and dont track changes 2025-02-04 12:22:09 +05:30
Ankush Menat
fbd3cadee2
revert: error/webhook logs on every document (#31096) 
We serve millions of requests for reading a document, it doesn't make
sense to check error and webhooks on all of them. Not all documents even
have this configured.

If you need it, add it using "connections dashboard" or some custom code.
 2025-02-04 06:42:33 +00:00
Akhil Narang
0d124ccd37
fix(_get_communications): clean email content before returning 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-12-24 15:11:36 +05:30
Balamurali M
773bf810af
perf(version): Make get_versions fast for autoincrement doctypes (#28847) 
Since docname is varchar, indexes won't work when int as passed as
value.
 2024-12-21 10:41:32 +05:30
Ankush Menat
30ec033747
perf: Speedup get_doc by another ~1.5x (#28807) 
* perf: Reduce impact of forced cache replacement on every doc access

* fix: clear cache before processing users

Note: This is just an artifact of testing model, this won't have any real
effect on execution in real system.

Basically `enqueue_on_commit` is not respected in tests and it can't be
practically supported either.
 2024-12-17 16:48:43 +05:30
Raffael Meyer
9208b58b6f
refactor: use doc.check_permission (#28317) 
* refactor: use `doc.check_permission`

* refactor(delete_doc): check_permission_and_not_submitted
 2024-11-22 10:41:24 +01:00
David Arnold
057139ea2e
chore(communication): cleanup unused code (#28199) 
* chore: feedback doctype no longer exists

missed from https://github.com/frappe/frappe/pull/17479

* chore: remove unused communication type

This was removed and migrated already in v12:

```
frappe/patches/v12_0/setup_comments_from_communications.py:	frappe.db.delete("Communication", {"communication_type": "Comment"})
```
... comming from 41d90fa6d1
which effectively reverted 465318878e
 2024-11-14 00:12:14 +01:00
Akhil Narang
9b5af4a603
fix: set print_logs=False for some has_permission() calls 
This otherwise results in a lot of spam like: https://github.com/frappe/frappe/pull/27931#issuecomment-2396505626

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-10-07 16:00:39 +05:30
David
22498f26a7
feat: add link to (various) logs in sidebar 2024-09-30 13:24:55 +02:00
Akhil Narang
182ba2396f
fix: don't let getattr() raise an AttributeError, provide a default 
Re-doing https://github.com/frappe/frappe/pull/27669 overwritten by https://github.com/frappe/frappe/pull/27563
 2024-09-05 16:54:06 +02:00
Gavin D'souza
37316627c4
Merge branch 'develop' into set_link_titles 2024-09-05 13:41:24 +02:00
Gavin D'souza
7f7c97d499
fix: Set doc title name as fallback 
When the title field is unset for a document, it's value gets unset in a
link field on click. Added this fallback on the endpoint so that
clicking on field doesn't add an additional API call to fetch the title
via Desk.

Co-authored-by: Marica Dsouza <maricadsouza221197@gmail.com>
 2024-08-29 20:07:31 +02:00
Markus Lobedann
b170be419c fix: 🐛 show link titles for virtual link fields too 2024-08-07 12:16:50 +02:00
Akhil Narang
01de5ad796
Merge pull request #26978 from blaggacao/fix/email-record-linking 
fix: email record linking via rfc5233 & rfc5322
 2024-07-18 15:14:55 +05:30
Sumit Bhanushali
de4c275e66 fix: doc name cannot be translated 2024-07-13 11:30:34 +05:30
mahsem
ac894ae560 fix: translation in load.py 
fix: translation in load.py
 2024-07-11 12:03:38 +00:00
David
b0c57843c4
fix: plus quoting for better mta compatibility 2024-07-05 11:03:21 +02:00
Ankush Menat
8e3175f3e8
fix: show attachments on notifications too (#25443) 2024-03-14 13:01:10 +00:00
barredterra
10bd9a7efd fix: use communication date in timeline 
Before, we used the database creation date, which coincidentally corresponds to the real communication date in many cases.
 2024-02-13 15:36:53 +01:00
Akhil Narang
26ae0f3460
fix: ruff fixes 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
barredterra
c35476256f refactor: simplify conditional logic 
Command: `sourcery review --fix --enable de-morgan .`
 2023-12-05 11:14:41 +01:00
Ankush Menat
d20e436e0f perf: fetch user info in one query 2023-09-18 11:16:20 +05:30