Commit graph

48823 commits

Author SHA1 Message Date
Sagar Vora
2f9f659fcb perf(DX): always cache controllers 2025-02-20 17:43:12 +05:30
0xD0M1M0
7b96f19917
feat: (IMAP) Always BCC (#28961) 2025-02-20 12:47:17 +01:00
Akhil Narang
c66c41608e
Merge pull request #31289 from borisroman/develop
fix(email_account): select backend_app_flow when retrieving email_account
2025-02-20 13:31:44 +05:30
Akhil Narang
1473fb803c
Merge pull request #31328 from karotkriss/develop
fix: Update phonenumber library to handle new GY phone number format
2025-02-20 13:27:26 +05:30
Akhil Narang
009d3ee5e1
Merge pull request #31316 from akhilnarang/fix-assign-dialog-xss
fix: assign dialog xss
2025-02-20 13:24:17 +05:30
Akhil Narang
c22f652473
refactor(assign_to): use a Text Editor field for description
The `ToDo` doctype uses this, so it makes more sense here.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-20 13:06:36 +05:30
Akhil Narang
405d325291
Revert "Merge pull request #27578 from akhilnarang/sanitize-html"
This reverts commit 535220ce43, reversing
changes made to fe192025a5.
2025-02-20 13:06:36 +05:30
Christopher McKay
4e39f2f108 fix: Update phonenumber library to handle new GY phone number format
The phonenumber library was updated from version 8.13.13 to 8.13.55 to address an issue where new Guyanese (GY) phone numbers starting with +592 7 were being incorrectly marked as invalid.  Previously, only numbers starting with +592 6 were recognized. This change ensures that users can now correctly submit phone numbers with the updated format in forms.
2025-02-20 07:36:29 +00:00
Akhil Narang
6d3e281e51
Merge pull request #31333 from alexleach/alexleach-develop
feat: OAuth 2.0. Allow including client_id in backend app auth request.
2025-02-20 13:05:57 +05:30
Sagar Vora
64b0ca8d2f
Merge pull request #31334 from sagarvora/fix-cypress-fails 2025-02-20 13:03:20 +05:30
Sagar Vora
6e20eed640 fix: redo some fixes to ensure cypress passes 2025-02-20 12:51:37 +05:30
Alex Leach
cfbbaffd1d feat: OAuth 2.0. Allow including client_id in backend app auth request.
As per rfc6749 section-3.2.1, clients:

> MAY use the "client_id" request parameter to identify itself when
> sending requests to the token endpoint.

This patch allows to include client_id in BackendAppFlow, for servers
that require it.
2025-02-20 06:14:11 +00:00
Ankush Menat
17d6d81fb5
feat: mini pretty dates (#31331)
Narrow format pretty dates for list views, works the same way as client
side function.
2025-02-20 05:18:45 +00:00
Akhil Narang
6113452b73
Merge pull request #31320 from akhilnarang/drop-deprecated-method
refactor: utcfromtimestamp -> fromtimestamp(timezone.utc)
2025-02-19 18:09:01 +05:30
Sagar Vora
c8e4be7f5d
Merge pull request #31322 from sagarvora/fix-use-decorator 2025-02-19 17:44:00 +05:30
Sagar Vora
60b889c3b8 fix: ensure correct context in sys.exc_info 2025-02-19 17:33:53 +05:30
Ankush Menat
4997e5d223
fix: clear cache after db transaction ends (#31315)
This reduces probability of stale cache, but it's still very easily
possible because of repeatable read (!)
2025-02-19 11:44:37 +00:00
Akhil Narang
53b45f34bf
refactor: utcfromtimestamp -> fromtimestamp(timezone.utc)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-19 16:51:38 +05:30
Sagar Vora
a257a6a43e
Merge pull request #31312 from sagarvora/fix-desk-page-method 2025-02-19 16:44:00 +05:30
Ejaaz Khan
9bf5b9c0b9
Merge pull request #31305 from GuruWithin/fix-awesomplete-listitem-position
fix: allow Dynamic Link fieldtype in grid row click handler
2025-02-19 16:36:06 +05:30
Akhil Narang
e181bf118c
Merge pull request #31308 from akhilnarang/fix-xss
fix(send_message): escape HTML in the text
2025-02-19 16:33:40 +05:30
Sagar Vora
1af78e43b2 fix: update whitelisted methods 2025-02-19 16:32:09 +05:30
Sagar Vora
bb897cc61c
Merge pull request #31311 from sagarvora/remove-unused-import
chore: remove unused import
2025-02-19 14:53:13 +05:30
Sagar Vora
055f0b5a45 chore: remove unused import 2025-02-19 14:41:07 +05:30
Sagar Vora
c626229c7e
Merge pull request #31307 from sagarvora/fix-s69 2025-02-19 13:11:16 +05:30
Sagar Vora
4f374ee1c9 fix: ignore disable_traceback if _dev_server is True 2025-02-19 12:59:14 +05:30
Sagar Vora
1693991702 fix: remove dev server condition 2025-02-19 12:54:21 +05:30
Sagar Vora
fa252691b6 test: update status codes 2025-02-19 12:41:17 +05:30
Sagar Vora
09459d1d27 fix: ensure exception is always returned 2025-02-19 12:38:43 +05:30
Sagar Vora
d3bb578c2f fix: update type hints to allow integers 2025-02-19 12:31:12 +05:30
Akhil Narang
f2d0baf79d
fix(send_message): escape HTML in the text
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-19 12:23:47 +05:30
Sagar Vora
eded5eac24 fix: explicitly check type of form name 2025-02-19 12:17:31 +05:30
Sagar Vora
f4062b4d7a fix: ensure consistent error in response 2025-02-19 12:10:59 +05:30
Ankush Menat
e16f3b1c84
fix: set default, don't override cache headers (#31306)
Oof.
2025-02-19 11:28:34 +05:30
GuruWithin
1c85d9960a fix: allow Dynamic Link fieldtype in grid row click handler 2025-02-19 00:16:35 +05:30
Ejaaz Khan
91eee4fdf9
Merge pull request #31215 from aerele/report-custom-column
fix(report): add custom column based on link column
2025-02-18 23:23:01 +05:30
s-aga-r
85f7fb7922
refactor: Frappe Mail API (#29200) 2025-02-18 16:29:02 +05:30
Nihantra C. Patel
aed69f92f7
fix: hide create button for cancelled doc in dashboard links (#31295) 2025-02-18 14:55:39 +05:30
Akhil Narang
ef4ffbb304
Merge pull request #31290 from akhilnarang/fix-reportview-edit-if-has-table
fix(report_view): don't disallow editing just if a table exists
2025-02-18 11:24:48 +05:30
Akhil Narang
ccd8fb1f8b
Merge pull request #31269 from frappe/revert-29104-develop
Revert "fix: Improper routing for Report links when added to cards in workspaces"
2025-02-18 11:20:08 +05:30
Ankush Menat
611a03d1a2
Merge pull request #31283 from ankush/perf/rq_no_fork
perf: Support running RQ worker without forking
2025-02-17 19:16:21 +05:30
Ankush Menat
e2bd3abd62 fix: make nofork workers exit periodically 2025-02-17 18:55:25 +05:30
Ankush Menat
de7e6d0ba5 fix: force init background jobs 2025-02-17 18:47:59 +05:30
Ankush Menat
644bc5530e fix: Support stop-job, kill-horse etc 2025-02-17 18:40:11 +05:30
Ankush Menat
9dd005b21e refactor: separate worker type for nofork 2025-02-17 18:21:07 +05:30
Ankush Menat
0cebc61de1 fix: Exit worker on timeout exception
- Timeout in same process can leave bad state, so start a new worker.
- This isn't exactly costly, earlier we were forking all the time.
- Timeouts by definition can't happen too frequently.
2025-02-17 17:57:21 +05:30
Akhil Narang
24c2dfdf88
fix(report_view): don't disallow editing just if a table exists
If a table exists, go with the previous result. Else check and parse read_only conditions

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-02-17 17:49:52 +05:30
Boris Schrijver
01916192be
fix(email_account): select backend_app_flow when retrieving email_account 2025-02-17 12:41:53 +01:00
Ankush Menat
3b4e1bbb48 perf: Support running RQ worker without forking
Frappe does everything required to run jobs without forking.
- We cleanup locals
- Global caches are invalidated appropriately
- We destroy connections and open a new one for job/request

So we don't have any safety benefit much from forking for every job.
There can still be some code out in wild that relies on this behaviour
though!

Pros:
- Almost zero-overhead background jobs, just like web requests.

Cons:
- Timeout need to be implemented separately now
- Unknown side effects!
- Some features like "stop job" will need separate implementations.
2025-02-17 16:20:52 +05:30
venkat102
af39cc43ad fix: update doctype value 2025-02-17 12:29:14 +05:30