Commit graph

39716 commits

Author SHA1 Message Date
Ankush Menat
35ba00a54e
fix: handle isatty correctly (#18277)
sys.stdin can be `None`

[skip ci]
2022-10-03 12:05:55 +05:30
Raffael Meyer
513321810d
fix(Data Import): don't validate empty values (#17923)
* refactor: exclude header from column values earlier

* fix: don't validate empty columns

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-10-03 10:57:42 +05:30
aliX40
77be534e22
chore(translation): use Acceuil instead of Maison in fr translation (#18271)
In French ``Maison`` means house, but here the word ``Acceuil`` is what we actually need
2022-10-02 15:46:45 +05:30
Cleo Menezes Jr
af24bbff1b
fix: Show Report button should appear only if the doc is saved (#18268) 2022-10-01 00:10:55 +05:30
Shariq Ansari
fc1e01555b fix: added missing operators 2022-09-30 17:16:40 +05:30
Shariq Ansari
3162d192b8 fix: Chart filter not working if not operator is used 2022-09-30 17:16:40 +05:30
Ankush Menat
7b36265bad style: whitespace 2022-09-30 11:58:18 +05:30
Ankush Menat
7c423416b4
fix: report generation - frappe monitor (#18259)
- Identify original report name correctly.
- If sending to background, don't log it.
2022-09-29 19:35:38 +05:30
Ritwik Puri
66a31917f7
refactor(minor): reorder and remove unnecessary branches in set_new_name (#18243) 2022-09-29 16:23:55 +05:30
Ankush Menat
0e0e7f276c
fix: dont assume issingle exists (#18236) 2022-09-29 10:45:37 +05:30
Ankush Menat
b9e757782f
fix: correct boilerplate for virtual doctypes (#18248) 2022-09-28 15:49:15 +05:30
Ankush Menat
abeed35461
fix: throw exception if backup failed (#18230) 2022-09-28 14:29:38 +05:30
Ankush Menat
0825fd55c0 style: prettier 2022-09-28 11:21:22 +05:30
Ernesto Ruiz
4b67ebc2f1
fix: Add translate function to strings (#18153)
* fix: Add translate function to strings

fix: Add translate function to strings

* fix: add more strings to translate function

* fix: Add strings on translate function HTML tags

* fix: lint text on translate function

* fix: use single quotes on translate strings

* fix: Add template literals to translate HTML strings

* Update frappe/public/js/frappe/ui/toolbar/about.js

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-09-28 11:17:41 +05:30
Ernesto Ruiz
d399951fab
fix: add translate function to some strings (#18188)
* fix: typo on dashboard_view

* fix: add string to translate function

* fix: add string to translate function

* fix: add string to translate function

* fix: upddate translatet text to single quote

* fix: update translated strings to single quote

* fix: add country to translate function

* fix: add country to translate function

* fix: add string to translate function

* fix: add string to translate function

* fix: add string to translate function

* fix: Revert translate for country

* fix: revert single quote to Search for icons text

* fix: refactor the translate labels directly to html variable
2022-09-28 11:15:41 +05:30
Ankush Menat
0642708f01
perf: use modified instead of creation in scheduler (#18234)
creation doesn't have index and does full table scan. On large site with
~3M activity logs it takes ~1.5 seconds just to begin scheduler.


[skip ci]
2022-09-27 19:21:02 +05:30
Ankush Menat
07662ebaf3
fix: only allow verified_command on GET requests (#18235) 2022-09-27 18:17:58 +05:30
Ritwik Puri
43101e0356
fix(minor): consider only email id as sender email for auto email report (#18231) 2022-09-27 13:46:30 +05:30
aliX40
13e6aca115
fix: chart label not being translated (#18212)
* Fix  chart translation issue

also used .html() instead of .text() in line 58, because otherwise it resulted in html escape errors. In french ' is used in many words and when using the text() method it results in this string being inserted &#39;

* refactor: use data attribute

for semantic consistency

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-26 19:33:22 +05:30
Ankush Menat
56920e409a
perf: send all translations for setup wizard (#18226)
Computing all translations is far slower than just sending everything.
This is how boot works too.
2022-09-26 17:50:49 +05:30
Ankush Menat
3ab68980dd
Merge pull request #18219 from ankush/mdb_comments
fix: remove mariadb specific comments from column
2022-09-26 16:46:35 +05:30
Ankush Menat
6ba28061f6
test: flaky API tests due to autherror (#18221) 2022-09-26 12:33:20 +05:30
Ankush Menat
c76277f1bf fix: correctly order args and kwargs 2022-09-26 11:26:03 +05:30
Ankush Menat
9c84d078fa fix: remove mariadb specific comments from column
MariaDB has additional syntax for comments which are like python.
2022-09-26 11:09:39 +05:30
Devin Slauenwhite
5330814d7a
fix: make module to export required. (#18204) 2022-09-25 15:14:13 +05:30
Ankush Menat
939bf872ae fix: use compact JSON representation for monitor 2022-09-25 15:07:30 +05:30
Ankush Menat
967cc26fab feat: capture custom values in frappe monitor
lets monitor add extra info for:
- Save/Submit by doctype
- Report generation time by standard report name
2022-09-25 15:07:30 +05:30
mergify[bot]
002b27dbdd
fix: pypika does not parse datetime.time (backport #18184) (#18205)
* fix: pypika does not parse datetime.time

(cherry picked from commit b8f5a4304cccda954822cfe69d4805a18d9f07a7)

* fix: style - imports sort order fixed

(cherry picked from commit c3562c643ab9bff38d230202675d8ce1ae190912)

* test: add test for query builder parsing datetime.time

(cherry picked from commit 99889c270199da4b26b0d3858ae0f0a416d49d90)

* fix: format_time instead of format_datetime, test was failing!

(cherry picked from commit 5d697a22ac8cb98c8f8f44b3f99c57b932c5223c)

* fix(style): linter issues

(cherry picked from commit e231e1b0eadf63e84c9f81cfed9e2926e086fc44)

* test: add test for postgres

(cherry picked from commit 695591c43af9672cb83ce856a46c97e0bddfa9c3)

* fix: converting datepart and timepart to strings for Combinedatetime

(cherry picked from commit 1ebda943a607688bfb3db9fb42c80723a9050973)

* fix: style, linter issues

(cherry picked from commit c01262ad02b8831fdb0c5332b6973499e8adf6ad)

Co-authored-by: Anoop Kurungadam <anoop@earthianslive.com>
Co-authored-by: Aradhya <aradhyatripathi51@gmail.com>
2022-09-23 15:46:31 +05:30
Ankush Menat
4263aace27 chore: dont run cypress on forks 2022-09-22 14:59:39 +05:30
Shariq Ansari
5cfcc4a075
fix: Chart date format on x-axis is inaccurate (#18191) 2022-09-21 16:20:44 +05:30
Ankush Menat
3203dc8c1f
fix: filter out inactive workers (#18200)
[skip ci]
2022-09-21 12:15:03 +05:30
Ernesto Ruiz
a7cf590768
fix: add string to translate function onboarding widget (#18185)
[skip ci]
2022-09-20 22:45:42 +05:30
Ritwik Puri
c204fa7d67
feat(minor): delete kanban board from kanban view (#18163) 2022-09-20 12:02:46 +05:30
Ankush Menat
2b6fc68088
Revert "fix: drop Meta cache during update" (#18186)
* Revert "fix: drop Meta cache during update (#18182)"

This reverts commit 656f6df257.

* fix: replace meta cache keys

Old keys stored different types of data `dict` changing key to indicate
change in type.
2022-09-19 21:28:45 +05:30
Ankush Menat
656f6df257
fix: drop Meta cache during update (#18182) 2022-09-19 19:24:17 +05:30
Ankush Menat
1c06b331ef
Merge pull request #18178 from phot0n/restrict-ip-text
fix: change fieldtype of restrict_ip from data to small text
2022-09-19 18:56:26 +05:30
phot0n
82d0faf3d2 test: use middle_name instead of restrict_ip in test_index_and_unique_constraints 2022-09-19 18:38:47 +05:30
Sagar Vora
d947f9c37a fix: set brackets - walrus doesnt get priority 2022-09-19 17:01:40 +05:30
Sagar Vora
c216cd1500 chore: semantic changes to document caching code
[skip-ci]
2022-09-19 16:53:47 +05:30
Ankush Menat
00a82fabd7
Merge pull request #18164 from resilient-tech/perf-meta-field-map
perf: cache `Meta` directly and other improvements
2022-09-19 16:37:39 +05:30
Ankush Menat
40f6a34840 build: pin testing-library/dom temporarily
refer https://github.com/testing-library/dom-testing-library/issues/1169
2022-09-19 16:21:23 +05:30
Ankush Menat
c28ddcc3e6 test: basic perf test for rps on get_list 2022-09-19 16:21:20 +05:30
Ankush Menat
bcb5fe91aa fix: pickle doc objects directly
This seems to be missed out and causes performance regression in IRL
usage when get_doc is called on cached doc already.
2022-09-19 16:21:20 +05:30
Ankush Menat
abd018773b refactor: drop _allow_dict support
This is not required anymore since we store full doc anyway. Also since
they share same cache key calling get_cached_value and get_cached_doc
can end up doing duplicate / double work.
2022-09-19 16:21:11 +05:30
Sagar Vora
b529c27cb5 fix: ensure error is thrown 2022-09-19 16:21:11 +05:30
Sagar Vora
6c6a969d3a perf: simpler, faster meta cache 2022-09-19 16:21:11 +05:30
Sagar Vora
df8399f5d3 perf: initialise field map when initialising meta 2022-09-19 16:21:11 +05:30
Sagar Vora
fc3ee12baf
perf: cache FormMeta directly (#18165)
* perf: cache `FormMeta` directly

* perf: check if `dt` is table, use `db.get_value` instead of `get_all`
2022-09-19 16:10:32 +05:30
phot0n
359f0c3dcb fix: change fieldtype of restrict_ip from data to small text 2022-09-19 16:07:38 +05:30
Ankush Menat
7f1655fe46
build(deps): drop pyOpenSSL dependency (#18162)
- Not used anymore
- Official documentation suggests stopping use of
pyopenssl: https://github.com/pyca/pyopenssl
2022-09-17 12:15:26 +05:30