Ankush Menat
3cd06d7ebe
Merge pull request #23308 from ankush/addr_line
...
fix: increase length for address lines
2023-11-20 21:01:17 +05:30
Ankush Menat
c6371cbdd0
fix: increase length for address lines
...
140 char default limit is often not enough as demonstrated here https://github.com/frappe/frappe/issues/23259
2023-11-20 17:29:00 +05:30
Ankush Menat
49a0f75782
Merge pull request #23302 from cogk/fix-webform-get-cached-value
...
fix(WebForm): Replace `get_cached_value` with `get_value`
2023-11-20 16:45:43 +05:30
Corentin Flr
8b03a48f24
fix(WebForm): Replace get_cached_value with get_value
...
frappe.get_cached_value does not support filters
2023-11-20 12:13:55 +01:00
Ankush Menat
d715b0ad31
Merge pull request #22804 from akhilnarang/non-nullable-fields
...
feat: allow setting fields as not nullable
2023-11-20 12:46:02 +05:30
Akhil Narang
eb45da3913
feat: Allow usage of print() within safe_exec() ( #23084 )
...
* feat(safe_exec): allow usage of `print()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* refactor(system_console): update description to mention `print()` instead of `log()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* feat: unconditionally add debug logs to response if present
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* chore(safe_exec): add in a test for running `print()` within safe_exec
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* fix(safe_exec): ignore warning
RestrictedPython warns us if we call `print()` don't use their `printed` variable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* feat: store debug logs from scheduled jobs
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* fix: avoid ignoring warnings, disabled in prod anyway
* chore: remove unnecessary logging
This can be moved to level 2 when required
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-11-20 12:45:41 +05:30
sibi kumar k
c3b0da60d1
feat: Add image view in Workspace shortcut block ( #23041 )
...
* Feat:Add image view in Workspace creation
* image view condition
2023-11-20 11:56:05 +05:30
Shariq Ansari
c0d47d8ddd
chore: linter fix
2023-11-20 11:46:09 +05:30
Shariq Ansari
9949bf47b7
chore: linter fix
2023-11-20 11:42:19 +05:30
mergify[bot]
a0502e8af1
Merge pull request #23291 from ruthra-kumar/dont_rename_link_fields_in_virtual_doctypes
...
fix: dont rename link fields of Virtual doctypes
2023-11-20 05:13:05 +00:00
Ankush Menat
17ff6998da
fix: ignore invalid token so auth hooks can apply
...
The error will still be raised some 2-3 lines of execution later
2023-11-20 10:16:29 +05:30
ruthra kumar
94b2e509b9
fix: dont rename link fields in Virtual doctypes
2023-11-20 10:11:42 +05:30
Shariq Ansari
da5b723939
Merge pull request #23217 from rtdany10/workflow-docstatus-validation
...
fix(workflow): avoid implicit docstatus altering
2023-11-19 10:55:51 +05:30
Dany Robert
ee4f74913c
fix: test docstatus change from workflow
2023-11-19 03:02:30 +00:00
mergify[bot]
318b2e5ca2
fix:The title of the Link control does not appear correctly in the we… (backport #23270 ) ( #23280 )
...
Co-authored-by: Nrtyck <37080373+Nrtyck@users.noreply.github.com>
2023-11-18 23:06:12 +05:30
mergify[bot]
ac1c804532
fix: web_form_list.js invalid condition_json (backport #23277 ) ( #23279 )
...
Co-authored-by: Nrtyck <37080373+Nrtyck@users.noreply.github.com>
2023-11-18 23:03:23 +05:30
Shariq Ansari
0d0ff686e0
Merge pull request #23171 from barredterra/number-cards
2023-11-18 21:25:45 +05:30
hyaray
6f75dd70d6
Update multi_select_dialog.js ( #23261 )
...
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-11-18 21:18:57 +05:30
Shariq Ansari
a14966c980
Merge pull request #22595 from blaggacao/fix/non-html-notifications-rendered-from-files
2023-11-18 21:06:12 +05:30
Shariq Ansari
0d72a7964a
Merge pull request #23140 from cogk/use-other-wording-for-quick-entry
2023-11-18 19:58:25 +05:30
Shariq Ansari
41a7d8b135
Merge pull request #23262 from cogk/fix-webform-controls
2023-11-18 19:49:48 +05:30
mergify[bot]
e9e7f33792
Merge pull request #23255 from revant/fix-auth-hooks
...
fix: call auth hooks before raising error
2023-11-18 06:09:29 +00:00
Ankush Menat
5ba53b05fb
fix: Revert possibly breaking behaviour
...
Auth hooks should always run regardless of auth headers. These are
supposed to be generic hooks without any expectation on what it's
supposed to do.
2023-11-18 11:24:54 +05:30
Revant Nandgaonkar
693d079f16
fix: validate only authorization headers
2023-11-17 15:17:37 +00:00
Corentin Flr
f5f11a4eb8
fix(WebForm): Add missing keyboard.js dep for some controls
...
ControlTable and ControlPhone at least
2023-11-17 16:15:10 +01:00
Corentin Flr
b079d3ef78
fix(web): Send first_day_of_the_week and number_format in bootinfo
2023-11-17 16:14:37 +01:00
Dany Robert
b4c0b10bff
fix(workflow): avoid implicit docstatus altering
2023-11-17 14:01:54 +00:00
David Arnold
90b076a75a
feat(notification): specify message type (html, md, txt)
2023-11-17 15:00:12 +01:00
Revant Nandgaonkar
7666ea74f1
fix: validate_auth hooks for non Authorization headers
2023-11-17 19:26:28 +05:30
Revant Nandgaonkar
b37ac30dc6
fix: raise error on validate keys
2023-11-17 13:48:18 +00:00
Revant Nandgaonkar
53b8ab9a9d
test: fix test auth_hooks
2023-11-17 17:59:13 +05:30
Akhil Narang
ae9ae40bad
Merge pull request #23168 from blaggacao/refactor/centralize-python-shell-interface-for-database-binaries
...
refactor: give cli invocations of dbtools a dedicated interface
2023-11-17 17:02:41 +05:30
Corentin Flr
ecda12402c
Merge branch 'frappe:develop' into use-other-wording-for-quick-entry
2023-11-17 12:01:25 +01:00
Revant Nandgaonkar
2dd376543a
fix: pre-commit errors
2023-11-17 16:27:21 +05:30
Shariq Ansari
729f8be0af
Merge pull request #23248 from anandbaburajan/rename_doc_and_field
2023-11-17 16:15:40 +05:30
Revant Nandgaonkar
29d8f2a568
test: test auth_hooks
2023-11-17 15:56:17 +05:30
Revant Nandgaonkar
5fc4400eee
fix: revert raise error
...
internal function get_decrypted_password raises error
no point in removing error from call
2023-11-17 15:55:55 +05:30
Revant Nandgaonkar
8ea2803fbe
fix: remove raised exceptions and fail in validate_auth
2023-11-17 09:52:07 +00:00
Suraj Shetty
8f5a199d64
test: Remove cacheAcrossSpecs to avoid bulk permission failure
2023-11-17 15:03:21 +05:30
David Arnold
283e91fd43
fix: minor fixes
...
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2023-11-17 10:01:53 +01:00
Revant Nandgaonkar
1ecb60f1b0
fix: call auth hooks before validate auth
2023-11-17 14:10:37 +05:30
David Arnold
9228cd70f8
fix: code style
2023-11-17 09:30:53 +01:00
Revant Nandgaonkar
fea87d09dc
fix: call auth hooks before raising error
2023-11-17 12:48:49 +05:30
mergify[bot]
443d508669
Merge pull request #22884 from zeel-codder/fix-email-message-email-group
...
fix: use the use_html check in the Email Group
2023-11-17 06:17:17 +00:00
anandbaburajan
ebccab0652
fix: copy any flags if required in rename_doc() only on validate
2023-11-17 00:32:28 +05:30
anandbaburajan
0aab6160a4
chore: validate arg for rename_field()
2023-11-17 00:31:04 +05:30
Shariq Ansari
bfe5d819a3
Merge pull request #23241 from shariquerik/workflow-fix-1
2023-11-16 18:01:56 +05:30
Akhil Narang
50129d3220
refactor(email_group): simplify logic to figure out which response to use
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 18:01:33 +05:30
Shariq Ansari
a339e83b25
Merge pull request #23238 from shariquerik/add-submit-role
2023-11-16 17:59:54 +05:30
Maharshi Patel
0b4f06c325
fix: remove quotes from IMAP Folder Name ( #23242 )
...
Quotes were added around folder name as spaces would cause issue with IMAP.
This extra quotes are also passed to query which sets the
uidnext and uidvalidity. where condition is never met
This values are used on subsequent pulls and without this values,
it is considered first pull and all UNSEEN mails are synced.
So even If user selected All in sync option it will always work as UNSEEN
option.
When UNSEEN is used it will mark all emails as seen on IMAP server when pulled.
2023-11-16 17:36:39 +05:30
