Commit graph

22339 commits

Author SHA1 Message Date
Rushabh Mehta
3e4e6d4b3f feat(doctype link): add links to doctype for link dashboard 2019-11-07 12:14:09 +05:30
Rushabh Mehta
34b4b069ba feat(scheduler): log scheduler events 2019-11-07 12:14:09 +05:30
Rushabh Mehta
7cd329fac9 reactor(scheduler): created "Scheduler Job Type" and cleaned up scheduler 2019-11-07 12:14:09 +05:30
Shivam Mishra
7eb322f2be
Merge pull request #8672 from scmmishra/group-by-fix
fix: Do not append table name for field with standard sql method
2019-11-07 11:07:55 +05:30
mergify[bot]
95916cacea
Merge pull request #8771 from prssanna/filters-fix
fix: fix for "IN" type filters not being saved
2019-11-06 17:33:54 +00:00
Saurabh
a39c6589c5
Merge pull request #8769 from sahil28297/fix_auth
fix(auth): do not force standard users to reset password
2019-11-06 20:43:04 +05:30
prssanna
2a751b13b9 fix: return value in autocomplete validate if 'valid_values' list is empty 2019-11-06 18:34:47 +05:30
Sahil Khan
12ffba815a fix(auth): do not force standard users to reset password 2019-11-06 16:39:33 +05:30
mergify[bot]
736fc85176
Merge pull request #8738 from gavindsouza/no-name
fix(naming): empty string isnt accepted for rename
2019-11-06 07:12:10 +00:00
mergify[bot]
7fc62cb7cd
Merge pull request #8759 from prssanna/notifications-fix
fix(Notifications): Fix for 'New Document Shared' notifications
2019-11-06 06:40:45 +00:00
sahil28297
ebeee12326
fix(notification_log): skip enqueue_create_notification during new site creation 2019-11-05 20:52:04 +05:30
mergify[bot]
0782ebf143
Merge pull request #8761 from frappe/snyk-fix-db0a3e50a0bbf82e5e892e0a315b45e1
[Snyk] Fix for 1 vulnerabilities
2019-11-05 12:11:45 +00:00
snyk-bot
194be49333 fix: package.json to reduce vulnerabilities
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SHOWDOWN-469487
2019-11-04 23:06:38 +00:00
prssanna
66e54114cb fix: tests 2019-11-05 00:15:09 +05:30
prssanna
67faa597f6 fix: formatting 2019-11-04 23:39:30 +05:30
prssanna
9fc2309b47 style: hide 'Mark as Read in xs screen 2019-11-04 23:27:56 +05:30
prssanna
ba9eb671d6 fix: add notify param to notify_assignment in share.py 2019-11-04 23:26:54 +05:30
mergify[bot]
698761f3a1
Merge pull request #8753 from cjpit/fix_folders
fix: Ensure naming of files is correct.
2019-11-04 16:33:55 +00:00
cameron
3092c1dbcd tuple is returned 2019-11-04 16:40:46 +08:00
Shivam Mishra
de00a651cc
Merge pull request #8656 from gavindsouza/id-name
fix: added title_field to filters, removed search icon
2019-11-04 14:02:29 +05:30
mergify[bot]
346819ccca
Merge pull request #8721 from ruchamahabal/auto_repeat_remove_old_traces
fix(patch): update status and set auto repeat as not submittable
2019-11-04 08:00:07 +00:00
cameron
2e4d588381 fix issues with deepsource??? 2019-11-04 15:59:53 +08:00
mergify[bot]
cf1fcba9e5
Merge pull request #8754 from prssanna/dashboard-fix
fix(Dashboards): Fix dashboard date range
2019-11-04 07:52:34 +00:00
mergify[bot]
56e07fc2a3
Merge pull request #8709 from hrwX/list_form_int_fix
fix: convert number to string if title_field is Int
2019-11-04 07:46:44 +00:00
mergify[bot]
77d7f8fc92
Merge pull request #8649 from Alchez/dev-dashboard-internal-links
feat: allow internal links from parent document to show in dashboard
2019-11-04 07:42:02 +00:00
cameron
ee08d9b011 fix issue for deepsource 2019-11-04 15:38:52 +08:00
Faris Ansari
63af4c5b0a
fix: Update stale message 2019-11-04 13:05:36 +05:30
prssanna
160ecf1003 fix(Dashboards): Fix dashboard date range 2019-11-04 12:58:24 +05:30
mergify[bot]
0b72155c35
Merge pull request #8733 from makeen/develop
fix(API): allow update from request data (develop)
2019-11-04 07:27:52 +00:00
Faris Ansari
4bc53f901e
style: Fix formatting 2019-11-04 12:53:42 +05:30
mergify[bot]
0f5dbc031f
Merge pull request #8730 from frappe/sahil28297-patch-1
fix(email_queue): use send_one as email_queue is now an object
2019-11-04 07:18:39 +00:00
cameron
33cf95517f ensure naming of files is correct. 2019-11-04 14:50:53 +08:00
Suraj Shetty
7b05814dc7
fix: Handle null value 2019-11-04 12:20:33 +05:30
mergify[bot]
0f62dcae04
Merge pull request #8587 from prssanna/group-by-dashboard
feat(Dashboards): Add group by dashboard chart type
2019-11-04 06:31:53 +00:00
Gavin D'souza
539fe0aaa0 chore(style): consistencies in formatting 2019-11-04 11:47:52 +05:30
Gavin D'souza
50cee0f32e fix(naming): empty string isnt accepted for rename 2019-11-04 11:45:32 +05:30
Rucha Mahabal
1eab4ad342 fix: codacy 2019-11-03 15:41:27 +05:30
Rucha Mahabal
5c64fbdb20 fix(patch): update status and set auto repeat as not submittable 2019-11-03 15:36:22 +05:30
mergify[bot]
72274be822
Merge pull request #8707 from ioweb-gr/develop
fix: add support for utf-8 characters in pdf filename during downloads
2019-11-03 09:55:06 +00:00
mergify[bot]
2321dac55d
Merge pull request #8748 from RJPvT/patch-3
feat: enable indicator for cancelled
2019-11-03 09:15:21 +00:00
RJPvT
c2687b4978
feat: enable indicator for cancelled 2019-11-03 09:34:58 +01:00
mergify[bot]
0ed43c118f
Merge pull request #8722 from surajshetty3416/add-parent-to-custom-docperm
fix: Add parent field to Custom DocPerm
2019-11-03 08:01:28 +00:00
mergify[bot]
546c1905bc
Merge pull request #8740 from frappe/Query-Report-QP
fix(Query Report View): Do not force set filters from URL Args
2019-11-03 06:49:25 +00:00
mergify[bot]
e5fca3d703
Merge pull request #8741 from cclauss/patch-1
fix(data_migration): Undefined name e in data_migration_run.py
2019-11-03 06:30:12 +00:00
mergify[bot]
69d4efd3af
Merge pull request #8742 from gavindsouza/reload-dev
fix: reload via navbar does not reroute to homepage
2019-11-02 14:18:18 +00:00
Gavin D'souza
6a5692e728 fix: reload via navbar doesnt re-route to homepage 2019-11-02 19:23:42 +05:30
Christian Clauss
fac8dbff01
Undefined name: e in data_migration_run.py
The current code raises a NameError which is never logged.

[flake8](http://flake8.pycqa.org) testing of https://github.com/frappe/frappe on Python 3.8.0

$ __flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics__
```
./frappe/data_migration/doctype/data_migration_run/data_migration_run.py:417:63: F821 undefined name 'e'
					self.update_log('pull_failed', {migration_id_value: cstr(e)})
                                                              ^
./frappe/patches/v5_0/fix_email_alert.py:12:37: F821 undefined name 'email_alert'
				notification.days_in_advance = -email_alert.days_in_advance
                                    ^
2     F821 undefined name 'e'
2
```
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2019-11-02 13:12:45 +01:00
Saif
daf1553d70
fix(Query Report View): Do not force set filters from URL Args
No need to force set filters from URL Args
It is already set in the method `set_route_filters` to the Query Report's model

Currently if there are URL Arguments then even if you change the filters in the report view, the URL Args will override them.
2019-11-02 11:05:16 +05:00
Revant Nandgaonkar
a633d22945
Merge pull request #8720 from revant/port-code
fix: add missing code for social login key
2019-11-01 13:50:37 +05:30
makeen
efe94886a8
Update api.py 2019-11-01 00:53:29 +01:00