gavin
49fe1cd3cc
fix(UX): Show reason for read only form in headline ( #31511 )
...
Alt fix for alert added via https://github.com/frappe/frappe/pull/20077
which looks like an error message and is confusing to new users.
2025-03-05 00:36:28 +01:00
Soham Kulkarni
c5b0363a43
Merge pull request #31512 from sokumon/translate-report-data
...
fix: correct data while exporting with translate values
2025-03-05 01:37:44 +05:30
sokumon
992651153d
fix: correct data while exporting with translate values
2025-03-05 00:29:42 +05:30
Akhil Narang
a06b1756d7
Merge pull request #31495 from frappe/dependabot/github_actions/actions/download-artifact-4.1.9
...
chore(deps): bump actions/download-artifact from 4.1.8 to 4.1.9
2025-03-04 19:09:42 +05:30
Akhil Narang
0e80963c8c
Merge pull request #31267 from nabinhait/default-outgoing-email-account
...
fix: Clearer message for setting default outgoing email account
2025-03-04 18:45:44 +05:30
Soham Kulkarni
f423f8bd66
Merge pull request #31469 from sokumon/translate-report-data
...
feat: translate report data
2025-03-04 16:22:59 +05:30
sokumon
a601f9daa5
fix: use total_row flag to check
2025-03-04 14:27:35 +05:30
sokumon
faf0d42e03
fix: handle total row properly while translating
2025-03-04 14:07:08 +05:30
sokumon
aaa456c2ab
fix: only translate strings
2025-03-04 12:06:43 +05:30
Akhil Narang
7cf7bf686f
Merge pull request #31381 from barredterra/report-filters-from-route-options
...
feat: set report filters from route options
2025-03-04 10:35:21 +05:30
Akhil Narang
2cc0ee2755
fix(data_import): sanitize preview data and filename ( #31483 )
...
* fix(import_preview): sanitize preview data
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* fix(attach): sanitise filename before display
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-04 10:32:51 +05:30
dependabot[bot]
2482c0f160
chore(deps): bump actions/download-artifact from 4.1.8 to 4.1.9
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.8 to 4.1.9.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](https://github.com/actions/download-artifact/compare/v4.1.8...v4.1.9 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-03-03 18:22:19 +00:00
Suhail
5886234b53
refactor: sign up flow changes ( #31205 )
...
* fix: logout to site login page if the site is on Frappe Cloud
* fix: check if the site user is logged in before rendering trial banner
* fix: show dropdown even if the site is not on trial plan
* refactor: don't expose communication secret in boot
* feat: show install app button for fc sites
* fix: remove auth from desk
we can simplify it and let user do auth in fc
* fix: install app button condition
* refactor: use `is_fc_site` method
* fix: return boolean value for `is_fc_site` function
* fix: add install app button in /apps page
* fix: don't generate otp for login to fc
* fix: remove install app option from desk
* fix: design changes for trial banner
* fix: add more details to the `current_site_info` endpoint
also don't render trial banner if trial end date is passed
* fix: don't route user to welcome page
always put them on the site's dashboard
* fix: override base_url when needed
also remove misleading class
* fix: show banner to normal user to contact system admin for plan upgrade
* refactor: redirect from /login instead of every /logout code
* fix: rename login to fc to manage billing
also move it above the divider
* refactor: separate out site-login url from login.py
2025-03-03 16:36:15 +00:00
Marica
2022ddf407
refactor: Allow isolated headlines/intros in the form ( #31459 )
...
* refactor: Allow isolated headlines/intros in the form
- Each attempt to `show_message` should be rendered as a separate block with its own color and close button
- When grouped together the point of passing individual colors is lost
- The grouping behaviour also seemed implicit.
- An independently set headline could never stand out and the message is lost when grouped with another headline
* fix: Pull docstring out + avoid deprecated "substr" + Border Bottom
* chore: Add color options for color param in `show_message` docstring
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
---------
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2025-03-03 17:34:43 +01:00
sokumon
c17311fbb0
fix: translate total word
2025-03-03 19:43:45 +05:30
sokumon
299d7bfccb
fix: simplify function and better naming
2025-03-03 18:54:03 +05:30
Ejaaz Khan
4db9afce8a
Merge pull request #31486 from iamejaaz/custom-print-error
...
fix: template error on custom print format
2025-03-03 17:50:08 +05:30
Ejaaz Khan
3f9cb89611
fix: template error on custom print format
2025-03-03 17:34:47 +05:30
Ankush Menat
136098e5d6
fix: Avoid setting prepared reports for errors ( #31484 )
2025-03-03 12:02:36 +00:00
Akhil Narang
3f483790dc
fix(attach): sanitise filename before display
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-03 17:29:03 +05:30
Akhil Narang
2a5b9e45d1
fix(import_preview): sanitize preview data
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-03 17:24:20 +05:30
Soham Kulkarni
cf44c42e6f
Merge pull request #31479 from sokumon/better-sidebar
...
fix: small check to set currrent active sidebar item
2025-03-03 15:08:06 +05:30
Ankush Menat
25c08cacea
perf: skip order by for open_count ( #31472 )
...
- Not required, we are just counting
- Helps in *some cases* because no need to scan in modified order.
- Semantically correct anyway so eh.
2025-03-03 14:49:55 +05:30
sokumon
2875eace18
fix: small check to set currrent active sidebar item
2025-03-03 14:44:24 +05:30
gavin
00f8bbc123
Merge pull request #31457 from gavindsouza/fix-quickentry-submit
...
fix(quick_entry): Show submit option only if User can
2025-03-03 09:48:28 +01:00
Sagar Vora
ab262dc008
Merge pull request #31473 from sagarvora/remove-flag
...
fix: remove flag to ensure some checks run
2025-03-03 12:03:55 +05:30
Sagar Vora
5c003b67d9
fix: remove flag to ensure some checks run
2025-03-03 11:53:50 +05:30
Soham Kulkarni
b7eedd63a6
Merge pull request #31470 from sokumon/better-sidebar
...
fix: cleanup active sidebar logic , enhance mobile
2025-03-03 01:02:46 +05:30
sokumon
fca0dd7c63
fix: close sidebar when new item is clicked on mobile
2025-03-03 00:25:49 +05:30
sokumon
250220baa1
fix(refactor): sidebar active logic to depend on breadcrumb
2025-03-03 00:23:30 +05:30
sokumon
86a0482cbc
fix: proper identation
2025-03-02 23:13:03 +05:30
sokumon
7e5f63da39
fix: check if filters are a dict
2025-03-02 22:59:58 +05:30
sokumon
684f7715e7
fix: total_row is handled properly
2025-03-02 21:38:03 +05:30
sokumon
ca8f3e0f0b
feat: translate report data
2025-03-02 21:28:54 +05:30
Shariq Ansari
da7190a2ea
Merge pull request #31463 from shariquerik/validate-reset-password
...
fix: validate before resetting password from website
2025-03-01 16:06:04 +05:30
Shariq Ansari
a84294acab
fix: validate before resetting password from website
2025-03-01 14:19:31 +05:30
Soham Kulkarni
d95386edd8
Merge pull request #31287 from sokumon/better-sidebar
...
fix: more sidebar improvements
2025-02-28 23:54:08 +05:30
Gavin D'souza
279bf82719
fix: Check if doc is in draft before allowing to submit
2025-02-28 16:46:53 +01:00
Gavin D'souza
5930011849
fix(quickentry): Show submit option only if User can
...
ref: https://github.com/frappe/frappe/pull/26579/files#r1975437243
2025-02-28 14:49:06 +01:00
Ejaaz Khan
a23b790ccb
Merge pull request #31454 from iamejaaz/sticky-datatable-column
...
chore: update datatable version to add support for sticky column
2025-02-28 14:17:43 +05:30
Ejaaz Khan
d5b532d498
style: format code
2025-02-28 13:29:50 +05:30
Ejaaz Khan
85c22ec156
Merge pull request #30923 from bartoszpijet/develop
...
fix: event sync from Google Calendar not visible to user
2025-02-28 11:39:35 +05:30
Ankush Menat
e01187e610
fix: Ensure that scheduled jobs don't start in maintenance_mode ( #31450 )
2025-02-27 09:07:45 +00:00
mergify[bot]
5d270b9f67
fix: Cache thrashing in workspace code ( #31446 ) ( #31448 )
...
if result is `[]` then it ignores cache and keeps hitting DB for no
reason.
(cherry picked from commit 20b63f3252f9b23655e34ca830cff426ad5a50a3)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2025-02-27 08:11:53 +00:00
Ankush Menat
8e273d6701
chore: remove doctype overrides from hooks template ( #31444 )
...
This is a shit feature, don't advertise it to the world or make it easy
to use it.
2025-02-27 05:50:12 +00:00
Ankush Menat
7110e79926
fix: Avoid killing any system threads ( #31442 )
2025-02-26 16:07:46 +00:00
Ankush Menat
8baeb5151d
fix: check for running jobs before migrating ( #31438 )
2025-02-26 09:30:38 +00:00
Soham Kulkarni
8102706116
Merge pull request #31332 from sokumon/remove-view-file
...
fix: cleanup view file button
2025-02-26 00:05:44 +05:30
Marica
5bf1bacb27
Merge pull request #31433 from marination/translate-footer-items
...
fix: Translate Footer Items
2025-02-25 18:40:37 +05:30
marination
4dcd579b47
fix: Translate Footer Items
2025-02-25 13:22:57 +01:00