Commit graph

45964 commits

Author SHA1 Message Date
Ankush Menat
561617d5db
fix: allow disabling logging on CRON jobs (#25742)
Some crons are very very small duration and don't require logging
either. We should let users decide if they want to disable logging.
2024-03-30 06:21:56 +00:00
Maxim Sysoev
f32c3aa3a8
fix(ListView): In ListView make visible link title value for Subject column (#25569)
* fix(ListView): In ListView make visible link tite value for Subject column

Fixes #25567

* Revert "fix(ListView): In ListView make visible link tite value for Subject column"

This reverts commit eea3ea0a148f6f5800f1b008f97f8a86b4e6ebe8.

* fix: show title in subject field

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-30 11:23:01 +05:30
Ankush Menat
ea5e1b61ad
fix: cint -> avoid precision loss if already integer (#25735) 2024-03-29 22:31:53 +05:30
Ankush Menat
a6732a0e12
fix: set db name in filter (#25732) 2024-03-29 16:06:02 +00:00
Ankush Menat
bb26d8f678
Merge pull request #25730 from ankush/ulid_naming
feat: UUID naming support
2024-03-29 21:25:07 +05:30
Ankush Menat
8c6e3a56c6 feat: UUID name implementation for postgres 2024-03-29 21:02:54 +05:30
Ankush Menat
8cc6c31f0e fix: Allow switching between UUID and VARCHAR
- VARCHAR -> UUID = Only allowed when table is empty for now
- UUID -> VARCHAR is not lossy, can be done anytime.
2024-03-29 19:02:28 +05:30
Ankush Menat
1ec4d658fc fix: Allow setting UUID to application code 2024-03-29 19:02:28 +05:30
Ankush Menat
6c79a13641 feat: UUID naming support 2024-03-29 19:02:28 +05:30
Akhil Narang
ae34b12ce8
Merge pull request #22548 from blaggacao/feat/uds
feat: support unix domain sockets
2024-03-29 18:11:01 +05:30
Akhil Narang
0d3b2499fc
fix: don't use frappe.flags for mariadb_user_host_login_scope
This gets reset whenever we call `frappe.init()` again

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 16:57:04 +05:30
Ankush Menat
de48dc2c04
fix: db explain (#25724)
This broke from some recent changes.

It's just a wrapper, so probably no one uses it.
Anyway, fixed and added test to prevent it.
2024-03-29 10:23:12 +00:00
Corentin Flr
e8fe24d7df
feat(router): Go to default workspace when clicking app logo (#25706) 2024-03-29 15:44:25 +05:30
Ankush Menat
87ffe25e71
fix: reserved keywords as col name (#25718) 2024-03-29 15:43:33 +05:30
David
39d4318a27
feat: enable db socket connection 2024-03-29 10:29:50 +01:00
David
6eb1607c0a
refactor: name and explain user host login scope flag for mariadb 2024-03-29 10:26:49 +01:00
David Arnold
640e7d79b3
feat: prepare redis subsystem for unix domain socket connections 2024-03-29 10:12:19 +01:00
Akhil Narang
34f1b9cb65
Merge pull request #25719 from akhilnarang/fix-enqueue-method
fix(enqueue): pass the original method argument here
2024-03-29 14:17:34 +05:30
Akhil Narang
8658196650
fix(enqueue): pass the original method argument here
Don't pass the stringified version - this is what goes to RQ, and the string we construct isn't always "correct"

For example, 87d121f47a/frappe/email/doctype/email_queue/email_queue.py (L735-L736) generates `frappe.email.doctype.email_queue.email_queue.QueueBuilder.send_emails` which will result in `ModuleNotFoundError: No module named 'frappe.email.doctype.email_queue.email_queue.QueueBuilder'; 'frappe.email.doctype.email_queue.email_queue' is not a package`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 14:05:33 +05:30
Akhil Narang
2feacf5443
Merge pull request #25683 from akhilnarang/rollback-new-site
feat: rollback new site creation on failure
2024-03-29 12:42:38 +05:30
Akhil Narang
ee8e2fef8c
refactor(new-site): update rollback prompt
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:12:19 +05:30
Akhil Narang
197b1ab77c
refactor(installer): use frappe.generate_hash() to generate database name
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:12:19 +05:30
Akhil Narang
07f93e2817
fix(generate_hash): Deprecate txt parameter - its not used.
`length` has a default value anyway, no need of checking and setting a default.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:12:15 +05:30
Akhil Narang
1847e9cae8
fix: pass function as lambda
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
9940868063
fix: switch to datetime.now() instead of our get_datetime()
`get_datetime()` will query the DB to get the system timezone, not something we currently have.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
4b2fde1d8f
fix: check if rollback callback is defined
Don't raise exceptions where a simple print() will suffice
Print exception before prompting for rollback

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
c58e986a87
chore: check whether we're in an interactive session or not
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
147c0c8b37
feat: initial failed site rollback implementation
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
46981622ec
feat: generate a non-deterministic database name every time - include current date in the hash
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
1ffc4c7834
chore: update output to let the user know they can pass --force
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Akhil Narang
8cd23ecef5
chore: drop unused parameter
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-29 12:00:25 +05:30
Raffael Meyer
c43ec1cc37
Merge pull request #25707 from barredterra/translatable-insights-ad 2024-03-28 17:21:16 +01:00
barredterra
449d7d3b3d fix: make insights ad translatable 2024-03-28 17:19:53 +01:00
Ankush Menat
be579f9a8d
fix: sql_ddl - always ensure commit (#25704) 2024-03-28 13:13:55 +00:00
Ankush Menat
87d121f47a
Merge pull request #25660 from uhrjun/develop
fix: incorrect status on data import
2024-03-28 17:17:41 +05:30
Ankush Menat
9f7c385b11 fix: erase logs in case of complete failure 2024-03-28 16:59:36 +05:30
avc
81833afda0
fix: let's colored tags in listview (#25552) 2024-03-28 15:58:12 +05:30
Akhil Narang
2710c28870
fix(importer): set Pending status as a fallback
Will match scenarios like success == failed == 0

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-03-28 15:14:56 +05:30
Ankush Menat
f22120190d fix: Correct logic for comlete success 2024-03-28 14:48:10 +05:30
Ankush Menat
141e082b39
Merge pull request #25698 from ankush/fix_virtual_order_by
fix: recorder sorting with multi-col
2024-03-28 13:36:42 +05:30
Ankush Menat
7220a7d898 fix: recorder sorting with multi-col 2024-03-28 13:26:34 +05:30
Ankush Menat
23204c0c05
Merge pull request #25256 from ankush/no_commit_doc_events
fix: disable transaction commits during doc events
2024-03-28 12:28:12 +05:30
Ankush Menat
e5a64fd50c test: transaction control 2024-03-28 11:58:38 +05:30
Ankush Menat
f66b23b96d fix: handle nested event calls
Treat disable_transaction_control as a stack incr/decr when moving in
and out of context.
2024-03-28 11:27:24 +05:30
Ankush Menat
0cbd7c825b
Merge pull request #25650 from akhilnarang/fix-replyto-communication-reply
fix: set correct Reply-To header for replies
2024-03-28 10:03:57 +05:30
Ankush Menat
5fce9a471e
Merge pull request #25693 from barredterra/less-ads
fix: advertise insights to system manager only
2024-03-28 01:13:55 +05:30
barredterra
57bcfe548e fix: advertise insights to system manager only 2024-03-27 19:55:38 +01:00
Ankush Menat
e5b1747f75
Merge pull request #25691 from barredterra/translatable-ads
fix: make ads translatable
2024-03-28 00:21:13 +05:30
barredterra
7426805425 fix: make ads translatable 2024-03-27 19:47:42 +01:00
Ankush Menat
3fea2726f3 fix: modified index sync 2024-03-27 23:56:03 +05:30