Commit graph

48944 commits

Author SHA1 Message Date
Akhil Narang
7cf7bf686f
Merge pull request #31381 from barredterra/report-filters-from-route-options
feat: set report filters from route options
2025-03-04 10:35:21 +05:30
Akhil Narang
2cc0ee2755
fix(data_import): sanitize preview data and filename (#31483)
* fix(import_preview): sanitize preview data

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix(attach): sanitise filename before display

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-04 10:32:51 +05:30
Suhail
5886234b53
refactor: sign up flow changes (#31205)
* fix: logout to site login page if the site is on Frappe Cloud

* fix: check if the site user is logged in before rendering trial banner

* fix: show dropdown even if the site is not on trial plan

* refactor: don't expose communication secret in boot

* feat: show install app button for fc sites

* fix: remove auth from desk

we can simplify it and let user do auth in fc

* fix: install app button condition

* refactor: use `is_fc_site` method

* fix: return boolean value for `is_fc_site` function

* fix: add install app button in /apps page

* fix: don't generate otp for login to fc

* fix: remove install app option from desk

* fix: design changes for trial banner

* fix: add more details to the `current_site_info` endpoint

also don't render trial banner if trial end date is passed

* fix: don't route user to welcome page

always put them on the site's dashboard

* fix: override base_url when needed

also remove misleading class

* fix: show banner to normal user to contact system admin for plan upgrade

* refactor: redirect from /login instead of every /logout code

* fix: rename login to fc to manage billing

also move it above the divider

* refactor: separate out site-login url from login.py
2025-03-03 16:36:15 +00:00
Marica
2022ddf407
refactor: Allow isolated headlines/intros in the form (#31459)
* refactor: Allow isolated headlines/intros in the form

- Each attempt to `show_message` should be rendered as a separate block with its own color and close button
- When grouped together the point of passing individual colors is lost
- The grouping behaviour also seemed implicit.
- An independently set headline could never stand out and the message is lost when grouped with another headline

* fix: Pull docstring out + avoid deprecated "substr" + Border Bottom

* chore: Add color options for color param in `show_message` docstring

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

---------

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2025-03-03 17:34:43 +01:00
Ejaaz Khan
4db9afce8a
Merge pull request #31486 from iamejaaz/custom-print-error
fix: template error on custom print format
2025-03-03 17:50:08 +05:30
Ejaaz Khan
3f9cb89611 fix: template error on custom print format 2025-03-03 17:34:47 +05:30
Ankush Menat
136098e5d6
fix: Avoid setting prepared reports for errors (#31484) 2025-03-03 12:02:36 +00:00
Akhil Narang
3f483790dc
fix(attach): sanitise filename before display
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-03 17:29:03 +05:30
Akhil Narang
2a5b9e45d1
fix(import_preview): sanitize preview data
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-03-03 17:24:20 +05:30
Soham Kulkarni
cf44c42e6f
Merge pull request #31479 from sokumon/better-sidebar
fix: small check to set currrent active sidebar item
2025-03-03 15:08:06 +05:30
Ankush Menat
25c08cacea
perf: skip order by for open_count (#31472)
- Not required, we are just counting
- Helps in *some cases* because no need to scan in modified order.
- Semantically correct anyway so eh.
2025-03-03 14:49:55 +05:30
sokumon
2875eace18 fix: small check to set currrent active sidebar item 2025-03-03 14:44:24 +05:30
gavin
00f8bbc123
Merge pull request #31457 from gavindsouza/fix-quickentry-submit
fix(quick_entry): Show submit option only if User can
2025-03-03 09:48:28 +01:00
Sagar Vora
ab262dc008
Merge pull request #31473 from sagarvora/remove-flag
fix: remove flag to ensure some checks run
2025-03-03 12:03:55 +05:30
Sagar Vora
5c003b67d9 fix: remove flag to ensure some checks run 2025-03-03 11:53:50 +05:30
Soham Kulkarni
b7eedd63a6
Merge pull request #31470 from sokumon/better-sidebar
fix: cleanup active sidebar logic , enhance mobile
2025-03-03 01:02:46 +05:30
sokumon
fca0dd7c63 fix: close sidebar when new item is clicked on mobile 2025-03-03 00:25:49 +05:30
sokumon
250220baa1 fix(refactor): sidebar active logic to depend on breadcrumb 2025-03-03 00:23:30 +05:30
Shariq Ansari
da7190a2ea
Merge pull request #31463 from shariquerik/validate-reset-password
fix: validate before resetting password from website
2025-03-01 16:06:04 +05:30
Shariq Ansari
a84294acab fix: validate before resetting password from website 2025-03-01 14:19:31 +05:30
Soham Kulkarni
d95386edd8
Merge pull request #31287 from sokumon/better-sidebar
fix: more sidebar improvements
2025-02-28 23:54:08 +05:30
Gavin D'souza
279bf82719
fix: Check if doc is in draft before allowing to submit 2025-02-28 16:46:53 +01:00
Gavin D'souza
5930011849
fix(quickentry): Show submit option only if User can
ref: https://github.com/frappe/frappe/pull/26579/files#r1975437243
2025-02-28 14:49:06 +01:00
Ejaaz Khan
a23b790ccb
Merge pull request #31454 from iamejaaz/sticky-datatable-column
chore: update datatable version to add support for sticky column
2025-02-28 14:17:43 +05:30
Ejaaz Khan
d5b532d498 style: format code 2025-02-28 13:29:50 +05:30
Ejaaz Khan
85c22ec156
Merge pull request #30923 from bartoszpijet/develop
fix: event sync from Google Calendar not visible to user
2025-02-28 11:39:35 +05:30
Ankush Menat
e01187e610
fix: Ensure that scheduled jobs don't start in maintenance_mode (#31450) 2025-02-27 09:07:45 +00:00
mergify[bot]
5d270b9f67
fix: Cache thrashing in workspace code (#31446) (#31448)
if result is `[]` then it ignores cache and keeps hitting DB for no
reason.

(cherry picked from commit 20b63f3252f9b23655e34ca830cff426ad5a50a3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
2025-02-27 08:11:53 +00:00
Ankush Menat
8e273d6701
chore: remove doctype overrides from hooks template (#31444)
This is a shit feature, don't advertise it to the world or make it easy
to use it.
2025-02-27 05:50:12 +00:00
Ankush Menat
7110e79926
fix: Avoid killing any system threads (#31442) 2025-02-26 16:07:46 +00:00
Ankush Menat
8baeb5151d
fix: check for running jobs before migrating (#31438) 2025-02-26 09:30:38 +00:00
Soham Kulkarni
8102706116
Merge pull request #31332 from sokumon/remove-view-file
fix: cleanup view file button
2025-02-26 00:05:44 +05:30
Marica
5bf1bacb27
Merge pull request #31433 from marination/translate-footer-items
fix: Translate Footer Items
2025-02-25 18:40:37 +05:30
marination
4dcd579b47 fix: Translate Footer Items 2025-02-25 13:22:57 +01:00
Ankush Menat
c229f5a34a
fix: handle large URL on webhook logs (#31428)
Missed in https://github.com/frappe/frappe/pull/24761
2025-02-25 09:57:29 +00:00
sokumon
9d717091a2 fix: cleanup view file button 2025-02-25 14:41:41 +05:30
Soham Kulkarni
0040c7f852
Merge pull request #31360 from sokumon/attach-file-spam-issue
fix: check if duplicate_file url matches incoming file url
2025-02-25 14:33:35 +05:30
Soham Kulkarni
ce237efd58
Merge pull request #31386 from sokumon/orphan-child-table
fix: add check for child doctype if it has a valid parent
2025-02-25 14:33:20 +05:30
Sagar Vora
19f54c8a6e
Merge pull request #31423 from sagarvora/perf-init-child 2025-02-25 14:12:03 +05:30
Sagar Vora
ffba20a160 perf: faster _init_child 2025-02-25 14:01:09 +05:30
Sagar Vora
7ee16afa3f
Merge pull request #31422 from sagarvora/perf-get-valid-cols 2025-02-25 13:32:48 +05:30
Sagar Vora
aae5860efc perf: faster init_valid_columns 2025-02-25 13:20:35 +05:30
Ankush Menat
573028ad3f
fix: always persist all indexes added via db.add_index (#31177)
* fix: always persist all indexes added via db.add_index

* fix: Add `if not exists` clause for index creation

This allows replica to have same index and master to add it later
without causing SQL error. Just minor DX benefit.

* fix(postgres): don't cache if table doesn't exist

* chore: revert postgres changes

Hopeless to maintain this
2025-02-25 07:25:49 +00:00
Ankush Menat
3485c091e5
Merge pull request #31421 from ankush/form_meta_client_cache
fix: use client_cache for form meta
2025-02-25 12:35:07 +05:30
Ankush Menat
d2fe49c0c2 fix: potential mismatch between meta and formmeta 2025-02-25 12:25:45 +05:30
Ankush Menat
fe3e5021a4 perf: use client_cache for form meta 2025-02-25 12:25:42 +05:30
Ankush Menat
7721fdb054
fix: clear cache using client_cache (#31420)
It's faster than relying on indirect invalidations. This was avoided
before only because delete_keys didn't exist on client_cache.
2025-02-25 06:43:39 +00:00
Sagar Vora
6bbbc916d5
Merge pull request #31419 from sagarvora/update-reserved-words 2025-02-25 12:10:47 +05:30
Sagar Vora
c31cb69d5c fix: update reserved keywords 2025-02-25 12:00:51 +05:30
Ankush Menat
9ef1ad279a
test(health_report): avoid silently failing in tests (#31417) 2025-02-25 05:40:10 +00:00