Marc
7f3f2fef2b
Refactor send method by extracting notification logic into a separate function
...
- Created `send_notification_by_channel` method to handle notification sending by channel and make it easier to extend the channels with a new channel
- Simplified `send` method by moving channel-based notification logic to the new function
2024-11-02 11:58:07 +01:00
Ankush Menat
16407a50ec
fix: Excessive gap locking from hash naming ( #28349 )
...
Because of large common prefix hash naming becomes "too sequential" when
doing a lot of concurrent writes.
I don't know a good tradeoff between both use cases:
1. Lots of reads - prefers large shared prefix.
2. Lots of writes - prefers small shared prefix.
But as of now this punishes writes too badly in form of excessive
locking. Until a better fix is found, it's better to keep it prefix free.
---
A better fix would be a tradeoff of between these two:
1. Reads - temporal locality should result in spatial locality on disk.
2. Writes - temporal locality should NOT result in spatial locality.
temporal locality = data inserted around same time
spatial locality = data sits next to each other in DB pages.
This can be achieved by adding a small request/job specific part to
prefix so each concurrent request has it's own different locality when
writing data.
2024-11-01 06:18:22 +00:00
David Arnold
fcae6050f0
Revert "refactor: place mappers into read-only mode" ( #28347 )
...
This reverts commit 583e4bf3e7b4a1a9930707515b16dba704309c55.
2024-10-31 20:35:28 +00:00
Raffael Meyer
73a04e9a5d
refactor(mapper): use doc.check_permission ( #28316 )
2024-10-31 19:52:47 +01:00
gavin
c01ea099d4
Merge pull request #28326 from gavindsouza/eps-clear_bootinfo
...
fix: Clear cache when EPS enabled/disabled
2024-10-30 10:27:08 +01:00
Gavin D'souza
ae592521fc
fix: Clear cache when EPS enabled/disabled
2024-10-29 13:12:05 +01:00
dependabot[bot]
e0a84e0f18
build(deps): bump actions/setup-python from 4 to 5 ( #28319 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 12:42:00 +01:00
dependabot[bot]
a3f43cebd1
build(deps): bump actions/checkout from 3 to 4 ( #28318 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 12:41:40 +01:00
gavin
85235d1252
Merge pull request #28304 from gavindsouza/enable-sentry-profiling
...
feat: Enable Sentry Sampling
2024-10-29 10:26:00 +01:00
Raffael Meyer
09cdf32f00
fix(Workspace): check perms on deletion ( #28315 )
2024-10-29 00:35:38 +01:00
Raffael Meyer
881d8c8597
fix(Webhook): highlighting for JSON Request Body ( #28313 )
...
The JSON request body is supposed to hold a jinja template which produces valid JSON. The JSON highlightng shows errors when applied to a jinja template.
2024-10-28 23:02:16 +01:00
Frappe PR Bot
c8ff316f94
chore: update POT file ( #28302 )
2024-10-28 18:13:14 +01:00
Gavin D'souza
ecb4795ed3
feat: Enable Sentry Sampling
...
Closes https://github.com/frappe/frappe/issues/28245
2024-10-28 11:27:51 +01:00
David Arnold
61a107b6af
ci: make gh actions functions ( #28299 )
...
* ci: make gh actions downstream reusable
* refactor: merge ci helper into run-parallel-test command
* ci: refactor to sensible db password
2024-10-27 02:09:02 +00:00
Frappe PR Bot
6b28c1a4d7
chore: update POT file ( #28194 )
2024-10-26 19:40:22 +02:00
Sumit Bhanushali
5b718bb60f
Merge pull request #28288 from frappe/sumitbhanushali-patch-1
...
chore(README): remove missed extra space between links to fix link un…
2024-10-25 11:47:17 +05:30
Sumit Bhanushali
00a6d1d76d
chore(README): remove missed extra space between links to fix link underlines
2024-10-25 11:44:37 +05:30
Sumit Bhanushali
73df1614f3
Merge pull request #28285 from frappe/sumitbhanushali-patch-1
...
chore(README): remove extra space between links to fix link underlines
2024-10-25 11:40:33 +05:30
Sumit Bhanushali
a1d4024fa0
chore(README): remove extra space between links to fix link underlines
2024-10-25 11:39:19 +05:30
Raffael Meyer
ce01f8ada8
fix: controller path for exporting types ( #28251 )
2024-10-25 03:13:28 +02:00
David Arnold
46a0814287
chore: start with type checking ( #28190 )
2024-10-24 21:56:25 +00:00
David Arnold
d5fd8d7c20
chore(docref): fix circular imports ( #28282 )
2024-10-24 22:31:12 +02:00
David Arnold
268c33d3ed
fix(typing): hack-hint to type checkers for ide use ( #28257 )
2024-10-24 21:16:05 +02:00
Sumit Bhanushali
54a84777d4
Merge pull request #28278 from frappe/sms_msg_update
...
fix: dont display phone numbers to which sms was sent to
2024-10-24 21:58:41 +05:30
Sumit Bhanushali
0948874c62
fix: dont display phone numbers to which sms was sent to
2024-10-24 21:45:37 +05:30
Akhil Narang
87d7c76d86
Merge pull request #28262 from akhilnarang/change-rename-doc-queue
...
refactor(rename): use long queue by default
2024-10-24 17:17:17 +05:30
David Arnold
52e50ae389
ci: trigger ci runs from upstream fix ( #28273 )
2024-10-24 11:42:18 +00:00
David Arnold
5fb77b39e5
ci: add action to trigger downstream ci runs ( #28272 )
2024-10-24 11:24:23 +00:00
Sumit Bhanushali
bc37b4c4c8
Merge pull request #28268 from frappe/workflow_email_fix
...
fix: use get_email_template to support html template in workflow email
2024-10-24 15:00:12 +05:30
Sumit Bhanushali
b335abb6aa
fix: use get_email_template to support html template in workflow email
2024-10-24 14:43:39 +05:30
Akhil Narang
97bb23960d
refactor(rename_doc): also set a 10 hour timeout
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-10-24 11:25:41 +05:30
Rushabh Mehta
52b6672533
Merge pull request #28260 from rmehta/fix-login-icons
...
fix(minor): login icons
2024-10-23 20:42:13 +05:30
Akhil Narang
d5a73683db
refactor(rename): use long queue by default
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-10-23 17:38:37 +05:30
Rushabh Mehta
be47582975
fix(style): sidebar changes and restore pre-commit
2024-10-23 17:17:09 +05:30
Rushabh Mehta
21a2154dea
fix(minor): login icons
2024-10-23 17:03:59 +05:30
Rushabh Mehta
641c2be822
fix(minor): login icons
2024-10-23 15:39:13 +05:30
David Arnold
9f980e7475
test: add missing test case for get values on single ( #28254 )
2024-10-23 10:47:46 +02:00
Nabin Hait
322ce6f665
fix: get multiple values from single table ( #28252 )
...
* fix: get multiple values from single table
* fix: linter issues
* fix: linter issues
2024-10-23 12:11:23 +05:30
David Arnold
86f70b9e98
chore: inline unnecessary indirection ( #28250 )
2024-10-22 19:33:48 +00:00
Akhil Narang
947054e7e6
Merge pull request #28224 from akhilnarang/reword-backup-restoration-failure-message
...
refactor: update backup restore failure message
2024-10-22 16:51:27 +05:30
Akhil Narang
cab0b2e484
Merge pull request #27398 from Sajith-K-Sasi/develop
...
feat: enable bulk edit for doctype with workflow
2024-10-22 15:57:51 +05:30
Akhil Narang
2c3916f898
refactor: change logic slightly, reformat JSON
...
Invert the check: `disable_edit` -> `allow_edit`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-10-22 15:17:13 +05:30
root
2788c84ce5
refactor: refactored code
2024-10-22 15:17:13 +05:30
root
65db85d559
fix: changed enable edit select option to disable edit checkbox
2024-10-22 15:17:13 +05:30
root
0b9df2b994
feat: enable or disable bulk edit from list view settings doctype
2024-10-22 15:17:13 +05:30
root
d028d24f07
refactor: refactored code
2024-10-22 15:17:13 +05:30
Sajith K
1387bc5603
feat: enable and disable bulk edit for doctype using listview settings
2024-10-22 15:17:13 +05:30
Akhil Narang
b3d9188d08
Merge pull request #28225 from akhilnarang/permission-doctype-string-cast
...
fix(permissions): cast docname to string
2024-10-22 13:23:26 +05:30
Akhil Narang
0243279712
Merge pull request #28217 from cogk/fix-number-format-sysdefault-is-string-not-int
...
fix(format): Fix sysdefault is string not number
2024-10-22 13:19:14 +05:30
Akhil Narang
d47057cbef
fix(permissions): cast docname to string
...
Extension of #24988
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-10-22 13:09:43 +05:30
