David Arnold
894c7d871c
ci: prepare shared action for concrete downstream use ( #28572 )
...
* ci: cleanup setup action
* ci: make migration & setup downstream-ready
* ci: replace obscure bench remove-app with an equivalent rm -rf
2024-11-26 17:11:08 +00:00
Sumit Bhanushali
2b43e13691
Merge pull request #28507 from UmakanthKaspa/feature/multiselect-clear-all
...
Feat: Add Clear All Button to MultiSelect Field
2024-11-26 14:49:09 +05:30
Akhil Narang
b72bc3ab2c
Merge pull request #28574 from akhilnarang/change-filter-type
...
refactor: change filter from tuple to dict
2024-11-26 11:54:30 +05:30
Akhil Narang
a7aa0ded2d
refactor: change filter from tuple to dict
...
While list/dict both work and technically so does a tuple,
the original intention in #13831 seems to have been a dict.
A trailing comma got left behind, which changed it to a tuple.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-26 11:38:15 +05:30
David Arnold
75ed8a8503
ci: small speed up ( #28569 )
...
* ci: small speedup
* chore: small fixes
2024-11-25 19:10:34 +01:00
Akhil Narang
a07e6fc2a9
Merge pull request #28561 from cogk/fix-report-check-select-and-read-permissions
...
fix(query_report): Check both read and select perms
2024-11-25 23:02:47 +05:30
David Arnold
c895d828b4
Revert "ci: temporarily redirect to fixed base workflows" ( #28567 )
...
This reverts commit 5cc6b3c89d4b8290bd0bef9b5f292a43fafa17c2.
2024-11-25 16:59:05 +00:00
Akhil Narang
d9a157e340
Merge branch 'develop' into fix-report-check-select-and-read-permissions
2024-11-25 22:28:49 +05:30
David Arnold
08ef9df94c
ci: fixup bis ( #28566 ) ( #28568 )
...
* ci: ensure new success checks fail when they should
2024-11-25 17:43:50 +01:00
David Arnold
4c5ecfa9e2
ci: fixup ( #28566 )
...
* ci: fixup
* ci: temporarily redirect to fixed base workflows
the purpose of this is to pass checks and get this fixed base workflows into develop asap
2024-11-25 14:34:05 +00:00
David Arnold
9cab72843f
ci: add unified success actions for checks ( #28563 ) [follow up] ( #28564 )
2024-11-25 14:47:21 +01:00
David Arnold
7e6380ddc8
ci: add unified success actions for checks ( #28563 )
2024-11-25 12:48:36 +00:00
Akhil Narang
bb173b189b
Merge pull request #28522 from blaggacao/ci/join-precommit-linters
...
ci: join pre-commit with linters
2024-11-25 17:45:48 +05:30
David Arnold
120566c0a0
chore: organize gh workflow names ( #28562 )
2024-11-25 13:10:02 +01:00
Akhil Narang
045adeebcd
Merge pull request #28300 from blaggacao/ci/factorize-gh-actions-2
...
ci: make use of shared actions
2024-11-25 17:30:52 +05:30
David
8dd2d2b859
ci: join server test and downstream test dispatch
2024-11-25 12:50:46 +01:00
David
54c9ee29c3
ci: join server test and migration test
2024-11-25 12:50:46 +01:00
David
8ee2fdc6e4
ci: use reusable workflow for server tests
2024-11-25 12:50:45 +01:00
Corentin Forler
e1bfc1bedc
fix(query_report): Check both read and select perms
2024-11-25 12:11:29 +01:00
Akhil Narang
d3c45c7519
Merge pull request #28560 from akhilnarang/pre-commit-update
...
chore: update pre-commit config
2024-11-25 13:47:50 +05:30
Akhil Narang
0f27bb495c
chore: update pre-commit config
...
Otherwise there was always a warning:
```
[WARNING] top-level `default_stages` uses deprecated stage names (commit) which will be removed in a future version. run: `pre-commit migrate-config` to automatically fix this.
```
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-25 13:33:50 +05:30
Akhil Narang
72af3e52cb
Merge pull request #28546 from akhilnarang/bump-redis
...
chore: bump dependencies
2024-11-25 13:27:34 +05:30
Akhil Narang
ae868428f5
Merge pull request #28557 from frappe/pot_develop_2024-11-24
...
chore: update POT file
2024-11-25 13:25:55 +05:30
Akhil Narang
3ef785e320
Merge pull request #28553 from cogk/fix-quick-list-add_fields-might-contain-missing-fields
...
fix(quick_list): Ensure fields exist before fetching
2024-11-25 12:56:33 +05:30
Akhil Narang
2670fce9c9
Merge pull request #28544 from akhilnarang/fix-readonly-attachment-webform
...
fix(attach): don't crash when a web form field is read-only
2024-11-25 10:56:57 +05:30
Akhil Narang
0d0951e168
fix(attach): don't crash when a web form field is read-only
...
`this.$input` and `this.$value` are undefined in those cases
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-25 10:43:51 +05:30
frappe-pr-bot
f52ddd0085
chore: update POT file
2024-11-24 09:34:17 +00:00
David Arnold
d8fab7a64f
chore: use deprecation dumpster for remaining deprecated decorator ( #28555 )
2024-11-23 23:50:56 +00:00
Corentin Forler
ecf2976681
fix(quick_list): Ensure fields exist before fetching
2024-11-23 00:26:35 +01:00
David Arnold
e964c11cd6
fix: don't show deprecation on a effective no-op ( #28552 )
2024-11-22 22:45:04 +00:00
Shariq Ansari
4b5cd8e605
Merge pull request #28550 from shariquerik/billing-fix
...
fix: Frappe Cloud Billing
2024-11-22 22:46:01 +05:30
Shariq Ansari
e4fb10e0d2
fix: show trial plan based on is_trial_plan
2024-11-22 22:31:36 +05:30
Shariq Ansari
ab0517a020
fix: added FC login modal with verification code feature
2024-11-22 21:41:33 +05:30
Shariq Ansari
50e19617c0
fix: added api to send verification code and verify and login to fc
2024-11-22 21:40:40 +05:30
Shariq Ansari
e6235ce4f8
fix: changed support url
2024-11-22 21:39:54 +05:30
Sumit Bhanushali
b8f2fb2163
Merge pull request #28547 from frappe/rename_fix
...
fix(DocRename): on rename ignore link validation when updating values…
2024-11-22 16:50:17 +05:30
Sumit Bhanushali
87ef74bb7e
fix(DocRename): on rename ignore link validation when updating values in single doctype
2024-11-22 16:30:32 +05:30
Akhil Narang
076cefc09a
chore(deps): bump Pillow
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-22 16:24:02 +05:30
Akhil Narang
e4b7c89910
chore(deps): bump redis and hiredis
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-22 16:14:14 +05:30
Raffael Meyer
9208b58b6f
refactor: use doc.check_permission ( #28317 )
...
* refactor: use `doc.check_permission`
* refactor(delete_doc): check_permission_and_not_submitted
2024-11-22 10:41:24 +01:00
Shariq Ansari
75bdffb1d6
fix: replaced header h4 with breadcrumbs component
2024-11-22 14:25:56 +05:30
Akhil Narang
b83fb22eda
Merge pull request #28535 from Nihantra-Patel/user_query
...
fix: user_query
2024-11-22 10:22:11 +05:30
Akhil Narang
a350b5c6de
refactor(user_query): adjust query, only check fields if required
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-21 18:08:37 +05:30
Akhil Narang
1a8d9d1122
refactor(user_query): simplify with as_list=True
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-21 18:05:41 +05:30
Akhil Narang
28671afc5a
Merge pull request #28529 from cogk/fix-typo-build_domain_restriced_page_cache
...
fix: Fix typo in build_domain_restriced function names
2024-11-21 15:42:31 +05:30
Nihantra Patel
b250d19153
fix: user_query
2024-11-21 12:20:18 +05:30
Corentin Forler
e0c08fab4e
fix: Fix typo in build_domain_restriced function names
2024-11-20 13:52:19 +01:00
Abdeali Chharchhodawala
5fea212305
fix: Remove typo from get_doc docstring of FrappeClient ( #28515 )
2024-11-20 04:27:13 +00:00
David Arnold
3c1392c8fd
fix: meta signature ( #28526 )
...
* fix: meta
* fix: test case
save is required:
1. Fetch values
```python
def get_invalid_links(self, is_submittable=False):
"""Return list of invalid links and also update fetch values if not set."""
...
```
2. Is triggered by
```python
def _validate_links(self):
if self.flags.ignore_links or self._action == "cancel":
return
...
```
3. Which is triggered by either `_save` or `insert`
----
`reload` does not trigger link fetch
```python
def reload(self) -> "Self":
"""Reload document from database"""
return self.load_from_db()
```
Neither does the new calling path which does not excempt Document
from caching when initializing meta.
It can be proven that this revert would be an alternative fix. But this
seems design by accident and there's no preceivable reason to excempt
Document args from being cached normally.
diff --git a/frappe/model/meta.py b/frappe/model/meta.py
index c4321f0128..87452c812c 100644
--- a/frappe/model/meta.py
+++ b/frappe/model/meta.py
@@ -70,11 +70,10 @@ def get_meta(doctype: str | dict | DocRef, cached=True) -> "_Meta":
Returns:
Meta object for the given doctype.
"""
- if cached and (
- doctype_name := getattr(doctype, "doctype", doctype)
- if not isinstance(doctype, dict)
- else doctype.get("doctype")
- ):
+ if cached and not isinstance(doctype, Document):
+ doctype_name = (
+ getattr(doctype, "doctype", doctype) if not isinstance(doctype, dict) else doctype.get("doctype")
+ )
if meta := frappe.cache.hget("doctype_meta", doctype_name):
return meta
Therefore, we comply the test.
2024-11-20 04:17:38 +00:00
David Arnold
15d122025f
feat: get_meta can derive meta from dict ( #28525 )
2024-11-20 01:36:04 +00:00
