Rushabh Mehta
20986060ca
fix(style): set min height correctly
2024-01-08 14:32:25 +05:30
Shariq Ansari
2969b6eff1
fix: added precision field in webform field
2024-01-08 14:24:16 +05:30
14987
f3af2d054e
fix: Add confirmation box before removal
2024-01-08 13:49:22 +05:30
Akhil Narang
b9923571dc
fix: check correct part of backup header
...
`-- Backup generated by Frappe 15.1.0 on branch fix-backup-restore`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-08 13:06:59 +05:30
Rushabh Mehta
eb0e8262a7
fix(minor): Don't load user_info for Administrator twice. fixes #22211 ( #24160 )
2024-01-08 12:51:32 +05:30
Ankush Menat
f6388f6357
fix: Skip no-value fields for rename ( #24163 )
2024-01-08 12:50:34 +05:30
Ankush Menat
c1d687ddbb
fix: ignore user settings on report doc ( #24162 )
2024-01-08 12:42:13 +05:30
Rushabh Mehta
482813e46d
Merge pull request #24155 from rmehta/fix-help-category-unpublish
...
fix(minor): Unpublish article when category is unpublished #15361
2024-01-08 12:30:34 +05:30
Rushabh Mehta
5275f393c7
fix(minor): drop icon column, unsupported, fixes #23826
2024-01-08 12:07:10 +05:30
Rushabh Mehta
04646024cb
fix(minor): show footer on login via Website Settings, fixes #24153
2024-01-08 11:56:51 +05:30
Rushabh Mehta
cb2e803d0c
fix(minor): Unpublish article when category is unpublished #15361
2024-01-08 11:39:02 +05:30
Safwan Samsudeen
d0157f7862
fix: mobile issue with form pop up ( #24125 )
...
* fix: mobile configure columns issue
* fix: correct grid view issue
* fix header too
2024-01-07 18:17:30 +05:30
Corentin Flr
c6bdc7fe45
fix(workspace): Fix widget rendering for EditorJS v2.28 ( #23918 )
...
* fix(workspace): Ensure Block.render() always return an element
If `has_data` is false, then `this.wrapper` is still empty (because it was just created and `this.make` did nothing), so it's safe to give it back to EditorJS for rendering.
* build(deps): Bump EditorJS
2024-01-07 12:36:55 +05:30
Akhil Narang
745080c56e
fix(test_recorder): get the correct request ( #24143 )
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-06 09:42:53 +05:30
Raffael Meyer
3fd26775b3
fix(Web Form): make button label translatable ( #24122 )
...
* fix(web Form): make button label translatable
* fix: context in web form translations
2024-01-05 23:32:53 +05:30
Akhil Narang
232da65e4c
fix(restore): check backup directory and bench directory if we can't find the file
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-05 15:42:31 +05:30
Kevin Shenk
4ec4594c62
fix: notification.py should ignore permissions on fetching on mobile_no receiver list
...
Similar to fetching the email list in `get_list_of_recipients()`, the `get_info_based_on_role` call to fetch `mobile_no` in `get_receiver_list()` should set `ignore_permissions` in order to allow sms notifications to send based on actions of limited and anonymous users (e.g. web form submissions).
2024-01-05 04:49:33 -05:00
Ankush Menat
f7ff072b5a
test: fix ui tests ( #24136 )
...
caused by https://github.com/frappe/frappe/pull/24077
2024-01-04 14:38:24 +00:00
Fadil SIddique
941b5faf65
fix: number card only gives integer ( #24047 )
...
* fix: number card only gives integer
* fix: replace float with flt
* fix: minor fix
---------
Co-authored-by: fadilsid <fadil@tridz.com>
2024-01-04 19:47:45 +05:30
Corentin Flr
7f9331fc8d
fix(router): Don't capture clicks on links with target attr ( #24110 )
2024-01-04 19:42:45 +05:30
Ankush Menat
3916398f1a
fix(recorder): Normalize IN in SQL queries ( #24132 )
2024-01-04 19:08:59 +05:30
Akhil Narang
9586b5f18a
fix(execute_in_shell): run explicitly in bash
...
`pipefail` isn't supported in sh, bash is common enough to be installed nearly everywhere
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-04 19:07:28 +05:30
Ankush Menat
022be815dd
Merge pull request #24118 from ankush/imap_failure_messages
...
fix: Broken IMAP account disabling logic
2024-01-04 18:56:52 +05:30
Akhil Narang
58a13cfb3e
refactor: set pipefail in shell before running piped backup/restore commands
...
Drop the complicated logic behind storing pid and killing process if first stage of pipe fails
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-04 18:41:37 +05:30
Ankush Menat
cc2bb85484
fix: correct arg type
...
assign_to expects a list of strings of users not a single string.
2024-01-04 18:39:15 +05:30
Raffael Meyer
edac879d7e
refactor!: remove unused parameter from rebuild_tree, add type hints ( #24123 )
...
* refactor!: remove unused parameter from rebuild_tree, add type hints
* fix: remove parent_field parameter from backend calls
2024-01-04 18:13:12 +05:30
Ankush Menat
3836d942ac
fix: logic to disable broken account
...
This doesn't work because when email is broken we still continue and
down the line changes get rolled back.
2024-01-04 17:39:25 +05:30
Ankush Menat
71908f1e00
refactor: respect multi-tenancy
...
redis set/get don't consider site
2024-01-04 17:39:25 +05:30
Ankush Menat
807cfd66f1
fix: Reset failed attempts ONLY if succesful connection is made
2024-01-04 17:39:25 +05:30
Akhil Narang
6acbdbfc97
Merge pull request #24103 from akhilnarang/background-jobs-recorder
...
feat: support background jobs in recorder
2024-01-04 17:08:27 +05:30
Raffael Meyer
dd690c79d1
fix: use correct parent field in rebuild_tree() ( #24107 )
...
* fix: use correct parent field in rebuild tree
* refactor!: ignore parent_field parameter to rebuild_tree
2024-01-04 16:07:39 +05:30
Akhil Narang
35ea093b51
feat: support background jobs in recorder
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-04 15:51:26 +05:30
Ankush Menat
92c4d291c9
Merge pull request #24111 from ankush/perm_messages
...
fix(UX)!: permission error messages
2024-01-04 10:54:41 +05:30
Ankush Menat
94f53d3f91
fix!: frappe.has_permission(throw=True) works as expected
...
- This wasn't throwing PermissionError
- It was erasing all perm check messages
2024-01-04 10:37:07 +05:30
Ankush Menat
3349f2b6e6
fix: nested has_permission calls erase messages
2024-01-04 10:31:55 +05:30
David Arnold
94d2c0af2b
feat: add link preview capability to tree view
2024-01-03 23:58:33 +01:00
Ankush Menat
04acd0bda4
fix: don't add fallback for child table ( #24105 )
2024-01-03 12:18:06 +00:00
Ankush Menat
cc9679ac76
Merge pull request #24086 from AlexandreLumertz/patch-1
...
fix: timeout occurs when there are too many users linked to the profile
2024-01-03 15:54:10 +05:30
Ankush Menat
1a9aba2858
test: remove invalid assertion ( #24101 )
...
This workspace no longer exists so test fails.
2024-01-03 15:53:30 +05:30
Ankush Menat
3a7efa9ad1
perf: Update roles affected by role profile in background
2024-01-03 15:37:48 +05:30
Ankush Menat
b0d73336a5
Merge pull request #24096 from ankush/hl_report
...
fix: syntax highlighting in report
2024-01-03 15:30:15 +05:30
Ankush Menat
6e8fe0f855
fix(DX): Correct syntax highlighting in report
2024-01-03 15:29:24 +05:30
Ankush Menat
6ac6b69b83
fix: syntax highlighting in system console
2024-01-03 15:26:20 +05:30
Ankush Menat
3dfb2d0d4f
fix: hide script in query report
...
It's not used at all so why show it?
2024-01-03 15:14:51 +05:30
Shariq Ansari
e6d0d9ab12
Merge pull request #24093 from shariquerik/bump-datatable-4
...
build(deps): bump datatable to latest
2024-01-03 15:01:29 +05:30
Shariq Ansari
1659f01f05
build(deps): bump datatable to latest
2024-01-03 14:57:41 +05:30
Ankush Menat
6594fde7f9
Merge pull request #24054 from frappe/dynamic-link-format
...
fix: broken `dynamic_link` to `link` formatting in query report
2024-01-02 19:33:54 +05:30
Raffael Meyer
bb6911101e
fix: remove Guest permission on Help Article ( #24082 )
2024-01-02 16:20:20 +05:30
Rushabh Mehta
4c9bf957d8
Merge pull request #24077 from rmehta/remove-settings-workspace
...
fix(minor): Remove unused Settings workspace and some minor style fixes
2024-01-02 15:49:04 +05:30
Rushabh Mehta
d1f2f42015
fix(minor): move missing settings to tools
2024-01-02 15:47:53 +05:30
