Commit graph

45534 commits

Author SHA1 Message Date
Ankush Menat
9bbb5ea409
Merge pull request #25137 from ankush/print_failure_ux
fix: escalate print failures
2024-02-28 17:01:02 +05:30
Ankush Menat
dbc2e092f1 fix: escalate print failures
Print failures shouldn't generate PDF with failure message but instead escalate the error.

This prevent all the PDFs that just contain "PermissionError" from being sent.
2024-02-28 16:42:03 +05:30
Ankush Menat
3237abdc7b
Merge pull request #25135 from ankush/guess_default_language
fix(UX): set default print language from print format
2024-02-28 15:31:34 +05:30
Ankush Menat
c00a34d023 fix(UX): set default print language from print format 2024-02-28 15:25:58 +05:30
Ankush Menat
c293a35dda
Merge pull request #25131 from ankush/specify_lang_communication
fix: specify print_language in communication attachments
2024-02-28 14:32:28 +05:30
Ankush Menat
a4ddb7491d fix: specify print_language in communication attachments 2024-02-28 14:19:28 +05:30
Ankush Menat
91d10ffb31
Merge pull request #25128 from ankush/lang_print_format
fix: Use current language in attachment prints
2024-02-28 14:03:06 +05:30
Ankush Menat
870c92f7ea fix: Use current language in attachment prints 2024-02-28 13:50:48 +05:30
Akhil Narang
16489b342b
Merge pull request #25125 from akhilnarang/bg-job-docstring
refactor: update docstring and typehints for functions
2024-02-28 11:30:43 +05:30
Rucha Mahabal
82179f908d
Merge pull request #24114 from tanmoysrt/integrate_frappe_notification
feat: add frappe push notification client
2024-02-28 11:27:57 +05:30
Rucha Mahabal
8305affddd chore: Add Push Notification Settings to Integrations workspace 2024-02-28 11:07:22 +05:30
Rucha Mahabal
3450c1ae1e chore: fix type hints 2024-02-28 01:10:43 +05:30
Rucha Mahabal
2e79f6acb4 feat: add descriptions to Push Notification Settings
- mark it as beta

- validate relay server url key
2024-02-28 01:09:46 +05:30
Ankush Menat
3ac30956c9
fix: Check perm for library file before cloning (#25117) 2024-02-27 18:15:20 +00:00
Ankush Menat
fe9fbf82d0
fix: validate fetch from (#25116) 2024-02-27 23:38:49 +05:30
Ankush Menat
c60edc9a77
refactor: file perm check (#25106) 2024-02-27 16:45:29 +00:00
Ankush Menat
bb7c3c289c
feat: support array request type (#25109)
There can be external APIs like webhooks that only send array request,
in which case Frappe has no mechanism to accept such requests.

After this PR such request data can be accessed using `data` list
argument on function.

I've considered directly storing list in form_dict but it's not
feasible:
1. It breaks semantics, "form_dict" can't be a list. That ship has long
   sailed.
2. Way too much code expects form_dict to be a dict.
2024-02-27 16:41:33 +00:00
Niraj Gautam
911846368f
feat: Add doc rename hook in server script (#25085)
* feat: Add doc rename hook in server script

* feat: Add test case for doc event in server script
2024-02-27 22:07:22 +05:30
Ankush Menat
01d29283f1
fix: restrict method for security critical endpoints (#25105) 2024-02-27 16:10:33 +00:00
David Arnold
c66d35fe5b
fix(notification): ensure outgoing mail is set on comms (#24814) 2024-02-27 16:47:46 +05:30
Ankush Menat
f086b7febd
fix: Avoid add "null" to cc in communication in timeline (#25092)
* Avoid add "null" to cc

* chore: extend fix to BCC

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-02-27 14:45:37 +05:30
Ankush Menat
2f6ec63447
chore: extend fix to BCC 2024-02-27 14:44:21 +05:30
Md Hussain Nagaria
9aa6eb39da
chore: replace fb link with frappe school link in about dialog (#25093) 2024-02-27 08:52:54 +00:00
tonspar
94fefa31a8
Avoid add "null" to cc 2024-02-27 09:40:34 +01:00
Raffael Meyer
2371bdadc9
ci: skip videos for successful tests (#25083)
* ci: skip videos for successful tests

Nobody will spend hours watching successful test cases. We're only interested in the failing ones, so we can save some time here.

* ci: remove outdated cypress config

"The videoUploadOnPasses configuration option was removed in Cypress version 13.0.0."
2024-02-27 13:58:53 +05:30
Raffael Meyer
0ee091a6f9
refactor: saparate click handlers for "load more" and "change page length" (#25080) 2024-02-27 13:10:46 +05:30
Raffael Meyer
b3ff1f9fcc
perf: remove specific elements instead of re-rendering entire list (#25078) 2024-02-27 13:08:26 +05:30
Akash Tom
98fac311a8
fix(File Uploader): call 'upload_files' without passing event object (#25034) 2024-02-27 12:43:03 +05:30
Akhil Narang
1ca98566d4
fix(background_jobs): update type hint and docstring
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-27 12:20:13 +05:30
Alan
6cf8f4ecae
Merge pull request #24317 from blaggacao/chore/cleanup-esbuild-path-resolution
chore: remove confusing indirections from esbuild path resolution
2024-02-27 11:09:37 +05:30
Corentin Flr
0934dfea93
fix(formatters): Translate Select value in format_value (#24951) 2024-02-26 21:05:44 +05:30
Corentin Flr
80bcfff79d
fix(ControlTime): Don't set datepicker's date if field is read only (#25038) 2024-02-26 20:20:50 +05:30
Maharshi Patel
ce2d91c751
feat: hook for print format template loader (#25037)
* feat: hook for print format template loader

currently logic for how print format template should be loaded is hardcoded
added hook to allow for custom logic to be implemented by other apps.

if hook returns falsy value, then default logic will be used.

* chore: use Walrus Operator and handle Empty Hooks
2024-02-26 20:20:25 +05:30
Raffael Meyer
501297b71c
perf: don't process checks if there are none (#25063) 2024-02-26 20:12:31 +05:30
Ankush Menat
1b4fe29da2
Merge pull request #25066 from barredterra/progressive-list-render
refactor: render list progressively
2024-02-26 20:12:09 +05:30
Ankush Menat
c34d350223
Merge pull request #25040 from barredterra/edit-table-row-tooltip
fix: show tooltip on edit table row
2024-02-26 20:05:22 +05:30
Raffael Meyer
7f44f020a6
perf: avoid unnecessary json parsing (#25065) 2024-02-26 19:58:57 +05:30
barredterra
7781f4344c refactor: render list progressively 2024-02-26 15:12:18 +01:00
Jannat Patel
898f982a88
fix: replaced created by with owner in base_document (#25059) 2024-02-26 12:12:26 +00:00
Akhil Narang
ad15ee7183
Merge pull request #25041 from barredterra/row-no-label
fix: add context for row number label
2024-02-26 14:13:51 +05:30
Ankush Menat
a1d295fe07
Merge pull request #25050 from frappe/impersonate
feat: Impersonate a user
2024-02-24 18:43:37 +05:30
Ankush Menat
24499d93f8 fix: notify user that they were impersonated 2024-02-24 18:31:10 +05:30
Ankush Menat
be47ee0e31 fix: track all impersonated changes 2024-02-24 18:25:09 +05:30
Ankush Menat
0fd4d6b67f fix: log activity for impersonations 2024-02-24 18:25:09 +05:30
Ankush Menat
c58ac809ac fix: Flag impersonated sessions 2024-02-24 18:25:09 +05:30
Ankush Menat
ecc9ff378e feat: impersonate any user as Administrator 2024-02-24 18:25:07 +05:30
Ankush Menat
2588de6384
fix: invalid lru_cache usage (#25046)
- using it on closure is useless because a new cache is created
and destroyed everytime.
2024-02-24 12:04:18 +05:30
Raffael Meyer
6cdc1dc502
Merge pull request #25043 from barredterra/translate-doctype-error 2024-02-24 02:53:01 +01:00
barredterra
b6f12db08c fix: translate doctype in user-facing error message 2024-02-24 02:39:29 +01:00
barredterra
fa0b59aa70 test: cypress form 2024-02-23 22:49:10 +01:00