Commit graph

2391 commits

Author SHA1 Message Date
Ankush Menat
dbc2e092f1 fix: escalate print failures
Print failures shouldn't generate PDF with failure message but instead escalate the error.

This prevent all the PDFs that just contain "PermissionError" from being sent.
2024-02-28 16:42:03 +05:30
Ankush Menat
e46ded10c0
fix: keep 3 recent versions of website themes around (#25029)
For whatever unknown reason (https://github.com/frappe/frappe/issues/22205) website theme cache can be invalid or it might fail to generate correctly.

In such cases website becomes unusable, this PR tries to keep it usable.
2024-02-23 10:02:47 +00:00
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Akhil Narang
aa38d9e2f4
refactor: pipeline wherever possible, optimize calls
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-19 14:28:35 +05:30
Ankush Menat
72c2207e0f refactor: useless use of dict in frappe.get_doc 2024-02-10 12:52:38 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Suraj Shetty
2243c5ebe3 fix: Resolve conflicts 2024-02-05 15:51:22 +05:30
Suraj Shetty
2bf82e80ba fix: Make sure sitemap respects robot_txt 2024-02-05 15:41:05 +05:30
Corentin Flr
c9c8414562
fix(website): Handle virtual DocTypes webview routing (#24445)
Co-authored-by: Charles-Henri Decultot <chdecultot@dokos.io>
2024-02-05 12:47:09 +05:30
David Arnold
c09f48f5d7
feat: comply trackers with utm and add utm_content for a/b testing (#24521)
* feat: comply trackers with utm and add utm_content for a/b testing

* fix: make all other than source optional

this is plausible.io best practice

* fix: medium is not specified to be lowercase

* fix: ensure proper parameter quoting
2024-02-02 11:33:22 +05:30
Ankush Menat
dd6f20b301
Merge pull request #24644 from ankush/clear_sitemap_cache
fix: clear sitemap cache periodically
2024-01-31 18:41:54 +05:30
Ankush Menat
ffb9c9cf6a fix: clear sitemap cache periodically 2024-01-31 18:25:28 +05:30
Rucha Mahabal
53d6d156ec
chore: cleanup doctype descriptions (#24609) 2024-01-31 12:00:39 +05:30
barredterra
9d6cbd0c15 fix: typos 2024-01-24 02:41:03 +01:00
Maharshi Patel
65af4b8dbf
fix(minor): increase rate limit for web form (#24295)
increased rate limit for web form to 10 requests per minute.
2024-01-12 20:58:34 +05:30
Shariq Ansari
6d40d1c6da
Merge pull request #24170 from shariquerik/precision-in-webform
fix: added precision field in webform field
2024-01-08 14:57:30 +05:30
Suraj Shetty
4b375006bf
Merge pull request #24157 from rmehta/fix-login-footer-visibility 2024-01-08 14:46:34 +05:30
Shariq Ansari
e2bc379b23 fix: get precision data while getting fields 2024-01-08 14:33:31 +05:30
Shariq Ansari
2969b6eff1 fix: added precision field in webform field 2024-01-08 14:24:16 +05:30
Rushabh Mehta
482813e46d
Merge pull request #24155 from rmehta/fix-help-category-unpublish
fix(minor): Unpublish article when category is unpublished #15361
2024-01-08 12:30:34 +05:30
Rushabh Mehta
5275f393c7 fix(minor): drop icon column, unsupported, fixes #23826 2024-01-08 12:07:10 +05:30
Rushabh Mehta
04646024cb fix(minor): show footer on login via Website Settings, fixes #24153 2024-01-08 11:56:51 +05:30
Rushabh Mehta
cb2e803d0c fix(minor): Unpublish article when category is unpublished #15361 2024-01-08 11:39:02 +05:30
Raffael Meyer
3fd26775b3
fix(Web Form): make button label translatable (#24122)
* fix(web Form): make button label translatable

* fix: context in web form translations
2024-01-05 23:32:53 +05:30
Raffael Meyer
bb6911101e
fix: remove Guest permission on Help Article (#24082) 2024-01-02 16:20:20 +05:30
barredterra
cd37bf0337 fix(Blog Post): correct indicator filter 2023-12-30 01:37:53 +01:00
Ankush Menat
8c515a9a5d fix: correct perm check for guests
Allow viewing document page if doctype allows guest to view
2023-12-29 17:59:39 +05:30
Ankush Menat
38314aec59
fix: Check permissions before rendering web view (#24032) 2023-12-29 17:07:17 +05:30
Suraj Shetty
529d0aa5a7
Merge pull request #24018 from surajshetty3416/hook-to-add-custom-route-resolver 2023-12-29 06:53:18 +05:30
Suraj Shetty
a51a150376 feat: Hook to add custom route resolver 2023-12-29 06:33:59 +05:30
Akhil Narang
ff4dca3e16
fix(redirect): make the status codes a select field instead of int
Drop mandatory, assume sane defaults
The current implementation broke old users of redirects like helpdesk app

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-22 12:25:41 +05:30
Ankush Menat
36451b6951
Merge pull request #23765 from akhilnarang/http-307-redirect
feat: allow setting a custom http status code for redirects
2023-12-21 13:53:51 +05:30
Ankush Menat
0fd6f5eed7
Merge pull request #23827 from frappe/api-docs
docs: add Python API missing docstrings / type hints
2023-12-21 12:13:05 +05:30
Akhil Narang
2224d86c94
refactor: cache status code as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-20 17:47:16 +05:30
Akhil Narang
6819a38fbe
fix: set correct response code for redirections
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-20 17:36:42 +05:30
Akhil Narang
44667901bf
feat: allow setting a custom http status code for redirects
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-20 17:36:42 +05:30
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
barredterra
70c7315ed8 Merge branch 'develop' into jinja-syntax 2023-12-17 19:54:16 +01:00
Ankush Menat
174e24f159 fix: validate custom portal menu entries during sync 2023-12-13 17:55:05 +05:30
Ankush Menat
957f9a01b5
fix: discard deleted doctypes unconditionally (#23770) 2023-12-13 15:57:18 +05:30
Arjun
8e4b0ade78
fix: remove web_form rate limit key (#23767) 2023-12-13 15:39:10 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified (#23697)
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
barredterra
468f3c6738 feat(Web Template): switch from pure HTML to Jinja highlighting 2023-12-12 20:06:45 +01:00
Suraj Shetty
bc2b41d2f5 perf: Simplify dynamic route evaluation to speed up route resolution
validate complete route only if starting of the path matches with the webform route

This avoids the expensive matching from huge route_map (in sites with lots of web forms)
2023-12-08 21:15:34 +05:30
Suraj Shetty
7452e71d02 perf: Use get_cached_doc instead of get_doc
- Makes document pages with no-cache load a bit faster
2023-12-08 20:55:25 +05:30
Ankush Menat
57699a54b1
fix: Show server script name in traceback (#23676)
* fix: Show server script name in traceback

* chore: typo

Co-authored-by: Sagar Vora <sagar@resilient.tech>

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-12-08 15:01:13 +05:30
barredterra
c35476256f refactor: simplify conditional logic
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Ankush Menat
15384f88e0 chore: dead code/comment 2023-11-29 22:11:37 +05:30
Ankush Menat
74a3e24653
Merge pull request #23490 from ankush/preload_headers
fix: Only preload icons for desk
2023-11-29 22:07:09 +05:30