Commit graph

44325 commits

Author SHA1 Message Date
Ankush Menat
a7137bdeaa feat: client side error reporting + sentry
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-30 17:13:41 +05:30
Ankush Menat
cccb95387c build(deps): add sentry/browser dependency 2023-11-30 17:13:41 +05:30
Raffael Meyer
8c9275ba4e
fix: add blank line after auto-generated types (#23430) 2023-11-30 13:22:28 +05:30
Ankush Menat
c23771475c
refactor: Use hooks to specify default log clearing (#23507) 2023-11-30 13:06:29 +05:30
Abdo Hamoud
ba1d597e73
fix: image cropper in RTL mode (#23492) 2023-11-30 11:13:11 +05:30
Lucas Z
92684ab029
Update de.csv (#23478) 2023-11-30 00:21:31 +05:30
Raffael Meyer
7e08f003b3
fix: translate customize form (german) (#23497)
* fix: show translated doctype names

* fix: german translations for customize form
2023-11-30 00:18:52 +05:30
Thomas Fojan
043c004c01
fix!: switch google drive picker to gis (#23096)
* fix: switch google drive picker to gis

* fix: switch google drive picker to gis (linting)

* fix: switch google drive picker to gis (prettier)

* fix: remove restrictions on file types

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

* fix: show navigator

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

* fix: no multiselect for files

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

* refactor: get rid of jquery

* fix: don't add script twice

* refactor: remove unused properties

* refactor: store access token in one place only

* refactor: make tokenClient a local constant

* fix: set locale

* refactor: async calls

* fix: don't store access token

It's one-time use anyway.

* fix: scope for allowing file upload

* reafctor: rename libsLoaded() to autthenticate()

---------

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2023-11-29 23:39:43 +05:30
Ankush Menat
f01937c788
fix(DX): return email queue doc (#23495) 2023-11-29 17:34:42 +00:00
Ankush Menat
15384f88e0 chore: dead code/comment 2023-11-29 22:11:37 +05:30
Ankush Menat
74a3e24653
Merge pull request #23490 from ankush/preload_headers
fix: Only preload icons for desk
2023-11-29 22:07:09 +05:30
Ankush Menat
957293bd54 fix: Only preload icons for desk 2023-11-29 21:50:18 +05:30
mergify[bot]
44ef719685
Merge pull request #23491 from cogk/fix-knowledge-base-cache
fix(kb): Fix cache not being cleared
2023-11-29 15:50:41 +00:00
Corentin Flr
932ef76da3
chore(kb): Drop unused parameter path 2023-11-29 16:12:01 +01:00
Corentin Flr
5781a913c7
refactor(kb): Rename clear_website_cache to clear_knowledge_base_cache 2023-11-29 16:09:04 +01:00
Corentin Flr
d432ff7a08
refactor(kb): Don't call website.utils.clear_cache again
Indeed, `website.utils.clear_cache` is already called by `WebsiteGenerator.clear_cache` the parent class of Help Article/Category.
2023-11-29 16:09:04 +01:00
Corentin Flr
4b3ddf30f3
fix(kb): Fix cache clearing not being triggered 2023-11-29 16:09:04 +01:00
Ankush Menat
ddb40e6a36
Merge pull request #23488 from frappe/unit
refactor: Avoid alias for dashboard chart
2023-11-29 16:45:47 +05:30
Ankush Menat
b2dafe5acd refactor: Avoid alias for dashboard chart 2023-11-29 13:12:53 +05:30
Alan
049f3c9323
Merge pull request #23485 from frappe/fix-sidebar-override
fix: set `sidebar_items` only if not present
2023-11-28 22:56:49 -08:00
18alantom
5722d9c2ba fix: set sidebar only if not present
The get_context of some templates set their own sidebar
if this is done, no need to override
2023-11-29 12:11:34 +05:30
Rushabh Mehta
46412cb1b9
Merge pull request #23453 from rmehta/espresso-fixes-nov-23
fix(minor): some more espresso polish
2023-11-29 11:39:50 +05:30
Sagar Vora
1490fc1ba6
perf: avoid double local caching webhooks (#23426)
### Changes Made

- remove cache in `frappe.flags` (and related comment)
- use cache generator
- ⚠️ micro optimisation: use a variable for `frappe.flags`
2023-11-29 03:10:04 +00:00
Ankush Menat
b6edc207a4
Merge pull request #23147 from barredterra/email-attachments-checkbox
fix: max-width of email attachment filename
2023-11-29 08:37:15 +05:30
barredterra
8850650356 Merge remote-tracking branch 'upstream/develop' into email-attachments-checkbox 2023-11-28 22:37:19 +01:00
Shariq Ansari
8c4f2829c8
Merge pull request #23479 from shariquerik/add-section-below 2023-11-28 19:35:09 +05:30
Shariq Ansari
14d1fc5df3
Merge pull request #23379 from RitvikSardana/develop-ritvik-link-filters-for-link-field 2023-11-28 13:25:30 +05:30
Ankush Menat
caf2c45ed0
Merge pull request #23435 from barredterra/validate-newsletter-recipients
fix: validate newsletter recipients
2023-11-28 07:39:38 +05:30
Ankush Menat
1def5f3d7b
Merge pull request #23462 from barredterra/collapsible-pointer
fix: show pointer only if section is collapsible
2023-11-28 07:35:49 +05:30
Raffael Meyer
380a67777a
fix: commit after each write
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-27 20:12:14 +01:00
barredterra
0cd7ee091f fix: show pointer only if collapsible 2023-11-27 20:01:04 +01:00
Ankush Menat
6e8a36ca96
Merge pull request #23417 from niraj2477/comm-send-after
feat(Communication): Schedule Send
2023-11-27 20:57:01 +05:30
Ankush Menat
d61022536f fix(UX): Indicate that email is scheduled 2023-11-27 20:50:40 +05:30
Ankush Menat
ded94bf050 Merge branch 'develop' into comm-send-after 2023-11-27 20:27:59 +05:30
Shariq Ansari
486d207163
Merge pull request #23439 from barredterra/awesomebar-href 2023-11-27 19:10:14 +05:30
Ankush Menat
8edf3e377f
Merge pull request #23437 from deepeshgarg007/ignore_mapped_doc
chore: Provision to ignore child mapping using get mapped doc
2023-11-27 18:00:40 +05:30
Ankush Menat
1a2c0951ea
Merge pull request #23459 from akhilnarang/fix-print-crash
fix(router): handle exceptions when trying to JSONify a circular reference
2023-11-27 17:59:58 +05:30
Akhil Narang
58fb1d5f0c
fix(router): handle exceptions when trying to JSONify a circular reference
router.js:373 Uncaught (in promise) TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'frappe.ui.form.Form'
    |     property 'grids' -> object with constructor 'Array'
    |     index 0 -> object with constructor 'frappe.ui.form.ControlTable'
    --- property 'frm' closes the circle
    at JSON.stringify (<anonymous>)
    at router.js:373:65
    at Array.map (<anonymous>)
    at Promise.finally.frappe.route_flags (router.js:373:7)
    at new Promise (<anonymous>)
    at Object.set_route (router.js:360:10)
    at frappe.set_route (router.js:567:33)
    at frappe.ui.form.Form.print_doc (form.js:1276:10)
    at HTMLButtonElement.<anonymous> (toolbar.js:330:14)
    at HTMLButtonElement.dispatch (jquery.js:5135:27)
    at Rt.handle (jquery.js:4939:28)
    at HTMLButtonElement.i (helpers.ts:95:1)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-27 17:45:28 +05:30
Ankush Menat
6330c1b209
Merge pull request #23456 from cogk/chore-translation-remove-trailing-space
chore(translations): Remove extra space at end of line
2023-11-27 17:08:56 +05:30
Ankush Menat
e1534b7521
Merge pull request #23455 from frappe/drop_bad_not_so_useful_tests
chore: Drop some ui tests
2023-11-27 17:05:31 +05:30
Corentin Flr
82623e5977
chore(translations): Remove extra space at end of line
When editing translation CSV manually in a text editor, one does not always disable the "trim trailing whitespace" feature. This can lead to mis-translations and duplications (when using `bench get-untranslated`).
2023-11-27 12:17:27 +01:00
Ankush Menat
4a70ac4e4e chore: Drop some ui tests
- Either not important and flaky
- Or badly written using weird selectors and flaky

Not touching things that work.
2023-11-27 16:40:39 +05:30
barredterra
dbe6ae351f fix: handle string routes 2023-11-27 11:47:28 +01:00
Rushabh Mehta
57d911af98 fix(minor): some more espresso polish 2023-11-27 16:03:36 +05:30
Ankush Menat
4510471c6d
Merge pull request #23025 from bosue/awesomebar_fix_filter_on_same
fix!: Make router always take query parameters into account.
2023-11-27 15:44:18 +05:30
Ankush Menat
a8c943fbdd
Merge pull request #23446 from rmehta/system-settings-tabs
refactor: Add tabs to "System Settings"
2023-11-27 15:31:56 +05:30
Ankush Menat
db319700ad
Merge pull request #23443 from ankush/simpler_comparison
fix: Simpler oauth token validity checks
2023-11-27 15:30:43 +05:30
Shariq Ansari
7602174871 fix: add section below 2023-11-27 15:21:13 +05:30
Shariq Ansari
c19f426bd5
Merge pull request #23447 from shariquerik/allow-internal-routing-using-url-option 2023-11-27 15:15:46 +05:30
Shariq Ansari
597a53e4c1 fix: allow internal routing using workspace shortcut url option 2023-11-27 14:20:27 +05:30