vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
46422 commits 1 branch 0 tags 587 MiB
Commit graph

46422 commits

This branch
This branch
All branches
Author SHA1 Message Date
Akhil Narang
b2e3f3dcdd
Merge pull request #26446 from akhilnarang/fix-FRAPPE-698 
fix(grid_row): don't crash when undefined
 2024-05-16 13:10:38 +05:30
Akhil Narang
0892609710
fix(grid_row): don't crash when undefined 
TypeError: Cannot read properties of undefined (reading 'fields')
  at frappe.ui.form.ControlTable.get_field(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table.js:120:18)
  at HTMLInputElement.<anonymous>(../../../../../apps/frappe/frappe/public/js/frappe/form/controls/table.js:46:13)
  at jQuery.event.dispatch(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:5135:27)
  at elemData.handle(../../../../../apps/frappe/node_modules/jquery/dist/jquery.js:4939:28)
  at sentryWrapped(../../../../../apps/frappe/node_modules/src/helpers.ts:98:1)

Sentry FRAPPE-698

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-16 12:56:02 +05:30
Maxim Sysoev
557293adfe
feat: show link field title in sidebar filters if set (#26417) 
* feat: In sidebar filter link field show Title of Field if set (#26413)

* fix: test_list_view_child_table_filter_with_created_by_filter

* fix tests

* fix: formatting

* fix: formatting

* refactor: cleanup logic slightly, reduce code repetition

Respect value of show_title_field_in_link

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-15 12:48:05 +00:00
Akhil Narang
3a4dd9a671
Merge pull request #26183 from vmatt/data_import_delimiter 
feat(Data Import): custom csv delimiters, UTF-8 BOM handling
 2024-05-15 16:45:31 +05:30
Akhil Narang
9986ea8171
chore: update labels and a comment 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-15 16:29:55 +05:30
Raffael Meyer
5cb9f04bca
Merge pull request #26429 from cogk/fix-dont-add-decontextualized-translations 2024-05-15 10:34:50 +02:00
Akhil Narang
4298fc0493
Merge pull request #26434 from akhilnarang/fix-multiselectdialog 
fix: preserve checked items after a search
 2024-05-15 13:12:33 +05:30
Akhil Narang
19f01c990c
fix: preserve checked items after a search 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-15 12:53:35 +05:30
Ankush Menat
6fb6c4035c
Merge pull request #26433 from ankush/query_optimzier 
feat(recorder): Suggest index for optimizing query
 2024-05-14 19:08:41 +05:30
Ankush Menat
b169f8780a feat: Add identified index from UI 2024-05-14 18:54:38 +05:30
Ankush Menat
4e251e9b0b feat(recorder): Suggest query index 2024-05-14 16:05:58 +05:30
Ashish Shah
fdc2bd8fe6
feat: functionality to assign users by user group (#26044) 
* feat: functionality to assign users by user group

* fix: incorporate four comments from review by ankush

* fix: linting issues
 2024-05-14 15:35:33 +05:30
Corentin Flr
ace4ea328b
fix(translate)!: Don't add decontextualized translations 2024-05-14 11:00:46 +02:00
Ankush Menat
49f8f4fe45 fix(UX): colour duration to highlight bad rows 2024-05-14 12:22:03 +05:30
Ankush Menat
bbf18d39cc
Merge pull request #26369 from gavindsouza/refactor-scheduled-server_script 
refactor!: Server Script (Scheduler Event) & misc APIs
 2024-05-13 20:25:29 +05:30
gavin
665a18b063
fix: Implement Truthy.__eq __ 
Implement equality check, compare with True rather than self for a Truthy instance

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
 2024-05-13 14:17:40 +02:00
Ankush Menat
16c8a30861 fix: Avoid erasing recorder during clear_cache 
This reverts commit eadfe86fd834f43925956fa6d759127aaf363441.
 2024-05-13 17:41:34 +05:30
Ankush Menat
aba8d4e5b5 fix(DX): fix up column widths in recorder grid 
Query is most important yet it was only taking 2 cols, unreadable.
 2024-05-13 17:38:18 +05:30
Ankush Menat
65debdb137
test: Drop threshold for JS builds to be 1% (3.3 KB) (#26426) 
Multiple recent cases of unknowingly pushing more JS in `/app`'s JS.
 2024-05-13 10:08:14 +00:00
Gavin D'souza
9c20649022
Revert "fix: ServerScript.safe_exec as a doc method" 
This reverts commit cf2a3e926e.
 2024-05-13 11:31:19 +02:00
Frappe PR Bot
78321360a6
chore: update POT file (#26325) 2024-05-13 08:23:47 +00:00
paurosello
c19e6a8732
feat: pre-login hook (#26394) 2024-05-13 13:41:06 +05:30
Ankush Menat
49fb60a0dd
Merge pull request #26360 from rutwikhdev/upgrade-fullcalendar 
feat: upgrade fullcalendar
 2024-05-13 13:38:34 +05:30
Corentin Flr
016e41c29a
fix(TextEditor): Show editable rich editor in grid row (#26366) 2024-05-13 13:38:11 +05:30
Smit Vora
4522d10afb
fix(test records): rollback only the test record that exists (#26415) 2024-05-13 13:34:23 +05:30
Raffael Meyer
da740081c6
fix: make rename_doc work pre_model_sync (#26419) 2024-05-13 13:32:23 +05:30
Rutwik Hiwalkar
35f0d92e40
Merge pull request #26328 from rutwikhdev/fix-empty-tree-view 
fix: new and add child button for empty tree doctype
 2024-05-13 12:48:40 +05:30
Rutwik Hiwalkar
b8f7c4c11f chore: show doctype name as root node in treeview 2024-05-13 11:31:19 +05:30
Rutwik Hiwalkar
def9630e1c chore: move fullcalendar libs to a separate bundle 2024-05-11 13:51:42 +05:30
Ankush Menat
c3c579bdc5 test: update asset size values 2024-05-11 13:51:42 +05:30
Rutwik Hiwalkar
e520a39da8 fix: misc fixes for event datetime and styling 2024-05-11 13:23:27 +05:30
Rutwik Hiwalkar
20355fe31b fix: css styling for calendar and overriden styles 2024-05-11 13:23:27 +05:30
Rutwik Hiwalkar
7e145927bc fix: event datetime utils for calendar 
- move from momentjs to native date api
- simplify selection logic
 2024-05-11 13:23:27 +05:30
Rutwik Hiwalkar
3d29f90dbd chore: upgrade calendar component to latest 
feature parity for,
- toolbar actions
- show/hide weekend
- navigate through calendar and click events
 2024-05-11 13:23:27 +05:30
Rutwik Hiwalkar
c7c3eee6d5 build(deps): add fullcalendar and related plugins 2024-05-11 13:23:21 +05:30
Akhil Narang
7eeb6644c8
Merge pull request #26401 from akhilnarang/fix-table-multiselect-tab-selection 
fix: allow navigating to `Table MultiSelect` fields using tab
 2024-05-10 18:34:56 +05:30
Nikhil Kothari
fb2753fcaf
fix: pass user and shared params when checking for cache keys (#26402) 
* fix: pass user and shared params when checking for cache keys

* chore(test): added test for user cache in redis_cache
 2024-05-10 12:48:43 +00:00
Akhil Narang
7d27602c07
fix: allow navigating to Table MultiSelect fields using tab 
It was skipped earlier as it was part of `no_value_type` and didn't have an exception added like `Table`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-10 17:49:07 +05:30
Mate Laszlo Valko
0f4e916c8d fix: comments 2024-05-10 00:16:22 +02:00
Akhil Narang
2c0b77bf81
Merge pull request #26389 from akhilnarang/fix-unfollow 
fix(document_follow): `following` was treated as a string not a boolean
 2024-05-09 16:04:46 +05:30
Ankush Menat
5de5e25df6
fix: datetime comparison in QB (#26364) 
closes https://github.com/frappe/frappe/issues/26363
 2024-05-09 10:19:27 +00:00
Akhil Narang
5050376c55
fix(document_follow): following was treated as a string not a boolean 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-09 14:02:19 +05:30
Ankush Menat
c2d5ef175c
fix: cache github release data per bench (#26382) 
Reduce API calls to github as public calls are limited.
 2024-05-09 06:52:39 +00:00
Ankush Menat
53517630ae
fix: Increase folder link field size (#26381) 
* fix: increase folder length to 255

File `name` is 255 because it's bootstrapped using mariadb.sql, so users
can create 255 char long folders but can't store anything in it.

* fix(UX): slightly better character len message

Highlight field by making it bold.
 2024-05-09 12:10:21 +05:30
Akhil Narang
1cebdb257d
chore(doctype/file): update comments 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-08 16:19:10 +05:30
Akhil Narang
123844b10d
chore(csvutils): update messages 
Avoid semgrep issue with translated string

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-08 16:18:53 +05:30
Akhil Narang
26164ca600
Merge pull request #26377 from akhilnarang/add-back-request-raise-for-status 
fix(integrations): add back `response.raise_for_status()`
 2024-05-08 15:28:13 +05:30
Akhil Narang
19b696acf6
fix(integrations): add back response.raise_for_status() 
It got removed in 59ca074780, however it
should still be here, the point of that commit was to fix other
behaviour, don't exactly remember why it was removed.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-08 15:14:41 +05:30
Akhil Narang
a623d1b285
Merge pull request #26372 from akhilnarang/drop-read-only-excel-read 
chore(openpyxl): don't set `read_only=True` while reading an excel file
 2024-05-08 12:28:00 +05:30
Akhil Narang
af5af9b7a1
chore(openpyxl): don't set read_only=True while reading an excel file 
The way openpyxl parses files is very different, and read only seems to break with certain files
It tries to head information about the max rows/columns from the header in the case of read only
which can be wrong sometimes.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-05-08 11:42:07 +05:30