Commit graph

53710 commits

Author SHA1 Message Date
Luis Mendoza
b408bc92c5
fix: hide Submit button on non-submittable doctypes (#36825)
can_submit() only checked docstatus, permissions, and workflow
but never verified the doctype is actually submittable. Since all
documents start at docstatus 0, this caused a Submit button to
appear on any non-submittable doctype where the user has submit
permission (e.g. System Manager).
2026-02-07 06:15:17 +00:00
Ejaaz Khan
25df73931b
Merge pull request #36805 from nishkagosalia/data-import-depends-on
feat: Show color for  depends on fields for data import
2026-02-06 18:45:17 +05:30
Nishka Gosalia
cb278ff39d feat: Show color for depends on fields for data import 2026-02-06 17:31:47 +05:30
Ankush Menat
e30bfaf4e3
fix: Limit meme types on image fields (#36800)
* Revert "fix(file-upload): add support for blocking unsupported file types in file uploader (#36736)"

This reverts commit fe5072fa23.

* fix: Limit allowed MIME types for image fields

original and simpler version of #36736 that I overengineered.
2026-02-06 11:10:02 +00:00
Ankush Menat
61cb4646c4
fix: Honor disable async configuration (#36795) 2026-02-06 09:55:42 +00:00
Prathamesh Kurunkar
fe5072fa23
fix(file-upload): add support for blocking unsupported file types in file uploader (#36736)
* feat: add support for blocking unsupported file types in file uploader

* chore: pre-commit fix formatting

* fix: restrict image type in file upload and show better errors

* chore: allow all image types by default

Simplified allowed file types for image uploads to 'image/*'.

* chore: allow all image types by default

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-06 09:37:19 +00:00
Ankush Menat
eb59ab2817
fix: More reliable tags count result processing (#36783)
Use dicts instead of lists.
2026-02-06 07:40:35 +00:00
Soham Kulkarni
83617f20f6
Merge pull request #36772 from sokumon/billing-card
feat: sidebar card
2026-02-06 12:18:01 +05:30
Ankush Menat
4e91b1a281
fix: Support short session idle durations (#36773)
closes https://github.com/frappe/frappe/issues/35209
2026-02-06 06:46:19 +00:00
Kaushal Shriwas
b39800e5aa
fix: replace bare raise statement with AuthenticationError in oauth.py (#36729)
* fix: replace bare raise statement with AuthenticationError in oauth.py

* fix: add error log
2026-02-06 12:09:51 +05:30
Prathamesh Kurunkar
db9a4e9086
fix(typo): correct spelling of "Google Calendar" (#36767) 2026-02-06 12:03:18 +05:30
Prathamesh Kurunkar
7ea1767c46
fix(perm): permission handling for Administrator role in has_perm/get_perm JS API (#36637)
* fix(perm): permission handling for Administrator role in has_perm/get_perm

* chore(lint): remove linting issues

* refactor(perm): improve permission level retrieval readability
2026-02-06 12:02:56 +05:30
Prathamesh Kurunkar
357d62a172
fix(ui): edit button misalignment in address and contact fields (#36651)
* fix(ui): edit button misalignment in address and contact fields

* style(ui): consolidate styles for address and contact boxes in controls.scss

* chore(lint): fix linting issues

* style: adjust line-height for contact box paragraph
2026-02-06 11:58:27 +05:30
sokumon
d33a1e0654 fix: hover state and make api for adding card 2026-02-06 11:50:00 +05:30
sokumon
d82315cc87 fix: styling for the card 2026-02-06 03:19:53 +05:30
Soham Kulkarni
059763f797
Merge pull request #36760 from sokumon/desktop-rendering
fix(desktop): show correct keyboard shortcut
2026-02-05 22:00:49 +05:30
Suraj Shetty
0980d5898f
Merge pull request #36741 from ShrihariMahabal/fix-email-indicator
fix: render email header indicator correctly
2026-02-05 21:58:03 +05:30
Suraj Shetty
07e730fca6
Merge pull request #36740 from surajshetty3416/fix-grid-reordering-issue
fix(sync): Make sure child records are properly synced on save
2026-02-05 21:53:14 +05:30
Suraj Shetty
bf6fce6084
Merge pull request #36735 from akhilnarang/fix-share-if-owner
fix(share): use `has_permission` instead of `get_role_permissions`
2026-02-05 21:50:31 +05:30
sokumon
2deae864d0 fix(desktop): show correct keyboard shortcut 2026-02-05 21:24:11 +05:30
Shrihari Mahabal
612e02da02 fix: modify email header test and email header html to support indicators 2026-02-05 19:12:25 +05:30
Aarol D'Souza
77af2d53d6
fix(system console): allow read-only queries in system console (#36652)
* fix(system console): allow read-only queries in system console

* fix(security): make transactions strictly read only for console and scripts

* test: remove test to reflect ban on cte's for security

* fix: Only enable read only mode for SQL query

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-05 11:39:10 +00:00
Suraj Shetty
78b0f4b080
Merge pull request #36751 from safwansamsudeen/fix-eval-error
fix: use indirect eval
2026-02-05 17:03:19 +05:30
Akhil Narang
95fbf02ed7
build(deps): move faker out of dev dependencies (#36747)
`frappe.mock()` uses it. Although that's used only in tests, its defined under frappe namespace, so should be accessible without development dependencies.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-05 16:46:38 +05:30
Safwan Samsudeen
90bb08a279 fix: use indirect eval 2026-02-05 16:33:40 +05:30
Ankush Menat
c9cdacb4ce
feat: Optionally force type checking on whitelisted methods (#36744) 2026-02-05 16:20:41 +05:30
Soham Kulkarni
c5d68908e3
Merge pull request #36742 from sokumon/sidebar-item-filter
fix: transform filter correctly to match route options
2026-02-05 16:14:43 +05:30
Shrihari Mahabal
dc7582f29c fix: render email header indicator correctly 2026-02-05 14:31:11 +05:30
sokumon
231289c233 fix: transform filter correctly to match route options 2026-02-05 14:23:05 +05:30
Suraj Shetty
0a895b0490 fix(sync): Make sure child records are properly synced on save 2026-02-05 14:01:28 +05:30
Akhil Narang
7d67a5514a
fix(share): use has_permission instead of get_role_permissions
It handles is_owner checks as well

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-05 12:50:20 +05:30
Ejaaz Khan
9b24450337
Merge pull request #36630 from KerollesFathy/fix-assign-to
fix: add optional chaining to prevent errors when accessing `docinfo` properties
2026-02-05 12:10:35 +05:30
Ejaaz Khan
630ad32513
Merge pull request #36732 from iamejaaz/v16-form-fixes
fix(grid): remove fix width of action columns
2026-02-05 11:44:08 +05:30
Ejaaz Khan
74a566d9aa fix(grid): remove fix width of action columns 2026-02-05 11:41:12 +05:30
Suraj Shetty
58421c8b7b
Merge pull request #36730 from frappe/portal-search
fix: show search filter on portals and fix layout
2026-02-05 11:35:09 +05:30
krantheman
5d135a20b2 fix: show search filter on portals and fix layout 2026-02-05 12:45:23 +07:00
Suraj Shetty
cbcd864522
Merge pull request #36723 from stravo1/fix-print-format-save-issue
fix(sync): skip dunder prefixed fields while adding child docs to locals
2026-02-05 09:54:05 +05:30
Suraj Shetty
66bf9a6894
Merge pull request #36724 from stravo1/datetime-position-fix
fix(datepicker): removed check which prevented quick entry from updaitng position
2026-02-05 09:50:51 +05:30
Suraj Shetty
6f842d8aed
Merge pull request #36604 from GursheenK/fetch-title-for-link-title
fix: use linked doc title field if document has title field of link type
2026-02-05 09:36:10 +05:30
Suraj Shetty
eec4ba71d6
Merge pull request #36717 from frappe/l10n_develop
fix: sync translations from crowdin
2026-02-05 09:31:43 +05:30
Suraj Shetty
dda4ca09fc
Merge pull request #36682 from GursheenK/link-filters-not-working-for-list-quick-filters
fix(List View): respect link filters in quick filter section
2026-02-05 09:28:52 +05:30
Suraj Shetty
c9010418f7
Merge pull request #36691 from TITANiumRox/fix-fetch-from-read-only
fix: reset read-only on fetch-from fields
2026-02-05 09:24:44 +05:30
stravo1@mac
159df79141 fix(datepicker): removed check which prevented quick entry from updating position
fixes #20222
2026-02-05 09:23:03 +05:30
stravo1@mac
3cbab65e15 fix: skip dunder prefixed fields while adding child docs to locals
these include fields like __print_formats, __workflow_docs which do not actually contain child docs for the doctype.

caused issue #18581 where the local print format doc was being unlinked from cur_frm while sycing as it also synced __print_formats.
2026-02-05 09:16:50 +05:30
Suraj Shetty
48498f0227
Merge pull request #36718 from KerollesFathy/fix-setup-mobile
fix(mobile): avoid list view crash when standard filters are not initialized
2026-02-05 09:00:48 +05:30
Suraj Shetty
21a62cf977
Merge pull request #36719 from GursheenK/border-radius-for-listview-row
fix(List View): hover state for list rows
2026-02-05 08:21:13 +05:30
Gursheen Anand
ff27ca9922 fix: remove unnecessary selector 2026-02-05 00:27:52 +05:30
Gursheen Anand
f8534ac39a fix: hover shadow in row 2026-02-05 00:04:49 +05:30
Gursheen Anand
fd6b958756 fix: border radius and hover state for list row 2026-02-04 23:04:40 +05:30
KerollesFathy
3c4d988ddc fix(mobile): avoid list view crash when standard filters are not initialized 2026-02-04 17:24:03 +00:00