Commit graph

43306 commits

Author SHA1 Message Date
Ankush Menat
b409a05e8e fix: Ignore all non-import exceptions 2023-09-15 16:22:09 +05:30
Ankush Menat
c189b7e622 revert: syncing of report and pages 2023-09-15 16:22:06 +05:30
Ankush Menat
662b07170c test: orpahned doctype check after patch test 2023-09-15 16:18:25 +05:30
Ankush Menat
b9ee6827b4 refactor: stale object removal
- Do it after migration, post migration might use some old doctype.
- stale -> orpahn
- dont commit changes individually
- Remove table doctype too
2023-09-15 16:18:25 +05:30
Ankush Menat
b6d65fea06 ci: update patch workflow
- start with v13 DB, drop py3.7
- New flow v13DB -> V14 -> V15 (when released) -> PR commit
- Restart bench before final migrate
2023-09-15 16:18:25 +05:30
14987
2937ba38db fix: Update get_doc filter 2023-09-15 16:18:25 +05:30
14987
31a1d37f0a refactor: Fix ambigious var name 2023-09-15 16:18:25 +05:30
14987
b9449a4f13 fix: Delete stale doctypes, reports and pages 2023-09-15 16:18:25 +05:30
HENRY Florian
cf63690a3c
feat: use Link field for search in Role Permissions Manager (#22232)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2023-09-15 15:13:02 +05:30
Gursheen Kaur Anand
e03525efba
fix: remove items linked to non-existing doctypes from portal settings (#22417)
* fix: remove non-existing ref doctypes from portal settings

* fix: use separate list to iterate
2023-09-15 15:06:51 +05:30
0xsaif
87c1a9d7d7
refactor: Ensure admin receives a valid backup encryption key (#22411)
* refactor: Ensure admin receives a valid backup encryption key

- Added logic to retrieve or generate a backup encryption key if not present.

* refactor: simplify code

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-15 11:40:10 +05:30
Raffael Meyer
d43212792d
fix: update help links (#22413) 2023-09-15 11:37:27 +05:30
Ankush Menat
530c47ffe5
feat: after_response callback manager (#22398)
* feat: `after_response` callback manager

* perf: defer closing DB connection

* refactor: simplify after response hooks

* wip

* example usage

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>

* fix: Log request end if not already

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-09-14 10:56:08 +00:00
Suraj Shetty
2587d3e2e0
perf: Enqueue "removing of index" on web page save (#22409)
* perf: Enqueue "removing of index" on web page save

* fix: Enqueue after commit

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

* fix: enqueue after commit

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-14 14:58:19 +05:30
Ankush Menat
909457de3d
fix: PDF and raw response (#22402) 2023-09-13 16:42:49 +00:00
Ankush Menat
9244140816
fix!: Bind development server only to localhost (#22397) 2023-09-13 17:26:19 +05:30
Ankush Menat
88896f8f41 fix: keep localhost for smtp checks 2023-09-13 17:06:28 +05:30
0xsaif
aa7ee1c6b9
refactor: force ipv4 localhost (#22394)
* reafctor: force ipv4 localhost

Replacing "localhost" with "127.0.0.1" in the codebase; sometimes the name localhost force-resolves to ipv6

* revert: leave localhost usage in oauth tests

Change not required.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-13 16:23:23 +05:30
google-boy
9d8c6012a2
fix: Check if user has no associated email accounts. (#22355)
check that the return array does not exist, is not an array, or is empty 

http://stackoverflow.com/questions/24403732/ddg#24403771
2023-09-13 14:40:29 +05:30
Ankush Menat
970a740164
revert: #22308 (#22389)
* Revert "chore: move function to correct file"

This reverts commit ebfdfa283b.

* Revert "refactor!: merge get_site_url into get_url (#22308)"

This reverts commit 2001bc278f.
2023-09-13 14:34:52 +05:30
Alfredo Altamirano
39c06cffcd
fix: pass console to import file (#22385)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-13 14:28:52 +05:30
Deepesh Garg
b3742b45a8
Merge pull request #22104 from GursheenK/doc-comparator
feat: audit trail
2023-09-13 14:04:15 +05:30
Ankush Menat
b445c20e22
test: ignore whitespace changes while comparing HTML (#22386) 2023-09-13 08:18:56 +00:00
Ankush Menat
c55dcc439e
feat: max_file_size configurable from system settings (#22384)
also increase default max_file_size from 10MB to 25MB
2023-09-13 13:33:36 +05:30
Ankush Menat
0eb509aac3
refactor: Correct Content-Disposition headers (#22383) 2023-09-13 12:57:14 +05:30
Ankush Menat
64dd4b876b fix: UI test dont start without init 2023-09-13 12:33:49 +05:30
ViralKansodiya
b0bb9a55d5
fix: error while export a doctype report in excel (#22376)
* fix: error while export a doctype report in excel

* Update frappe/utils/response.py

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-13 12:13:31 +05:30
Ankush Menat
4b336b47a1 fix: broken link preview 2023-09-13 11:34:06 +05:30
Shariq Ansari
cfb6e36441
Merge pull request #22378 from shariquerik/workspace-has-role-fix 2023-09-13 11:29:44 +05:30
Shariq Ansari
cbb80ed0ee fix: getting workspace roles from doc instead from Has Role doctype 2023-09-12 18:10:41 +05:30
Gursheen Anand
aa18c4f751 fix: rename imports 2023-09-12 13:56:23 +05:30
Gursheen Anand
99df38a264 refactor: avoid fetch for amended field again 2023-09-12 12:57:33 +05:30
Gursheen Anand
bda868b0c2 fix: rename doctype 2023-09-12 12:56:48 +05:30
Psyi Rius
c3db5fca23
fix: typo in jinja2 templates (#22353) 2023-09-12 09:43:17 +05:30
Ankush Menat
045d35b89e fix: escape awesomeplete label titles 2023-09-11 22:01:01 +05:30
Ankush Menat
ebfdfa283b chore: move function to correct file 2023-09-11 19:02:34 +05:30
Corentin Flr
8882679357
fix: Ensure Google Calendar scopes is a List (#22333) 2023-09-11 18:04:22 +05:30
Ankush Menat
3e8a192828 chore: escape instead of sanitizing 2023-09-11 18:01:09 +05:30
Suraj Shetty
35000c2e4f
fix: + btn not appearing for connections with both internal and external links (#22320) 2023-09-11 15:51:28 +05:30
David Arnold
2001bc278f
refactor!: merge get_site_url into get_url (#22308)
* chore: merge get_site_url into get_url

* fix: keep alias with deprecation notice
2023-09-11 15:09:05 +05:30
Suraj Shetty
1ec87615fe
Merge pull request #22347 from surajshetty3416/update-datatable 2023-09-11 13:16:25 +05:30
Suraj Shetty
c135e3d07a build(deps): Bump frappe-datatable to 1.17.3 2023-09-11 13:15:08 +05:30
Gursheen Anand
a7a6f438be fix: use latest doc name for test 2023-09-11 11:49:40 +05:30
Gursheen Anand
4add076285 refactor: use old value instead of fetching parent doc 2023-09-11 11:15:24 +05:30
Gursheen Anand
0b722906db fix: fetch prev docs from last amended doc 2023-09-11 11:10:06 +05:30
Gursheen Anand
177955a12f fix: check label for fields 2023-09-11 11:06:01 +05:30
mergify[bot]
1f810c14a8
fix: convert category tojson (#22342) (#22343)
(cherry picked from commit 91c4a9571da5255186c26b78b5b21800f758055f)

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-10 17:08:29 +05:30
Ankush Menat
4a5e584ad0
refactor: escape instead of sanitizing HTML (#22339)
Traceback if it contains HTML can be useful, better to escape and show
instead of modifying it.
2023-09-10 09:43:47 +00:00
Bernd Oliver Sünderhauf
2efdead485
fix: Defer module deletion IO post DB commit (#22336)
* fix: Defer module deletion IO post DB commit

Previously, the IO operations for module deletion were executed before the DB commit. If the latter failed, this caused significant inconsistencies. This change ensures that IO operations are deferred until after the DB transaction is successfully committed.

* refactor: module deletion

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-10 13:00:50 +05:30
Raffael Meyer
650fe1598c
chore(translations): prisoner exchange with erpnext (#22338)
* chore: migrate translations to erpnext

* chore: migrate translations from erpnext
2023-09-10 10:27:59 +05:30