Commit graph

42653 commits

Author SHA1 Message Date
Ankush Menat
b4ea330c86
Merge pull request #21683 from ankush/on_demand_tags
perf: lazy load sidebar tag stats
2023-07-15 13:36:09 +05:30
Ankush Menat
b2b0bb69bb fix: Correct event for sidebar dropdown
- Click only gets called first time and not reliable next times
- Click will also get called when it's used for collapsing dropdown,
  which doesn't make sense here.
2023-07-15 13:14:04 +05:30
Ankush Menat
9a9705bd11 fix(UX): Show loading state while loading tags 2023-07-15 12:54:08 +05:30
Ankush Menat
5841f29610 refactor: rename poorly named variables
stats are actually columns in DB
columns are for verifying if DB column exists hence db_columns
other stats was result.

Renamed everything to avoid confusion.
2023-07-15 12:34:49 +05:30
Ankush Menat
d171a6d30a perf: lazy load sidebar stats
Sidebar stats take a huge time to load on large tables and it's not
required everytime you load the page. Best to only trigger it when user
clicks on "tags" (or other stats filter)

This is exactly how assignment and other filters work, so no need for
sidebar stats to work differently.
2023-07-15 12:29:46 +05:30
David Arnold
2ccab0d625
fix: checkpoint the supported schemes for connectivity (#21576)
* fix: checkpoint the supported schemes for connectivity

This PR implements a gateway + error that clearly hints the operator at
a misconfigured system during runtime.

Particularity, against the multiple library-provided ways of configuring
redis connection strings (in python), this hard stops if an unsupported
one is chosen by accident.

* fix: remove unknown protocol

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-07-15 11:05:29 +05:30
Ankush Menat
5c4f6c64c6
Merge pull request #21678 from ankush/eslint
ci: add eslint and update linting confs
2023-07-14 16:13:30 +05:30
Ankush Menat
b5409f6f07 chore: remove eslint-disable* 2023-07-14 15:41:20 +05:30
Ankush Menat
58cf770760 fix: All ESLint errors 2023-07-14 15:25:48 +05:30
Ankush Menat
9d357f36e6 ci: tweak eslint rules 2023-07-14 15:09:58 +05:30
Ankush Menat
7e596aaea8 ci: Add eslint in precommit 2023-07-14 14:32:06 +05:30
Ankush Menat
c3119af5b6 ci: unpin semgrep 2023-07-14 14:29:21 +05:30
Ankush Menat
347902ba96 ci: bump flake8 2023-07-14 14:26:20 +05:30
Ankush Menat
adf30693a9 ci: update pyupgrade 2023-07-14 14:24:08 +05:30
Ankush Menat
fefd9ac2e2
fix: connect_replica and read_only should be idempotent (#21674)
* fix: `connect_replica` should be idempotent

Calling `connect_replica` twice ends up forgetting orginal writable
replica completely.

* test: replicas

closes https://github.com/frappe/frappe/issues/21619
2023-07-14 13:56:57 +05:30
David Arnold
6b2bb9a2ab
fix: add env overrides for service orchestration (#21577)
This avoids having to manipulate config files in brittle bash
entrypoints that need to react to dynamic service discovery.

This significantly improves the operability of various bench sites.
2023-07-14 11:39:01 +05:30
David Arnold
98d38e7333
fix: gently log the port on which the realtime service listens (#21575)
* fix: gently log the port on which the realtime service listens

without this, the service remains completely silent (e.g. in overmind) and it is hard to tell if it is even running

* Revert "fix: gently log the port on which the realtime service listens"

This reverts commit 14a21989c6767520d8e1b9d46cc9f58a45768563.

* refactor(socketio): explicitly listen on port

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-14 11:36:31 +05:30
Shariq Ansari
0a0f6ac2ca
Merge pull request #21665 from shariquerik/revert-auto-repeat-pr 2023-07-13 17:06:22 +05:30
Shariq Ansari
75b26cc96b revert: do not create comm on auto repeat #20606 2023-07-13 16:15:25 +05:30
Shariq Ansari
d93bf38251
Merge pull request #21657 from shariquerik/workflow-state-indicator-fix 2023-07-13 10:49:18 +05:30
Nautatava Navlakha
c2d35b773b
fix: add numbers correctly in report column total (#21661)
[skip ci]
2023-07-13 10:32:53 +05:30
Ankush Menat
14798146c7
fix: Conditionally show extra info for perm error (#21660) 2023-07-12 22:22:34 +05:30
Ankush Menat
154a6dd9ed
perf: Reduce recorder overhead (#21656)
By processing `EXPLAIN` of queries in background after recording is
completed, the overhead reduces significantly and hence can be used
"more" in production environment too.
2023-07-12 19:34:23 +05:30
Shariq Ansari
2681364bca fix: show workflow state in indicator if dont override status is set in workflow 2023-07-12 19:30:02 +05:30
Ankush Menat
2045d48fc8 chore: remove unseen error message alert
Unnecessary and not useful for most users.

We should instead have dashboard for system status.
2023-07-12 17:01:11 +05:30
Ankush Menat
fdf5350b77 ci: remove 'by mergify' in release notes
less clutter
2023-07-12 12:42:41 +05:30
Ankush Menat
04c1459631
fix: prevent importing core doctypes using data import tool (#21649)
[skip ci]
2023-07-12 12:07:33 +05:30
Ankush Menat
17aad073d7
ci: fix release notes generator (#21651)
Without quotes it gets splatted and treated as separate args. Yes, bash.
2023-07-12 12:06:35 +05:30
Shariq Ansari
ed95f87cae
Merge pull request #21643 from shariquerik/fetch_from_fix 2023-07-12 10:49:29 +05:30
Shariq Ansari
4bb85c70fd
Merge pull request #21639 from shariquerik/translated-autocomplete-options 2023-07-12 10:49:10 +05:30
Raffael Meyer
218f7b473b
fix(Query Report): no double translation (#21606) 2023-07-11 20:21:16 +05:30
Ankush Menat
3de0eb3243
refactor: Use URLSearchParams API for list view filters (#21647)
This gives better data structure to manipulate than simple strings.
2023-07-11 20:12:20 +05:30
Ankush Menat
f6751bf415 refactor: use event.status instead of event.event_type
Required after https://github.com/frappe/frappe/pull/21471
2023-07-11 19:02:43 +05:30
Corentin Flr
3229e2869c
fix(event)!: Move "Cancelled" to status instead of event_type (#21471) 2023-07-11 18:56:57 +05:30
Corentin Flr
e8a57c63ce
fix(setup_wizard): Don't send headers when exception happens on command line (#21641)
Co-authored-by: Corentin Forler <8860073-cforler_dokos@users.noreply.gitlab.com>
2023-07-11 18:41:13 +05:30
Shariq Ansari
7f1ec8b0a6
Merge pull request #21488 from HarryPaulo/calendar-translation-buttons 2023-07-11 18:38:11 +05:30
Shariq Ansari
517c006af0
Merge branch 'develop' into translated-autocomplete-options 2023-07-11 18:23:47 +05:30
Shariq Ansari
dd97f76e57
Merge branch 'develop' into fetch_from_fix 2023-07-11 18:23:37 +05:30
Shariq Ansari
d272333849
Merge branch 'develop' into calendar-translation-buttons 2023-07-11 18:23:06 +05:30
Shariq Ansari
3e012f4186
chore: linter fix 2023-07-11 18:22:49 +05:30
Shariq Ansari
59e38ccd7a fix: better fetch_if_empty (old fix #19586) 2023-07-11 18:10:27 +05:30
Ankush Menat
ec5abcb3f5 fix: populate form tour fields
closes https://github.com/frappe/frappe/issues/21455
2023-07-11 18:08:09 +05:30
rohitwaghchaure
84c5e556bf
fix: removed the output field from the console log (#21600) 2023-07-11 17:17:27 +05:30
dependabot[bot]
9d15768536
build(deps): bump semver from 5.7.1 to 5.7.2 (#21640)
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-11 16:46:26 +05:30
Shariq Ansari
8577bbbb3c fix: translate exported filename 2023-07-11 16:29:00 +05:30
Shariq Ansari
94583340ec fix: translate autocomplete options label 2023-07-11 16:11:29 +05:30
Ankush Menat
d731db352a
Merge pull request #21596 from Saboti215/patch-1
feat: Add ability to use HTML fields in grids
2023-07-11 15:32:08 +05:30
Sabu Siyad
9cdebcfca7
fix: typo: form builder: Fetch Form -> Fetch From (#21635)
[skip ci]
2023-07-11 15:24:27 +05:30
Suraj Shetty
d363452b32
Merge pull request #21630 from maharshivpatel/fix-web-form 2023-07-11 14:18:03 +05:30
Suraj Shetty
9a035864d5
Merge pull request #21629 from anandbaburajan/attach_multiple_files_to_document_fix 2023-07-11 14:16:03 +05:30